* [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout
@ 2020-09-05 5:54 Hamzeh Nasajpour
2020-09-12 12:01 ` Hamzeh Nasajpour
0 siblings, 1 reply; 3+ messages in thread
From: Hamzeh Nasajpour @ 2020-09-05 5:54 UTC (permalink / raw)
To: 43210
diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 21587609ce..baa2ee6795 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -379,6 +379,7 @@ the operating system LXQt is running on.")
("qtbase" ,qtbase)
("qtsvg" ,qtsvg)
("qtx11extras" ,qtx11extras)
+ ("setxkbmap" ,setxkbmap)
("solid" ,solid)
("xf86-input-libinput" ,xf86-input-libinput)
("xkeyboard-config" ,xkeyboard-config)
@@ -418,7 +419,16 @@ the operating system LXQt is running on.")
(("\\$\\{LXQT_TRANSLATIONS_DIR\\}")
(string-append (assoc-ref outputs "out")
"/share/lxqt/translations")))
- #t)))))
+ #t))
+ (add-after 'install 'wrap-for-setxkbmap-path
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out"))
+ (setxkbmap (assoc-ref %build-inputs "setxkbmap")))
+ (wrap-program (string-append out "/bin/lxqt-config")
+ `("PATH" ":" prefix (,(string-append setxkbmap "/bin/"))))
+ (wrap-program (string-append out "/bin/lxqt-config-input")
+ `("PATH" ":" prefix (,(string-append setxkbmap "/bin/"))))
+ #t))))))
(home-page "https://lxqt.github.io")
(synopsis "Tools to configure LXQt and the underlying operating system")
(description "lxqt-config is providing several tools involved in the
^ permalink raw reply related [flat|nested] 3+ messages in thread* [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout
2020-09-05 5:54 [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout Hamzeh Nasajpour
@ 2020-09-12 12:01 ` Hamzeh Nasajpour
2020-09-24 15:22 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Hamzeh Nasajpour @ 2020-09-12 12:01 UTC (permalink / raw)
To: 43210
Hi guys.
Seems that anyway we have to add `setxkbmap` to `propagated-inputs`. The previous commit will fix the adding `keyboard-layout` but without having the `setxkbmap` in `propagated-inputs` the added layouts won't add as permanent and will be reset after each reboot. So again, we need to add `setxkbmap` as a dependency in `propagated-inputs`.
On Sat, Sep 5, 2020, at 10:24 AM, Hamzeh Nasajpour wrote:
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index 21587609ce..baa2ee6795 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -379,6 +379,7 @@ the operating system LXQt is running on.")
> ("qtbase" ,qtbase)
> ("qtsvg" ,qtsvg)
> ("qtx11extras" ,qtx11extras)
> + ("setxkbmap" ,setxkbmap)
> ("solid" ,solid)
> ("xf86-input-libinput" ,xf86-input-libinput)
> ("xkeyboard-config" ,xkeyboard-config)
> @@ -418,7 +419,16 @@ the operating system LXQt is running on.")
> (("\\$\\{LXQT_TRANSLATIONS_DIR\\}")
> (string-append (assoc-ref outputs "out")
> "/share/lxqt/translations")))
> - #t)))))
> + #t))
> + (add-after 'install 'wrap-for-setxkbmap-path
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out"))
> + (setxkbmap (assoc-ref %build-inputs
> "setxkbmap")))
> + (wrap-program (string-append out
> "/bin/lxqt-config")
> + `("PATH" ":" prefix (,(string-append
> setxkbmap "/bin/"))))
> + (wrap-program (string-append out
> "/bin/lxqt-config-input")
> + `("PATH" ":" prefix (,(string-append
> setxkbmap "/bin/"))))
> + #t))))))
> (home-page "https://lxqt.github.io")
> (synopsis "Tools to configure LXQt and the underlying operating
> system")
> (description "lxqt-config is providing several tools involved in
> the
^ permalink raw reply [flat|nested] 3+ messages in thread* [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout
2020-09-12 12:01 ` Hamzeh Nasajpour
@ 2020-09-24 15:22 ` Ludovic Courtès
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2020-09-24 15:22 UTC (permalink / raw)
To: Hamzeh Nasajpour; +Cc: 43210
Hi,
"Hamzeh Nasajpour" <h.nasajpour@pantherx.org> skribis:
> Seems that anyway we have to add `setxkbmap` to `propagated-inputs`. The previous commit will fix the adding `keyboard-layout` but without having the `setxkbmap` in `propagated-inputs` the added layouts won't add as permanent and will be reset after each reboot. So again, we need to add `setxkbmap` as a dependency in `propagated-inputs`.
Why is that? I fail to see why using ‘propagated-inputs’ instead of
wrapping would work better.
>> + (add-after 'install 'wrap-for-setxkbmap-path
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out"))
>> + (setxkbmap (assoc-ref %build-inputs
>> "setxkbmap")))
>> + (wrap-program (string-append out
>> "/bin/lxqt-config")
>> + `("PATH" ":" prefix (,(string-append
>> setxkbmap "/bin/"))))
>> + (wrap-program (string-append out
>> "/bin/lxqt-config-input")
>> + `("PATH" ":" prefix (,(string-append
>> setxkbmap "/bin/"))))
>> + #t))))))
For this case, it might be easier/preferable to replace ‘setxkbmap’ in
the source code with the absolute file name of ‘setxkbmap’.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-24 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-05 5:54 [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout Hamzeh Nasajpour
2020-09-12 12:01 ` Hamzeh Nasajpour
2020-09-24 15:22 ` Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).