unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Hamzeh Nasajpour" <h.nasajpour@pantherx.org>
Cc: 43210@debbugs.gnu.org
Subject: [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout
Date: Thu, 24 Sep 2020 17:22:56 +0200	[thread overview]
Message-ID: <87pn6b6vxr.fsf@gnu.org> (raw)
In-Reply-To: <48a7703f-7edf-48e0-b8a9-8e03944d5e20@www.fastmail.com> (Hamzeh Nasajpour's message of "Sat, 12 Sep 2020 16:31:33 +0430")

Hi,

"Hamzeh Nasajpour" <h.nasajpour@pantherx.org> skribis:

> Seems that anyway we have to add `setxkbmap` to `propagated-inputs`. The previous commit will fix the adding `keyboard-layout` but without having the `setxkbmap` in `propagated-inputs` the added layouts won't add as permanent and will be reset after each reboot. So again, we need to add `setxkbmap` as a dependency in `propagated-inputs`.

Why is that?  I fail to see why using ‘propagated-inputs’ instead of
wrapping would work better.

>> +          (add-after 'install 'wrap-for-setxkbmap-path
>> +            (lambda* (#:key outputs #:allow-other-keys)
>> +              (let ((out              (assoc-ref outputs "out"))
>> +                    (setxkbmap          (assoc-ref %build-inputs 
>> "setxkbmap")))
>> +                       (wrap-program (string-append out 
>> "/bin/lxqt-config")
>> +                            `("PATH" ":" prefix (,(string-append 
>> setxkbmap "/bin/"))))
>> +                       (wrap-program (string-append out 
>> "/bin/lxqt-config-input")
>> +                           `("PATH" ":" prefix (,(string-append 
>> setxkbmap "/bin/"))))
>> +               #t))))))

For this case, it might be easier/preferable to replace ‘setxkbmap’ in
the source code with the absolute file name of ‘setxkbmap’.

Thanks,
Ludo’.




      reply	other threads:[~2020-09-24 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05  5:54 [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout Hamzeh Nasajpour
2020-09-12 12:01 ` Hamzeh Nasajpour
2020-09-24 15:22   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn6b6vxr.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43210@debbugs.gnu.org \
    --cc=h.nasajpour@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).