From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sOwJMUrBbF/xHAAA0tVLHw (envelope-from ) for ; Thu, 24 Sep 2020 15:54:50 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cFPiLErBbF//DwAA1q6Kng (envelope-from ) for ; Thu, 24 Sep 2020 15:54:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4480B940668 for ; Thu, 24 Sep 2020 15:54:50 +0000 (UTC) Received: from localhost ([::1]:49448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLTa4-0001ZQ-TZ for larch@yhetil.org; Thu, 24 Sep 2020 11:54:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLT6I-0006S3-04 for guix-patches@gnu.org; Thu, 24 Sep 2020 11:24:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLT6H-0004pE-L6 for guix-patches@gnu.org; Thu, 24 Sep 2020 11:24:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLT6H-0005f7-Iy for guix-patches@gnu.org; Thu, 24 Sep 2020 11:24:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43210] [PATCH] gnu: lxqt-config: Wrapping the lxqt-config and lxqt-config-input and setting the setxkbmap PATH for fixing save added layout Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Sep 2020 15:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43210 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Hamzeh Nasajpour" Cc: 43210@debbugs.gnu.org Received: via spool by 43210-submit@debbugs.gnu.org id=B43210.160096098621668 (code B ref 43210); Thu, 24 Sep 2020 15:24:01 +0000 Received: (at 43210) by debbugs.gnu.org; 24 Sep 2020 15:23:06 +0000 Received: from localhost ([127.0.0.1]:41302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLT5N-0005dQ-MT for submit@debbugs.gnu.org; Thu, 24 Sep 2020 11:23:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLT5L-0005ca-S1 for 43210@debbugs.gnu.org; Thu, 24 Sep 2020 11:23:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34863) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLT5G-0004hw-4M; Thu, 24 Sep 2020 11:22:58 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57488 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kLT5F-0004Fh-KQ; Thu, 24 Sep 2020 11:22:57 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <2a9af2f5-62b9-45c9-bfa5-430241158521@www.fastmail.com> <48a7703f-7edf-48e0-b8a9-8e03944d5e20@www.fastmail.com> Date: Thu, 24 Sep 2020 17:22:56 +0200 In-Reply-To: <48a7703f-7edf-48e0-b8a9-8e03944d5e20@www.fastmail.com> (Hamzeh Nasajpour's message of "Sat, 12 Sep 2020 16:31:33 +0430") Message-ID: <87pn6b6vxr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: P+qdtsgeIECd Hi, "Hamzeh Nasajpour" skribis: > Seems that anyway we have to add `setxkbmap` to `propagated-inputs`. The = previous commit will fix the adding `keyboard-layout` but without having th= e `setxkbmap` in `propagated-inputs` the added layouts won't add as permane= nt and will be reset after each reboot. So again, we need to add `setxkbmap= ` as a dependency in `propagated-inputs`. Why is that? I fail to see why using =E2=80=98propagated-inputs=E2=80=99 i= nstead of wrapping would work better. >> + (add-after 'install 'wrap-for-setxkbmap-path >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((out (assoc-ref outputs "out")) >> + (setxkbmap (assoc-ref %build-inputs=20 >> "setxkbmap"))) >> + (wrap-program (string-append out=20 >> "/bin/lxqt-config") >> + `("PATH" ":" prefix (,(string-append=20 >> setxkbmap "/bin/")))) >> + (wrap-program (string-append out=20 >> "/bin/lxqt-config-input") >> + `("PATH" ":" prefix (,(string-append=20 >> setxkbmap "/bin/")))) >> + #t)))))) For this case, it might be easier/preferable to replace =E2=80=98setxkbmap= =E2=80=99 in the source code with the absolute file name of =E2=80=98setxkbmap=E2=80=99. Thanks, Ludo=E2=80=99.