From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Christopher Baines <mail@cbaines.net>
Cc: 59513@debbugs.gnu.org
Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy.
Date: Sat, 17 Dec 2022 00:01:16 -0500 [thread overview]
Message-ID: <87o7s2aajn.fsf_-_@gmail.com> (raw)
In-Reply-To: <20221208112051.5019-1-mail@cbaines.net> (Christopher Baines's message of "Thu, 8 Dec 2022 11:20:50 +0000")
Hi Christopher,
Christopher Baines <mail@cbaines.net> writes:
[...]
> * doc/contributing.texi (Commit Policy): Tweak.
> ---
> doc/contributing.texi | 41 ++++++++++++++++++-----------------------
> 1 file changed, 18 insertions(+), 23 deletions(-)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index 6a8ffd6524..d2e7abba98 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -1824,23 +1824,26 @@ It additionally calls @code{make check-channel-news} to be sure
>
> @subsection Commit Policy
>
> -If you get commit access, please make sure to follow
> -the policy below (discussions of the policy can take place on
> +If you get commit access, please make sure to follow the policy below
> +(discussions of the policy can take place on
> @email{guix-devel@@gnu.org}).
>
> -Non-trivial patches should always be posted to
> -@email{guix-patches@@gnu.org} (trivial patches include fixing typos,
> -etc.). This mailing list fills the patch-tracking database
> -(@pxref{Tracking Bugs and Patches}).
> -
> -For patches that just add a new package, and a simple one, it's OK to
> -commit, if you're confident (which means you successfully built it in a
> -chroot setup, and have done a reasonable copyright and license
> -auditing). Likewise for package upgrades, except upgrades that trigger
> -a lot of rebuilds (for example, upgrading GnuTLS or GLib). We have a
> -mailing list for commit notifications (@email{guix-commits@@gnu.org}),
> -so people can notice. Before pushing your changes, make sure to run
> -@code{git pull --rebase}.
> +Changes should be posted to @email{guix-patches@@gnu.org}. This mailing
> +list fills the patch-tracking database (@pxref{Tracking Bugs and
> +Patches}). It also allows patches to be picked up and tested by the
> +quality assurance tooling; the result of that testing eventually shows
> +up on the dashboard at
> +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where
> +@var{number} is the number assigned by the issue tracker. Leave time
> +for a review, without committing anything (@pxref{Submitting Patches}).
> +If you didn’t receive any reply after one week (two weeks for more
> +significant changes), and if you're confident, it's OK to commit.
> +
> +As an exception, some changes considered ``trivial'' or ``obvious'' may
> +be pushed directly. This includes changes to fix typos and reverting
> +commits that caused immediate problems. This is subject to being
> +adjusted, allowing individuals to commit directly on non-controversial
> +changes on parts they’re familiar with.
Like others, I like the direction of the change; the focus is changed
from "trivial patches are OK to push else wait 2 weeks" to "most changes
must go through the QA tooling", which should improve quality. Like
Vagrant, I think it adds some friction, especially if the QA is still
sometimes still unreliable and doesn't provide clear results (false
positives for example), but I'm not against trying it.
I guess we can try this new process, and adjust as we go (or revert to
the current policy) in case something doesn't work well enough.
--
Thanks,
Maxim
next prev parent reply other threads:[~2022-12-17 5:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 10:49 [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy Christopher Baines
2022-11-23 20:27 ` zimoun
2022-11-24 8:40 ` Christopher Baines
2022-11-24 11:59 ` zimoun
2022-11-28 11:46 ` Christopher Baines
2022-12-02 9:45 ` Ludovic Courtès
2022-12-01 21:44 ` Ludovic Courtès
2022-12-12 10:33 ` Christopher Baines
2022-12-12 11:47 ` Ludovic Courtès
2022-12-08 11:20 ` [bug#59513] [PATCH v2] " Christopher Baines
2022-12-08 13:53 ` Liliana Marie Prikler
2022-12-12 10:49 ` Christopher Baines
2022-12-12 20:27 ` Liliana Marie Prikler
2022-12-13 14:06 ` Christopher Baines
2022-12-14 0:54 ` Vagrant Cascadian
2022-12-14 10:21 ` Christopher Baines
2022-12-20 10:55 ` Ludovic Courtès
2022-12-17 5:01 ` Maxim Cournoyer [this message]
2023-01-05 9:12 ` zimoun
2023-01-11 10:48 ` Christopher Baines
2023-01-11 10:50 ` bug#59513: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7s2aajn.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=59513@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).