unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 59513@debbugs.gnu.org, zimoun <zimon.toutoune@gmail.com>
Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy.
Date: Fri, 02 Dec 2022 10:45:04 +0100	[thread overview]
Message-ID: <877czauokf.fsf_-_@gnu.org> (raw)
In-Reply-To: <871qps20fa.fsf@cbaines.net> (Christopher Baines's message of "Thu, 24 Nov 2022 08:40:59 +0000")

Hi,

Christopher Baines <mail@cbaines.net> skribis:

>> I would write:
>>
>>         … changes), and if you're confident (which means you
>>         successfully built it in a chroot setup, and have done a
>>         reasonable copyright and license auditing), it’s OK to commit.
>
> chroot setup doesn't really make sense to me, I'm not sure why that
> needs specifying

The chroot requirement is specified because a non-isolated build is
worth nothing: it might work on some machine and fail on another one for
hard-to-find reasons.

We could stop mentioning it if we think everyone keeps chroot enabled
(that’s probably the case), but it doesn’t hurt to keep it.

> (like do we not want things for the Hurd pushing, since the
> guix-daemon doesn't support build isolation there yet)?

Well yes, that’s the thing.  For i586-gnu we’re currently stuck because
we haven’t yet defined how to normalize the build environment:

  https://guix.gnu.org/en/blog/2020/childhurds-and-substitutes/
  https://issues.guix.gnu.org/43857

And it’s not theoretical: some util-linux tests may or may not work
depending on whether the Hurd box has /proc set up, the Texinfo test
suite would pass if there happens to be a usable ‘pt_chown’ program
around (see <https://issues.guix.gnu.org/59616>), etc.

So I think the current situation is that we can build base packages for
i586-gnu, that’s fine, but don’t have a solid foundation like we do on
GNU/Linux, so there’s no point in going too far.

Now, I don’t think the i586-gnu situation is an important consideration
for the commit policy.

Ludo’.




  parent reply	other threads:[~2022-12-02  9:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 10:49 [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy Christopher Baines
2022-11-23 20:27 ` zimoun
2022-11-24  8:40   ` Christopher Baines
2022-11-24 11:59     ` zimoun
2022-11-28 11:46       ` Christopher Baines
2022-12-02  9:45     ` Ludovic Courtès [this message]
2022-12-01 21:44 ` Ludovic Courtès
2022-12-12 10:33   ` Christopher Baines
2022-12-12 11:47     ` Ludovic Courtès
2022-12-08 11:20 ` [bug#59513] [PATCH v2] " Christopher Baines
2022-12-08 13:53   ` Liliana Marie Prikler
2022-12-12 10:49     ` Christopher Baines
2022-12-12 20:27       ` Liliana Marie Prikler
2022-12-13 14:06         ` Christopher Baines
2022-12-14  0:54   ` Vagrant Cascadian
2022-12-14 10:21     ` Christopher Baines
2022-12-20 10:55     ` Ludovic Courtès
2022-12-17  5:01   ` [bug#59513] [PATCH] " Maxim Cournoyer
2023-01-05  9:12   ` [bug#59513] [PATCH v2] " zimoun
2023-01-11 10:48     ` Christopher Baines
2023-01-11 10:50   ` bug#59513: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877czauokf.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=59513@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).