unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 59513@debbugs.gnu.org
Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy.
Date: Mon, 12 Dec 2022 12:47:44 +0100	[thread overview]
Message-ID: <87o7s8268v.fsf@gnu.org> (raw)
In-Reply-To: <871qp4rj6y.fsf@cbaines.net> (Christopher Baines's message of "Mon, 12 Dec 2022 10:33:46 +0000")

Hi Chris,

Christopher Baines <mail@cbaines.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>>>  @subsection Commit Policy
>>>
>>> -If you get commit access, please make sure to follow
>>> -the policy below (discussions of the policy can take place on
>>> +If you get commit access, please make sure to follow the policy below
>>> +(discussions of the policy can take place on
>>>  @email{guix-devel@@gnu.org}).

BTW, we should follow that policy :-) and send a heads-up on guix-devel.

> I've gone for "tooling" rather than "robot" as I'm not sure we want to
> go the way of personifying it. I'm not against that, but the place to
> start is probably not here.

Fine with me!

>>   shows up on the dashboard at
>>   @indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where
>>   @var{number} is the number assigned by the issue tracker.  Leave time
>>   […] it’s OK to commit.
>>
>>   As an exception, some changes considered consensual and ``trivial'' or
>
> I removed "consensual" here as I wasn't sure what was meant by that, or
> at least I'm not sure the phrasing fits the context here.
>
> Are you trying to say something about a belief that no one will object
> to the change being made?

Yes, exactly.  With experience in the project (like committers usually
have), you can often tell whether a given change might raise objections
or not.

Thanks for following up!

Ludo’.




  reply	other threads:[~2022-12-12 11:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 10:49 [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy Christopher Baines
2022-11-23 20:27 ` zimoun
2022-11-24  8:40   ` Christopher Baines
2022-11-24 11:59     ` zimoun
2022-11-28 11:46       ` Christopher Baines
2022-12-02  9:45     ` Ludovic Courtès
2022-12-01 21:44 ` Ludovic Courtès
2022-12-12 10:33   ` Christopher Baines
2022-12-12 11:47     ` Ludovic Courtès [this message]
2022-12-08 11:20 ` [bug#59513] [PATCH v2] " Christopher Baines
2022-12-08 13:53   ` Liliana Marie Prikler
2022-12-12 10:49     ` Christopher Baines
2022-12-12 20:27       ` Liliana Marie Prikler
2022-12-13 14:06         ` Christopher Baines
2022-12-14  0:54   ` Vagrant Cascadian
2022-12-14 10:21     ` Christopher Baines
2022-12-20 10:55     ` Ludovic Courtès
2022-12-17  5:01   ` [bug#59513] [PATCH] " Maxim Cournoyer
2023-01-05  9:12   ` [bug#59513] [PATCH v2] " zimoun
2023-01-11 10:48     ` Christopher Baines
2023-01-11 10:50   ` bug#59513: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7s8268v.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=59513@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).