From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EOpSIWVNnWOAewEAbAwnHQ (envelope-from ) for ; Sat, 17 Dec 2022 06:02:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OCRqIGVNnWO/oAAAG6o9tA (envelope-from ) for ; Sat, 17 Dec 2022 06:02:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B3A83E1D7 for ; Sat, 17 Dec 2022 06:02:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6PKp-00076X-JX; Sat, 17 Dec 2022 00:02:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6PKm-000757-BR for guix-patches@gnu.org; Sat, 17 Dec 2022 00:02:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6PKl-00023h-5b for guix-patches@gnu.org; Sat, 17 Dec 2022 00:02:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6PKk-00024U-1j for guix-patches@gnu.org; Sat, 17 Dec 2022 00:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 Dec 2022 05:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Christopher Baines Cc: 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.16712532887945 (code B ref 59513); Sat, 17 Dec 2022 05:02:02 +0000 Received: (at 59513) by debbugs.gnu.org; 17 Dec 2022 05:01:28 +0000 Received: from localhost ([127.0.0.1]:53731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6PKC-000245-Ah for submit@debbugs.gnu.org; Sat, 17 Dec 2022 00:01:28 -0500 Received: from mail-qv1-f45.google.com ([209.85.219.45]:39932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6PK8-00023v-DE for 59513@debbugs.gnu.org; Sat, 17 Dec 2022 00:01:26 -0500 Received: by mail-qv1-f45.google.com with SMTP id r15so2961094qvm.6 for <59513@debbugs.gnu.org>; Fri, 16 Dec 2022 21:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=wSdYI251HUSgE///VClDX0oePNqfyiBeXgCiHqa8Rf0=; b=WNoy/+4t7JkZhmfA+e6+7DrW/fCpMHPmIMy9B9n2nxRaQOiO4CiBnPr0ZhiIVFh+lu XpIa0gGqJhYuil7S01nj0s9d3g8byP48QQpyEc4jk/mQjpovoTH7Q+hSdFq1Mch7WOrF FCmNe6cKx2sM7+FthxtoNyT+HmOoJSgQaQBt9R2wq72wpNq7Eso8t030SzMhybanradU 1DZfqVAl22bq4ZADobUCkbd9OFSrTgz/4pBW+iUUaL8BRUmyM/3taFduIbiOfg8s7XZT lVYryWCivuIaMnz5GfysOM5D9bsHOvFkYh0C36auv0iPNyIiP+kEfzFKFJHnwp00aj6i fa+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wSdYI251HUSgE///VClDX0oePNqfyiBeXgCiHqa8Rf0=; b=PBL7H5o6X96nqxW3yV7sYsihFtSu8sCH3iCwA08iHacSJVtw86J0i/vCKzaQWz0xyb N3GLwgXUD2iJQ/L9UXMm9Mr4ImJDRbBkUzNCO/IbrwapFJ+kfsJbE7mbENjT27jRllCf SQsv35nRXo66AHrFVNv7N0qMmFLq/Esa1peue297ao7luckoMoU4jFDXbqjEjoQrxbWK noYvG1QI51TioTOprF/dQiDy7kfZcrbo0HC9Y0I+sbWsX28WKF9q7y5z+qbRwGZDEtNc 4cjqujoJXwJUZmiSo7TxJqCCvQPg/E0gdjjfUQGLCdl6BE554YG/hu8XEVw938KL60Du 7j1A== X-Gm-Message-State: AFqh2kqMz1wnTWvrg1BnhO34cxzkeGcK8Jd9JmJktQqcaHEbqHrW+HFP 9cIA+XvEfpcyUqdkV/eEW8OEkGxebbNDnN0h X-Google-Smtp-Source: AMrXdXvMmK6+lq4zNB37KKPq4zh+PTRyvVuVFsm0zJNeUfQBtTjmFOFZ1T6g+JC4PMeUcfMMsehiQg== X-Received: by 2002:a0c:c78b:0:b0:4c7:b9b:eab0 with SMTP id k11-20020a0cc78b000000b004c70b9beab0mr16238067qvj.40.1671253278492; Fri, 16 Dec 2022 21:01:18 -0800 (PST) Received: from hurd (dsl-159-157.b2b2c.ca. [66.158.159.157]) by smtp.gmail.com with ESMTPSA id y6-20020a05620a44c600b006fcb4e01345sm3017448qkp.24.2022.12.16.21.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 21:01:18 -0800 (PST) From: Maxim Cournoyer References: <20221123104946.29480-1-mail@cbaines.net> <20221208112051.5019-1-mail@cbaines.net> Date: Sat, 17 Dec 2022 00:01:16 -0500 In-Reply-To: <20221208112051.5019-1-mail@cbaines.net> (Christopher Baines's message of "Thu, 8 Dec 2022 11:20:50 +0000") Message-ID: <87o7s2aajn.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671253349; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wSdYI251HUSgE///VClDX0oePNqfyiBeXgCiHqa8Rf0=; b=qkiSi723BcrumjpWrHSLARfbCzpeUCfF8/derlBt1NzVCblFIghBlcoO8Plek9QXDe3y5j Jtb7lwXdSdFZn4bMk1Ev6AmMmZPtEKB5jLyGv4iSiDP6xsyz/Qtz4Ax+4/8b/0FuvE12fG I9gpCwAXv2oFR7mcl0clhklpOd1mpq5qBC2F+Drliz6QrIRAUgd8FYdz1aPUts0pqc7437 KNbRLE+8bbDwheiJ6pjDXlUleKTzIVNa2jwX868X12meH40yXB3mMFqPUOj7ecGkCVO1IU 5f1i/0kZvQaoMvrxFphoknF9V+Mq2ten5ZofeqrSPckpQh0BUADPOB0HzjUUww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="WNoy/+4t"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671253349; a=rsa-sha256; cv=none; b=bRdDO2epckZamCG4yvw3CavThcv7q9MMbNgjRzJ2uIwWlcBshoC1ZBrcZWSCRQZZdWqoj9 NkLMJX68JXEwPI0OywjQcWlk+PvoHAXcuRJD45KxoKUVGxU1+silfy6Sm7x9PrvA86FvQm JUT81WiA1l1JpPE/GS2OvXvA7b9NQjNk0H/d72Fa5MdKsVqWFhUD9JM3/aFW5llSG3BzpW YgSMDAw9krkn1JvVX1UA1Xvt/J9L88sfn1KHEQBnMAhTCP4GFGBnuqKETvXeb9dYV2RiLw yP5oAao2p5JWylbINOC1fqVDoVmGKAg7hYkysLhoDuJT3IwThv0MSA6c/l2jSQ== X-Migadu-Spam-Score: -0.88 X-Spam-Score: -0.88 X-Migadu-Queue-Id: 0B3A83E1D7 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="WNoy/+4t"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: x7tpoWZNsZ+5 Hi Christopher, Christopher Baines writes: [...] > * doc/contributing.texi (Commit Policy): Tweak. > --- > doc/contributing.texi | 41 ++++++++++++++++++----------------------- > 1 file changed, 18 insertions(+), 23 deletions(-) > > diff --git a/doc/contributing.texi b/doc/contributing.texi > index 6a8ffd6524..d2e7abba98 100644 > --- a/doc/contributing.texi > +++ b/doc/contributing.texi > @@ -1824,23 +1824,26 @@ It additionally calls @code{make check-channel-ne= ws} to be sure >=20=20 > @subsection Commit Policy >=20=20 > -If you get commit access, please make sure to follow > -the policy below (discussions of the policy can take place on > +If you get commit access, please make sure to follow the policy below > +(discussions of the policy can take place on > @email{guix-devel@@gnu.org}). >=20=20 > -Non-trivial patches should always be posted to > -@email{guix-patches@@gnu.org} (trivial patches include fixing typos, > -etc.). This mailing list fills the patch-tracking database > -(@pxref{Tracking Bugs and Patches}). > - > -For patches that just add a new package, and a simple one, it's OK to > -commit, if you're confident (which means you successfully built it in a > -chroot setup, and have done a reasonable copyright and license > -auditing). Likewise for package upgrades, except upgrades that trigger > -a lot of rebuilds (for example, upgrading GnuTLS or GLib). We have a > -mailing list for commit notifications (@email{guix-commits@@gnu.org}), > -so people can notice. Before pushing your changes, make sure to run > -@code{git pull --rebase}. > +Changes should be posted to @email{guix-patches@@gnu.org}. This mailing > +list fills the patch-tracking database (@pxref{Tracking Bugs and > +Patches}). It also allows patches to be picked up and tested by the > +quality assurance tooling; the result of that testing eventually shows > +up on the dashboard at > +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where > +@var{number} is the number assigned by the issue tracker. Leave time > +for a review, without committing anything (@pxref{Submitting Patches}). > +If you didn=E2=80=99t receive any reply after one week (two weeks for mo= re > +significant changes), and if you're confident, it's OK to commit. > + > +As an exception, some changes considered ``trivial'' or ``obvious'' may > +be pushed directly. This includes changes to fix typos and reverting > +commits that caused immediate problems. This is subject to being > +adjusted, allowing individuals to commit directly on non-controversial > +changes on parts they=E2=80=99re familiar with. Like others, I like the direction of the change; the focus is changed from "trivial patches are OK to push else wait 2 weeks" to "most changes must go through the QA tooling", which should improve quality. Like Vagrant, I think it adds some friction, especially if the QA is still sometimes still unreliable and doesn't provide clear results (false positives for example), but I'm not against trying it. I guess we can try this new process, and adjust as we go (or revert to the current policy) in case something doesn't work well enough. --=20 Thanks, Maxim