From: Chris Marusich <cmmarusich@gmail.com>
To: Ivan Petkov <ivanppetkov@gmail.com>
Cc: Chris Marusich <cmmarusich@gmail.com>, 35318-done@debbugs.gnu.org
Subject: bug#35318: [PATCH] Update cargo-build-system to expand package inputs
Date: Tue, 11 Jun 2019 18:14:03 -0700 [thread overview]
Message-ID: <87lfy7zjtw.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <A0537D62-10F8-44C2-A2CC-5A0DB8E0DF7B@gmail.com> (Ivan Petkov's message of "Sun, 9 Jun 2019 16:53:48 -0700")
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
Hi Ivan,
I've merged your changes as 2444abd9c124cc55f8f19a0462e06a2094f25a9d.
Thank you for taking the time to write this patch series! Now let's
start importing some crates! :-)
Some minor feedback for next time (I've made these minor changes on your
behalf already):
- In the ChangeLog, we generally capitalize the heading and add a
period.
- In the manual, we put two spaces after periods, not one.
- The tests/crate.scm began failing when you changed the importer logic;
I have taken the liberty of fixing it.
- When listing many parts that changed, you can write it like this,
instead of listing it on 3 separate lines:
(maybe-cargo-inputs, maybe-cargo-development-inputs)
(maybe-arguments): Add them.
That's all. Thanks again! I'm closing this now.
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2019-06-12 1:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 5:34 [bug#35318] [PATCH] Update cargo-build-system to expand package inputs Ivan Petkov
2019-05-04 16:40 ` Ivan Petkov
2019-05-04 18:31 ` Danny Milosavljevic
2019-05-04 21:09 ` Ivan Petkov
2019-05-06 8:00 ` Ludovic Courtès
2019-05-06 16:04 ` Ivan Petkov
2019-05-09 23:17 ` Ivan Petkov
2019-05-15 6:08 ` Ivan Petkov
2019-05-15 12:44 ` Ludovic Courtès
2019-05-20 1:00 ` Ivan Petkov
2019-05-20 19:38 ` Ludovic Courtès
2019-05-22 2:48 ` Ivan Petkov
2019-06-08 18:44 ` Chris Marusich
2019-06-08 23:33 ` Ivan Petkov
2019-06-09 23:53 ` Ivan Petkov
2019-06-12 1:14 ` Chris Marusich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfy7zjtw.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me \
--to=cmmarusich@gmail.com \
--cc=35318-done@debbugs.gnu.org \
--cc=ivanppetkov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).