From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:50007) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1harqx-0004JV-Jz for guix-patches@gnu.org; Tue, 11 Jun 2019 21:15:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1harqw-0001mz-Pf for guix-patches@gnu.org; Tue, 11 Jun 2019 21:15:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46857) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1harqw-0001mp-KJ for guix-patches@gnu.org; Tue, 11 Jun 2019 21:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1harqw-00072L-A8 for guix-patches@gnu.org; Tue, 11 Jun 2019 21:15:02 -0400 Subject: bug#35318: [PATCH] Update cargo-build-system to expand package inputs Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Chris Marusich References: <87ftpsnhal.fsf@gnu.org> <2C03880B-F90E-4949-9637-DC918B6D40A0@gmail.com> <074E4899-C4FF-4A76-8E97-093378D2F8D5@gmail.com> <87pnojvqdu.fsf@gnu.org> <6A0A0108-A722-4D73-85B7-E61AB8230026@gmail.com> <87ftoj9as8.fsf@gmail.com> Date: Tue, 11 Jun 2019 18:14:03 -0700 In-Reply-To: (Ivan Petkov's message of "Sun, 9 Jun 2019 16:53:48 -0700") Message-ID: <87lfy7zjtw.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ivan Petkov Cc: Chris Marusich , 35318-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Ivan, I've merged your changes as 2444abd9c124cc55f8f19a0462e06a2094f25a9d. Thank you for taking the time to write this patch series! Now let's start importing some crates! :-) Some minor feedback for next time (I've made these minor changes on your behalf already): =2D In the ChangeLog, we generally capitalize the heading and add a period. =2D In the manual, we put two spaces after periods, not one. =2D The tests/crate.scm began failing when you changed the importer logic; I have taken the liberty of fixing it. =2D When listing many parts that changed, you can write it like this, instead of listing it on 3 separate lines: (maybe-cargo-inputs, maybe-cargo-development-inputs) (maybe-arguments): Add them. That's all. Thanks again! I'm closing this now. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAl0AUdsACgkQ3UCaFdgi Rp0NRg/+JQcJWhJ52KOPVNksrQrzOutFo77x3NUAWPr5U5Tmf2QZw4PKreXS3OOB pk/G0jJm82LdycSzzPDAaTY5zhd7Oa2g3Mj+lJQjERxNd1YNl+52Gobs/4rddsrp HzLggtjMqpC5Szh3T6rzhnv5jz+Vpq38Sy/HLCYeFo9PSZY460z4MXXxCj9zNt07 4Qk4ULJNDgHyh/+8BYsObhND0/ROB9jJifjee8EGKuYn9xLGsF7Sk3uhyybEFdAX 7mh981bJKZ7JGU9kHoRuXVtlxpXmScBAdaoHlbXX6i07kWyLiQH4x3ZiBsDe2hl8 aw83gZYlgJX6oDxMIuzZr4NaYCP7uD/LpwRNT8jHjelkfvJnw7AaG7I6Ie7XI2DH GQsas018cwWOBzcNdtKdjnM2lWKJOwh3sz+0CzZR+R+XrVYP6kOK0/lMh38YBdD3 OKfnYGJqDpr54CmRJq5EiSI8+hiDGQgTj2vN6Gj7IYYho7vVd5E5Nte4uQ1yPTKA xjKMaSGYb1hXLyuYTqKpc4eqz2PpKJ/sV6jrb/PFV4rIT7LPkafyXySL7h8bepLZ r9eCfd7RA138K/9nilrDOiaTs5Kh230OjmctWnwCzFT9M+6ocVXf94+KPaC46D7l uTl8fhdj5Pg0BQs18Qmt3vNgJV2v+pWK+siEgLmkKVAwzgTTSg4= =PkkD -----END PGP SIGNATURE----- --=-=-=--