From: Danny Milosavljevic <dannym@scratchpost.org>
To: Ivan Petkov <ivanppetkov@gmail.com>, ludo@gnu.org
Cc: 35318@debbugs.gnu.org, Chris Marusich <cmmarusich@gmail.com>
Subject: [bug#35318] [PATCH] Update cargo-build-system to expand package inputs
Date: Sat, 4 May 2019 20:31:23 +0200 [thread overview]
Message-ID: <20190504203123.2af2049f@scratchpost.org> (raw)
In-Reply-To: <AE1F9948-6987-44C0-8F4F-EC16C7465B2F@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]
Hi Ludo,
Hi Ivan,
@Ludo:
Could you take a look at patch 1? It's allowing the lookup of transitive
dependencies in Guix to be more flexible. Is it OK?
It's used in patch 2 in order to consider both inputs and propagated inputs
rather than just propagated inputs.
@Ivan:
Thanks! I've tested it and it works.
But I don't understand yet why you change the role of "inputs" compared
to how it is in the rest of Guix.
You have this:
+(define-public rust-proc-macro2
+ (package
[...]
+ (build-system cargo-build-system)
+ (native-inputs
+ `(("rust-quote" ,rust-quote "src")))
+ (inputs
+ `(("rust-unicode-xid" ,rust-unicode-xid "src")))
[...]
Here, inputs refer to SOURCE parts of packages which are definitely not
referred to at runtime. Does "guix gc --references ...rust-proc-macro2..."
really refer to the source of rust-unicode-xid ? I checked, it doesn't,
neither for the "src" derivation nor for the "out" derivation.
I think the general approach is good but I'm not certain that this won't
break other parts of Guix. If it doesn't, fine. @Ludo: WDYT?
Details:
A Rust crate has dependencies and dev-dependencies.
The crate needs the dev-dependencies only when building, not at runtime.
Let "transitives of X" mean "X and transitives of immediate dependencies of X and
transitives of immediate dev-dependencies of X", recursively.
The crate needs the source code of all its transitives to be available when
building, but needs none of the source code at runtime.
A crate at run time only requires the immediate, if even that (probably not!),
dependencies and none of the dev-dependencies, and not as source code.
So it's really not a propagated-input, although it kinda seems like a weird
version of a propagated-input while building (something like a
native-propagated-input).
If this can't be generalized (and I'm not sure of that--Go has a similar
static library-y view), we could also do those as (arguments ...) for the
rust build system only--although not sure how to do the resolving of
transitives then.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-04 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 5:34 [bug#35318] [PATCH] Update cargo-build-system to expand package inputs Ivan Petkov
2019-05-04 16:40 ` Ivan Petkov
2019-05-04 18:31 ` Danny Milosavljevic [this message]
2019-05-04 21:09 ` Ivan Petkov
2019-05-06 8:00 ` Ludovic Courtès
2019-05-06 16:04 ` Ivan Petkov
2019-05-09 23:17 ` Ivan Petkov
2019-05-15 6:08 ` Ivan Petkov
2019-05-15 12:44 ` Ludovic Courtès
2019-05-20 1:00 ` Ivan Petkov
2019-05-20 19:38 ` Ludovic Courtès
2019-05-22 2:48 ` Ivan Petkov
2019-06-08 18:44 ` Chris Marusich
2019-06-08 23:33 ` Ivan Petkov
2019-06-09 23:53 ` Ivan Petkov
2019-06-12 1:14 ` bug#35318: " Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504203123.2af2049f@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=35318@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
--cc=ivanppetkov@gmail.com \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).