* [bug#59410] [PATCH] gnu: Add distrobox.
2022-11-20 14:30 [bug#59410] [PATCH] gnu: Add distrobox Adam Faiz via Guix-patches via
@ 2022-12-19 14:48 ` omlet--- via Guix-patches via
2022-12-19 16:30 ` Ricardo Wurmus
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: omlet--- via Guix-patches via @ 2022-12-19 14:48 UTC (permalink / raw)
To: 59410
[-- Attachment #1: Type: text/plain, Size: 141 bytes --]
Its possible approved the package?
--
Enviado de forma segura com Tutanota. Obtenha a sua caixa de correio criptografada, sem publicidade.
[-- Attachment #2: Type: text/html, Size: 319 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#59410] [PATCH] gnu: Add distrobox.
2022-11-20 14:30 [bug#59410] [PATCH] gnu: Add distrobox Adam Faiz via Guix-patches via
2022-12-19 14:48 ` omlet--- via Guix-patches via
@ 2022-12-19 16:30 ` Ricardo Wurmus
2022-12-20 1:25 ` Adam Faiz via Guix-patches via
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2022-12-19 16:30 UTC (permalink / raw)
To: 59410
Hi,
thanks for the patch.
I’m always a bit worried when I see the copy-build-system, because the
lack of a configuration step often means that the tool makes possibly
invalid assumptions about the runtime environment.
I see that you’re patching the locations of “podman”, “wget”, and
“command -v”, but the tools contain even more references, e.g. to
“curl”, “grep”, “sed”, coreutils, “host-spawn”, “sudo”, “pinentry”,
“less”, …
It may be a better idea to wrap all the executables in a reasonable
default environment.
What do you think?
--
Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#59410] [PATCH] gnu: Add distrobox.
2022-11-20 14:30 [bug#59410] [PATCH] gnu: Add distrobox Adam Faiz via Guix-patches via
2022-12-19 14:48 ` omlet--- via Guix-patches via
2022-12-19 16:30 ` Ricardo Wurmus
@ 2022-12-20 1:25 ` Adam Faiz via Guix-patches via
2023-01-15 17:14 ` omlet--- via Guix-patches via
2023-02-03 23:16 ` Nicolas Goaziou
4 siblings, 0 replies; 6+ messages in thread
From: Adam Faiz via Guix-patches via @ 2022-12-20 1:25 UTC (permalink / raw)
To: 59410; +Cc: rekado
> Hi,
>
> thanks for the patch.
>
> I’m always a bit worried when I see the copy-build-system, because the
> lack of a configuration step often means that the tool makes possibly
> invalid assumptions about the runtime environment.
>
> I see that you’re patching the locations of “podman”, “wget”, and
> “command -v”, but the tools contain even more references, e.g. to
> “curl”, “grep”, “sed”, coreutils, “host-spawn”, “sudo”, “pinentry”,
> “less”, …
>
> It may be a better idea to wrap all the executables in a reasonable
> default environment.
>
> What do you think?
It sounds like a good idea.
> --
> Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#59410] [PATCH] gnu: Add distrobox.
2022-11-20 14:30 [bug#59410] [PATCH] gnu: Add distrobox Adam Faiz via Guix-patches via
` (2 preceding siblings ...)
2022-12-20 1:25 ` Adam Faiz via Guix-patches via
@ 2023-01-15 17:14 ` omlet--- via Guix-patches via
2023-02-03 23:16 ` Nicolas Goaziou
4 siblings, 0 replies; 6+ messages in thread
From: omlet--- via Guix-patches via @ 2023-01-15 17:14 UTC (permalink / raw)
To: 59410
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
I don't know how much longer the official packaging for guix will take, but with the distrobox it will be possible to download many free software applications that are taking to be brought to the guix package manager
[-- Attachment #2: Type: text/html, Size: 352 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#59410] [PATCH] gnu: Add distrobox.
2022-11-20 14:30 [bug#59410] [PATCH] gnu: Add distrobox Adam Faiz via Guix-patches via
` (3 preceding siblings ...)
2023-01-15 17:14 ` omlet--- via Guix-patches via
@ 2023-02-03 23:16 ` Nicolas Goaziou
4 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2023-02-03 23:16 UTC (permalink / raw)
To: 59410; +Cc: Adam Faiz, 59410-done
Hello,
Adam Faiz via Guix-patches via <guix-patches@gnu.org> writes:
> Subject: [PATCH] gnu: Add distrobox.
Applied with the changes below. Thank you.
> +(define-public distrobox
> + (package
> + (name "distrobox")
> + (version "1.4.1")
I updated it to latest version.
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/89luca89/distrobox")
> + (commit version)))
> + (sha256
> + (base32 "1qc66ghlq6b0nh4gk8ls64njwv96pkhz0p31k40fnicxwkfnb2jq"))
> + (file-name (git-file-name name version))))
> + (build-system copy-build-system)
> + (inputs
> + (list podman wget))
> + (arguments
> + (list #:phases
> + #~(modify-phases %standard-phases
> + (add-before 'install 'refer-to-inputs
> + (lambda _
> + (substitute* (find-files "." "^distrobox.*")
> + (("podman") (string-append #$(this-package-input
> "podman") "/bin/podman"))
> + (("wget") (string-append #$(this-package-input
> "wget") "/bin/wget"))
I used `search-input-file' instead of `this-package-input'.
> + (license license:gpl3+)))
License seems to be GPL3 only, so I changed it.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread