From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OE4zKD4PoWOkUgAAbAwnHQ (envelope-from ) for ; Tue, 20 Dec 2022 02:26:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MNSMKD4PoWPofwEA9RJhRA (envelope-from ) for ; Tue, 20 Dec 2022 02:26:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F72E28810 for ; Tue, 20 Dec 2022 02:26:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7RON-0006Vo-8t; Mon, 19 Dec 2022 20:26:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7ROM-0006Vf-9K for guix-patches@gnu.org; Mon, 19 Dec 2022 20:26:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7ROM-0000vH-1T for guix-patches@gnu.org; Mon, 19 Dec 2022 20:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7ROL-0001Sf-TT for guix-patches@gnu.org; Mon, 19 Dec 2022 20:26:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59410] [PATCH] gnu: Add distrobox. References: In-Reply-To: Resent-From: Adam Faiz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Dec 2022 01:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59410 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59410@debbugs.gnu.org Cc: rekado@elephly.net Received: via spool by 59410-submit@debbugs.gnu.org id=B59410.16714995285606 (code B ref 59410); Tue, 20 Dec 2022 01:26:01 +0000 Received: (at 59410) by debbugs.gnu.org; 20 Dec 2022 01:25:28 +0000 Received: from localhost ([127.0.0.1]:41515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7RNo-0001SM-J7 for submit@debbugs.gnu.org; Mon, 19 Dec 2022 20:25:28 -0500 Received: from knopi.disroot.org ([178.21.23.139]:48992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7RNl-0001SG-DX for 59410@debbugs.gnu.org; Mon, 19 Dec 2022 20:25:27 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id AF4E640420; Tue, 20 Dec 2022 02:25:23 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EslUQQUpp5oM; Tue, 20 Dec 2022 02:25:22 +0100 (CET) Message-ID: <6784f1f9-f631-711d-0cdc-22f101c50e3c@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1671499522; bh=MVyNa3Elho+2DCi7DTsJzqhBn/7xg/0mSEVRN7YJfjA=; h=Date:Subject:Cc:From:To; b=VD1pgfESngd68OkJ96OladrzNqtDR+ahutPacqsr0XctqdDpGOkX8oG9L3vmtjYE7 CKsNS39KUQF2SDHjP0DfK+7dQqfQOfJkb2hCVFrCyxiQwV4q6Y7qM89L5m+VpbnmbQ HcxtrLdl1/TaAX6ATvzFKtBzQSkxn6f2GA29R57AAnMenVxtmu3rUh8lkdxnX7KWAa Pr1rb94VufOkOHwKV6+KPzgAWZrBOX/3WpkbnrXGrLF8oVwNjpD19oc0n2Agd1Eowy s/cabBo7ulwsX9qYT7TYtccAE05ZeNQbgqUzvzCAhl2gDbWJTflpdQQfi5UhH8WW3x ZDNZ2IfoLD3xw== Date: Tue, 20 Dec 2022 01:25:18 +0000 MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Adam Faiz X-ACL-Warn: , Adam Faiz via Guix-patches From: Adam Faiz via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=VD1pgfES; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671499582; a=rsa-sha256; cv=none; b=tusijBHeUQnEg614Tkb3FxGp8AMuHunyTpb/QHUwhMyyvCQxp2iA/Oy7zPENOz+LQC18GU TmVgZOY0oEDz8Px4iCPVXoR8UEy4WNrGgTFABagVOYsln7prHkNMWC8SZD0YTxeEp9LnsT 9e6glCn9cu/ucOa1l+cge7+DwUZ2w5YGwP1laVg/SUCTIW0Dl315HdQh6eze4KwjZpF4bV hm9AQnaBs0MQIwBMahOhtW/5o6TCoF2V2ouMf5RTFr4DFbLlOwBWKMS3V+2Q/DhB/zHGoi Gn/1+/mZIflKSN11+LcqW1MEpLsyz+rClUL1LioHEMR1u0uAL56APy3lalidHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671499582; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=PvIsKtCYL3lODj+Bg4Od3oLOcrGoxxJhIPqpVZzuHyE=; b=qtioIJcR7SH8vsubOiXNrtW7wJO737GXH5JtlUXW6XlvOtugyGoxeH8T9OC6/7k4pX7mDC wE4pyPD1ImdZKpepPgNnSPvpwZiIJQWmDEoV0JFtZixDk0a5429vrBQqXt1uURNONUbA6P Bvv/6DWp0bb+FKAkCdNT/hVUZqbCtzIc2q+BufCzGnzB07ljtWjDx9VfV9RN7CA3oJG1H0 nnk9mbnOIqkVjlB0yy4yIoKAYqM0DFeFmiyUnK/upCp8VfxyVwl2pmvaoLBu/MjUEeHEXy mkLJZWBw9Y5LL8tnLPsltF2yVYH0xuskIhIlFZl9YAejBCJXGi3by66pY579XA== X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=VD1pgfES; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -4.29 X-Spam-Score: -4.29 X-Migadu-Queue-Id: 4F72E28810 X-TUID: yIThrm2R5KGW > Hi, > > thanks for the patch. > > I’m always a bit worried when I see the copy-build-system, because the > lack of a configuration step often means that the tool makes possibly > invalid assumptions about the runtime environment. > > I see that you’re patching the locations of “podman”, “wget”, and > “command -v”, but the tools contain even more references, e.g. to > “curl”, “grep”, “sed”, coreutils, “host-spawn”, “sudo”, “pinentry”, > “less”, … > > It may be a better idea to wrap all the executables in a reasonable > default environment. > > What do you think? It sounds like a good idea. > -- > Ricardo