From: Adam Faiz via Guix-patches via <guix-patches@gnu.org>
To: 59410@debbugs.gnu.org
Cc: rekado@elephly.net
Subject: [bug#59410] [PATCH] gnu: Add distrobox.
Date: Tue, 20 Dec 2022 01:25:18 +0000 [thread overview]
Message-ID: <6784f1f9-f631-711d-0cdc-22f101c50e3c@disroot.org> (raw)
In-Reply-To: <ddd32c90-3933-a942-3754-98862af0fad0@disroot.org>
> Hi,
>
> thanks for the patch.
>
> I’m always a bit worried when I see the copy-build-system, because the
> lack of a configuration step often means that the tool makes possibly
> invalid assumptions about the runtime environment.
>
> I see that you’re patching the locations of “podman”, “wget”, and
> “command -v”, but the tools contain even more references, e.g. to
> “curl”, “grep”, “sed”, coreutils, “host-spawn”, “sudo”, “pinentry”,
> “less”, …
>
> It may be a better idea to wrap all the executables in a reasonable
> default environment.
>
> What do you think?
It sounds like a good idea.
> --
> Ricardo
next prev parent reply other threads:[~2022-12-20 1:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 14:30 [bug#59410] [PATCH] gnu: Add distrobox Adam Faiz via Guix-patches via
2022-12-19 14:48 ` omlet--- via Guix-patches via
2022-12-19 16:30 ` Ricardo Wurmus
2022-12-20 1:25 ` Adam Faiz via Guix-patches via [this message]
2023-01-15 17:14 ` omlet--- via Guix-patches via
2023-02-03 23:16 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6784f1f9-f631-711d-0cdc-22f101c50e3c@disroot.org \
--to=guix-patches@gnu.org \
--cc=59410@debbugs.gnu.org \
--cc=adam.faiz@disroot.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).