* [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
@ 2020-01-27 23:51 Amin Bandali
2020-01-28 7:53 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Amin Bandali @ 2020-01-27 23:51 UTC (permalink / raw)
To: 39321; +Cc: Amin Bandali
* gnu/packages/emacs-xyz.scm (emacs-unkillable-scratch): New variable.
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c5214405d0..0ff2f5d0c0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21125,3 +21125,26 @@ pattern guessed from thing under current cursor position.
mercury-mode provided by Emacs as a wrapper around prolog-mode.")
(home-page "https://github.com/ahungry/metal-mercury-mode")
(license license:gpl3+))))
+
+(define-public emacs-unkillable-scratch
+ (let ((commit "b24c2a760529833f230c14cb02ff6e7ec92288ab")
+ (revision "0"))
+ (package
+ (name "emacs-unkillable-scratch")
+ (version (git-version "1.0.0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/EricCrosson/unkillable-scratch.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "13wjbcxr3km4s96yhpavgs5acs5pvqv3ih1p84diqb3x3i6wd4pa"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/EricCrosson/unkillable-scratch")
+ (synopsis "Prevents the *scratch* buffer from being killed")
+ (description "@code{unkillable-scratch} helps prevent killing buffers
+matching a given regexp.")
+ (license license:gpl2+))))
--
2.25.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
2020-01-27 23:51 [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch Amin Bandali
@ 2020-01-28 7:53 ` Nicolas Goaziou
2020-01-28 8:26 ` Amin Bandali
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2020-01-28 7:53 UTC (permalink / raw)
To: Amin Bandali; +Cc: 39321
Hello,
Amin Bandali <mab@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-unkillable-scratch): New variable.
Thank you.
> +(define-public emacs-unkillable-scratch
> + (let ((commit "b24c2a760529833f230c14cb02ff6e7ec92288ab")
> + (revision "0"))
> + (package
> + (name "emacs-unkillable-scratch")
> + (version (git-version "1.0.0" revision commit))
Is there any reason to use this particular commit? If so, please add
a comment in the definition. Otherwise, I suggest to stick to stable
releases.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
2020-01-28 7:53 ` Nicolas Goaziou
@ 2020-01-28 8:26 ` Amin Bandali
2020-01-28 9:24 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Amin Bandali @ 2020-01-28 8:26 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 39321
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Hello,
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
[...]
>
> Is there any reason to use this particular commit? If so, please add
> a comment in the definition. Otherwise, I suggest to stick to stable
> releases.
>
The main reason is the introduction of a handy defcustom in [0], and
less importantly other small typo/doc fixes, and lack of a tagged
release in about a year.
[0]: https://github.com/EricCrosson/unkillable-scratch/commit/26102d5434e47c77219fce76c255cafb69b8e222
I think it would be nice if our package included the customization, but
if there’s a strong preference over using a tagged release including in
this case, I’d be happy to send a v2 definition to use a tagged version,
and later inherit from it in my personal channel to make a -git version
including the feature for my own use.
What do you think?
>
> Regards,
Thanks,
amin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
2020-01-28 8:26 ` Amin Bandali
@ 2020-01-28 9:24 ` Nicolas Goaziou
2020-01-28 17:06 ` Amin Bandali
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2020-01-28 9:24 UTC (permalink / raw)
To: Amin Bandali; +Cc: 39321
Amin Bandali <mab@gnu.org> writes:
> The main reason is the introduction of a handy defcustom in [0], and
> less importantly other small typo/doc fixes, and lack of a tagged
> release in about a year.
>
> [0]: https://github.com/EricCrosson/unkillable-scratch/commit/26102d5434e47c77219fce76c255cafb69b8e222
>
> I think it would be nice if our package included the customization, but
> if there’s a strong preference over using a tagged release including in
> this case, I’d be happy to send a v2 definition to use a tagged version,
> and later inherit from it in my personal channel to make a -git version
> including the feature for my own use.
>
> What do you think?
I'm fine with using the latest release, but could you add a comment
explaining the reasoning in the package definition and send it again?
Thank you!
Regards,
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch.
2020-01-28 9:24 ` Nicolas Goaziou
@ 2020-01-28 17:06 ` Amin Bandali
2020-01-28 19:21 ` bug#39321: " Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Amin Bandali @ 2020-01-28 17:06 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 39321
[-- Attachment #1.1: Type: text/plain, Size: 365 bytes --]
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
[...]
>
> I'm fine with using the latest release, but could you add a comment
> explaining the reasoning in the package definition and send it again?
>
If you meant latest “commit” rather than latest “release”, here’s a v2
that adds an explanatory comment about why we use the latest commit:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-emacs-unkillable-scratch.patch --]
[-- Type: text/x-patch, Size: 1928 bytes --]
From 2204aaf2dfb68f4d466404776805ab739e909b44 Mon Sep 17 00:00:00 2001
From: Amin Bandali <mab@gnu.org>
Date: Tue, 28 Jan 2020 12:01:27 -0500
Subject: [PATCH v2] gnu: Add emacs-unkillable-scratch.
* gnu/packages/emacs-xyz.scm (emacs-unkillable-scratch): New variable.
---
gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e5af72121a..d0ae1e3a04 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21212,3 +21212,29 @@ comment.")
(description "@code{delight} enables customizing or hiding the
mode-line text (lighter) of major and minor modes.")
(license license:gpl3+)))
+
+(define-public emacs-unkillable-scratch
+ ;; Use the latest (unreleased) commit as of now, since it contains a handy
+ ;; `unkillable-scratch-do-not-reset-scratch-buffer' customization to not
+ ;; repopulate the scratch buffer with `initial-scratch-message'.
+ (let ((commit "b24c2a760529833f230c14cb02ff6e7ec92288ab")
+ (revision "0"))
+ (package
+ (name "emacs-unkillable-scratch")
+ (version (git-version "1.0.0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/EricCrosson/unkillable-scratch.git")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "13wjbcxr3km4s96yhpavgs5acs5pvqv3ih1p84diqb3x3i6wd4pa"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/EricCrosson/unkillable-scratch")
+ (synopsis "Prevents the *scratch* buffer from being killed")
+ (description "@code{unkillable-scratch} helps prevent killing buffers
+matching a given regexp.")
+ (license license:gpl2+))))
--
2.25.0
[-- Attachment #1.3: Type: text/plain, Size: 45 bytes --]
>
> Thank you!
>
> Regards,
>
Cheers,
amin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#39321: [PATCH] gnu: Add emacs-unkillable-scratch.
2020-01-28 17:06 ` Amin Bandali
@ 2020-01-28 19:21 ` Nicolas Goaziou
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2020-01-28 19:21 UTC (permalink / raw)
To: Amin Bandali; +Cc: 39321-done
Amin Bandali <mab@gnu.org> writes:
> If you meant latest “commit” rather than latest “release”,
Indeed.
> here’s a v2 that adds an explanatory comment about why we use the
> latest commit
Applied as e7c938b2bf591819a64ea0ecb51a863d71339da2. Thank you!
Regards,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-28 19:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 23:51 [bug#39321] [PATCH] gnu: Add emacs-unkillable-scratch Amin Bandali
2020-01-28 7:53 ` Nicolas Goaziou
2020-01-28 8:26 ` Amin Bandali
2020-01-28 9:24 ` Nicolas Goaziou
2020-01-28 17:06 ` Amin Bandali
2020-01-28 19:21 ` bug#39321: " Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).