[bug#42767] [PATCH] gnu: Add rttr.

[bug#42767] [PATCH] gnu: Add rttr.

[Michael Rohleder]

* gnu/packages/cpp.scm (rttr): New variable.
---
A newer version of kdenlive needs this.

 gnu/packages/cpp.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 5e83bb69f6..9ff4dc864b 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2020 Brice Waegeneire <brice@waegenei.re>
 ;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
 ;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
+;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -82,7 +83,35 @@ strings, configuration, bit streams, threading, translation, and cross-platform
 operating system functions.")
     (license license:zlib)))
 
+(define-public rttr
+  (package
+    (name "rttr")
+    (version "0.9.6")
+    (home-page "https://github.com/rttrorg/rttr/")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url home-page)
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "1yxad8sj40wi75hny8w6imrsx8wjasjmsipnlq559n4b6kl84ijp"))
+       (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (arguments
+     '(#:tests? #f                      ; TODO
+       #:configure-flags
+         '("-DBUILD_UNIT_TESTS=OFF"
+           "-DBUILD_DOCUMENTATION=OFF")))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (synopsis "C++ Reflection Library")
+    (description
+     "RTTR stands for Run Time Type Reflection. It describes the ability of a
+computer program to introspect and modify an object at runtime. It is also the
+name of the library itself, which is written in C++ and released as open
+source library.")
+    (license license:expat)))
+
 (define-public rct
   (let* ((commit "b3e6f41d9844ef64420e628e0c65ed98278a843a")
          (revision "2"))
-- 
2.28.0

[bug#42767] [PATCH] gnu: Add rttr.

[Mathieu Othacehe]

Hello Michael,

Thanks for this patch. Did you change something to the way you are
sending patches? I have troubles to apply them, with errors such as:

--8<---------------cut here---------------start------------->8---
Applying: gnu: Add rttr.
Using index info to reconstruct a base tree...
M	gnu/packages/cpp.scm
error: patch failed: gnu/packages/cpp.scm:82
error: gnu/packages/cpp.scm: patch does not apply
error: Did you hand edit your patch?
--8<---------------cut here---------------end--------------->8---

> +    (home-page "https://github.com/rttrorg/rttr/")

This field is traditionally at the end of the package definition, right
before synopsis.

> +    (source
> +     '(#:tests? #f                      ; TODO

You could elaborate on why they are not enabled. Something to fix in particular?

> +       #:configure-flags
> +         '("-DBUILD_UNIT_TESTS=OFF"
> +           "-DBUILD_DOCUMENTATION=OFF")))
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (synopsis "C++ Reflection Library")
> +    (description
> +     "RTTR stands for Run Time Type Reflection. It describes the ability of a
> +computer program to introspect and modify an object at runtime. It is also the
> +name of the library itself, which is written in C++ and released as open
> +source library.")

There are a couple of linting warnings on this description. No need to
mention that it's open source :).

Thanks,

Mathieu

[bug#42767] [PATCH] gnu: Add rttr.

[Michael Rohleder]

[-- Attachment #1.1: Type: text/plain, Size: 291 bytes --]

Hello Mathieu,

Thank you very much for reviewing (my mess, as I was too focused on making
kdenlive run...).

Here is a (hopefully) better version.

It includes running 528 unit_tests, except the ones for library_test.cpp
where I couldn't figure out why they fail, so I substitute it away.


[-- Attachment #1.2: [PATCH] gnu: Add rttr. --]
[-- Type: text/x-patch, Size: 2498 bytes --]

From 46a38e83b831cf0c5a0e31b2d905ac9d4d77a5a8 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Mon, 10 Aug 2020 20:17:07 +0200
Subject: [PATCH] gnu: Add rttr.

* gnu/packages/cpp.scm (rttr): New variable.
---
 gnu/packages/cpp.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index bf89ff12ea..8c0afe4955 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2020 Brice Waegeneire <brice@waegenei.re>
 ;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
 ;;; Copyright © 2020 Marius Bakke <marius@gnu.org>
+;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -82,6 +83,42 @@ strings, configuration, bit streams, threading, translation, and cross-platform
 operating system functions.")
     (license license:zlib)))
 
+(define-public rttr
+  (package
+    (name "rttr")
+    (version "0.9.6")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/rttrorg/rttr/")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "1yxad8sj40wi75hny8w6imrsx8wjasjmsipnlq559n4b6kl84ijp"))
+       (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (arguments
+     '(#:tests? #f ; no check target. Setting test-target to "unit_test" runs
+                   ; it twice.
+       #:configure-flags
+       '("-DBUILD_DOCUMENTATION=OFF" "-DBUILD_EXAMPLES=OFF")
+       #:phases
+       (modify-phases %standard-phases
+         ;; library_test fails in chroot.
+         (add-after 'unpack 'skip-library-test
+           (lambda _
+             (substitute* "src/unit_tests/unit_tests.cmake"
+               (("misc/library_test.cpp") ""))
+             #t)))))
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (home-page "https://github.com/rttrorg/rttr/")
+    (synopsis "C++ Reflection Library")
+    (description
+     "RTTR stands for Run Time Type Reflection.  It describes the ability of a
+computer program to introspect and modify an object at runtime.  It is also
+the name of the library itself, which is written in C++.")
+    (license license:expat)))
+
 (define-public rct
   (let* ((commit "b3e6f41d9844ef64420e628e0c65ed98278a843a")
          (revision "2"))
-- 
2.28.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#42767: [PATCH] gnu: Add rttr.

[Mathieu Othacehe]

Hey,

> It includes running 528 unit_tests, except the ones for library_test.cpp
> where I couldn't figure out why they fail, so I substitute it away.

This looks fine, pushed!

Thanks,

Mathieu