From: Mathieu Othacehe <othacehe@gnu.org>
To: Michael Rohleder <mike@rohleder.de>
Cc: 42767@debbugs.gnu.org
Subject: [bug#42767] [PATCH] gnu: Add rttr.
Date: Mon, 10 Aug 2020 11:34:33 +0200 [thread overview]
Message-ID: <87eeoehmja.fsf@gnu.org> (raw)
In-Reply-To: <20200808175320.12200-1-mike@rohleder.de> (Michael Rohleder's message of "Sat, 8 Aug 2020 19:53:20 +0200")
Hello Michael,
Thanks for this patch. Did you change something to the way you are
sending patches? I have troubles to apply them, with errors such as:
--8<---------------cut here---------------start------------->8---
Applying: gnu: Add rttr.
Using index info to reconstruct a base tree...
M gnu/packages/cpp.scm
error: patch failed: gnu/packages/cpp.scm:82
error: gnu/packages/cpp.scm: patch does not apply
error: Did you hand edit your patch?
--8<---------------cut here---------------end--------------->8---
> + (home-page "https://github.com/rttrorg/rttr/")
This field is traditionally at the end of the package definition, right
before synopsis.
> + (source
> + '(#:tests? #f ; TODO
You could elaborate on why they are not enabled. Something to fix in particular?
> + #:configure-flags
> + '("-DBUILD_UNIT_TESTS=OFF"
> + "-DBUILD_DOCUMENTATION=OFF")))
> + (native-inputs `(("pkg-config" ,pkg-config)))
> + (synopsis "C++ Reflection Library")
> + (description
> + "RTTR stands for Run Time Type Reflection. It describes the ability of a
> +computer program to introspect and modify an object at runtime. It is also the
> +name of the library itself, which is written in C++ and released as open
> +source library.")
There are a couple of linting warnings on this description. No need to
mention that it's open source :).
Thanks,
Mathieu
next prev parent reply other threads:[~2020-08-10 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 17:53 [bug#42767] [PATCH] gnu: Add rttr Michael Rohleder
2020-08-10 9:34 ` Mathieu Othacehe [this message]
2020-08-10 18:19 ` Michael Rohleder
2020-08-11 9:01 ` bug#42767: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeoehmja.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=42767@debbugs.gnu.org \
--cc=mike@rohleder.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).