* [bug#35890] [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2.
@ 2019-05-25 0:14 Brett Gilio
2019-05-25 0:27 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Brett Gilio
0 siblings, 1 reply; 6+ messages in thread
From: Brett Gilio @ 2019-05-25 0:14 UTC (permalink / raw)
To: 35890
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2. --]
[-- Type: text/x-patch, Size: 1124 bytes --]
From fb102715cd2b809e4d963b8f71df54bbad06c369 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg@posteo.net>
Date: Fri, 24 May 2019 19:10:33 -0500
Subject: [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2.
* gnu/packages/python-xyz.scm (python-hdf4): Update to 0.9.2.
---
gnu/packages/python-xyz.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index a58b788ca1..54cc0c2b27 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -370,14 +370,14 @@ and verifies that it matches the intended target hostname.")
(define-public python-hdf4
(package
(name "python-hdf4")
- (version "0.9")
+ (version "0.9.2")
(source
(origin
(method url-fetch)
(uri (pypi-uri name version))
(sha256
(base32
- "1hjiyrxvxk9817qyqky3nar4y3fs4z8wxz0n884zzb5wi6skrjks"))))
+ "00sxppysk3w620g1jdskjzkybvpf8dkpzjfj3wlw5khpzw1g0hq5"))))
(build-system python-build-system)
(native-inputs `(("nose" ,python-nose)))
(propagated-inputs `(("numpy" ,python-numpy)))
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
2019-05-25 0:14 [bug#35890] [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2 Brett Gilio
@ 2019-05-25 0:27 ` Brett Gilio
2019-05-26 8:28 ` Marius Bakke
2019-05-26 10:53 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Ricardo Wurmus
0 siblings, 2 replies; 6+ messages in thread
From: Brett Gilio @ 2019-05-25 0:27 UTC (permalink / raw)
To: 35890
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument. --]
[-- Type: text/x-patch, Size: 1474 bytes --]
From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg@posteo.net>
Date: Fri, 24 May 2019 19:11:00 -0500
Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
* gnu/packages/python-xyz.scm (python-hdf4): Update to .
---
gnu/packages/python-xyz.scm | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 54cc0c2b27..43287d212e 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
`(("hdf4" ,hdf4)
("libjpeg" ,libjpeg)
("zlib" ,zlib)))
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (replace 'check
- (lambda _
- ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
- ;; on to import numpy. Somehow this works on their CI system.
- ;; Let's just manage PYTHONPATH here instead.
- (substitute* "runexamples.sh"
- (("export PYTHONPATH=.*") ""))
- (setenv "PYTHONPATH"
- (string-append (getcwd) ":"
- (getenv "PYTHONPATH")))
- (invoke "./runexamples.sh")
- (invoke "nosetests" "-v"))))))
(home-page "https://github.com/fhs/python-hdf4")
(synopsis "Python interface to the NCSA HDF4 library")
(description
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
2019-05-25 0:27 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Brett Gilio
@ 2019-05-26 8:28 ` Marius Bakke
2019-07-02 15:22 ` Ludovic Courtès
2019-05-26 10:53 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Ricardo Wurmus
1 sibling, 1 reply; 6+ messages in thread
From: Marius Bakke @ 2019-05-26 8:28 UTC (permalink / raw)
To: Brett Gilio, 35890
[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]
Brett Gilio <brettg@posteo.net> writes:
> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg@posteo.net>
> Date: Fri, 24 May 2019 19:11:00 -0500
> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>
> * gnu/packages/python-xyz.scm (python-hdf4): Update to .
> ---
> gnu/packages/python-xyz.scm | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 54cc0c2b27..43287d212e 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
> `(("hdf4" ,hdf4)
> ("libjpeg" ,libjpeg)
> ("zlib" ,zlib)))
> - (arguments
> - `(#:phases
> - (modify-phases %standard-phases
> - (replace 'check
> - (lambda _
> - ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
> - ;; on to import numpy. Somehow this works on their CI system.
> - ;; Let's just manage PYTHONPATH here instead.
> - (substitute* "runexamples.sh"
> - (("export PYTHONPATH=.*") ""))
> - (setenv "PYTHONPATH"
> - (string-append (getcwd) ":"
> - (getenv "PYTHONPATH")))
> - (invoke "./runexamples.sh")
> - (invoke "nosetests" "-v"))))))
> (home-page "https://github.com/fhs/python-hdf4")
> (synopsis "Python interface to the NCSA HDF4 library")
> (description
While this makes the build succeed, the 'check' phase is now moot. It
appears to simply build the library for a second time, and then prints
'Ran 0 tests in N seconds...'.
Can you look into what happened to the tests between version 0.9.0 and
0.9.2?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
2019-05-25 0:27 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Brett Gilio
2019-05-26 8:28 ` Marius Bakke
@ 2019-05-26 10:53 ` Ricardo Wurmus
1 sibling, 0 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2019-05-26 10:53 UTC (permalink / raw)
To: Brett Gilio; +Cc: 35890
Brett Gilio <brettg@posteo.net> writes:
> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg@posteo.net>
> Date: Fri, 24 May 2019 19:11:00 -0500
> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>
> * gnu/packages/python-xyz.scm (python-hdf4): Update to .
I guess you’re using the yasnippets for Emacs :)
It’s fine to do this in the same commit as the upgrade, but as Marius
wrote the tests should actually be run.
--
Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
2019-05-26 8:28 ` Marius Bakke
@ 2019-07-02 15:22 ` Ludovic Courtès
2022-07-16 3:57 ` [bug#35890] [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2 Maxim Cournoyer
0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2019-07-02 15:22 UTC (permalink / raw)
To: Brett Gilio; +Cc: 35890
Hello Brett,
Marius Bakke <mbakke@fastmail.com> skribis:
> Brett Gilio <brettg@posteo.net> writes:
>
>> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <brettg@posteo.net>
>> Date: Fri, 24 May 2019 19:11:00 -0500
>> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>>
>> * gnu/packages/python-xyz.scm (python-hdf4): Update to .
>> ---
>> gnu/packages/python-xyz.scm | 15 ---------------
>> 1 file changed, 15 deletions(-)
>>
>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>> index 54cc0c2b27..43287d212e 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
>> `(("hdf4" ,hdf4)
>> ("libjpeg" ,libjpeg)
>> ("zlib" ,zlib)))
>> - (arguments
>> - `(#:phases
>> - (modify-phases %standard-phases
>> - (replace 'check
>> - (lambda _
>> - ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
>> - ;; on to import numpy. Somehow this works on their CI system.
>> - ;; Let's just manage PYTHONPATH here instead.
>> - (substitute* "runexamples.sh"
>> - (("export PYTHONPATH=.*") ""))
>> - (setenv "PYTHONPATH"
>> - (string-append (getcwd) ":"
>> - (getenv "PYTHONPATH")))
>> - (invoke "./runexamples.sh")
>> - (invoke "nosetests" "-v"))))))
>> (home-page "https://github.com/fhs/python-hdf4")
>> (synopsis "Python interface to the NCSA HDF4 library")
>> (description
>
> While this makes the build succeed, the 'check' phase is now moot. It
> appears to simply build the library for a second time, and then prints
> 'Ran 0 tests in N seconds...'.
>
> Can you look into what happened to the tests between version 0.9.0 and
> 0.9.2?
Any update on this?
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#35890] [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2.
2019-07-02 15:22 ` Ludovic Courtès
@ 2022-07-16 3:57 ` Maxim Cournoyer
0 siblings, 0 replies; 6+ messages in thread
From: Maxim Cournoyer @ 2022-07-16 3:57 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 35890-done, Marius Bakke, Brett Gilio
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> Hello Brett,
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> Brett Gilio <brettg@posteo.net> writes:
>>
>>> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
>>> From: Brett Gilio <brettg@posteo.net>
>>> Date: Fri, 24 May 2019 19:11:00 -0500
>>> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>>>
>>> * gnu/packages/python-xyz.scm (python-hdf4): Update to .
>>> ---
>>> gnu/packages/python-xyz.scm | 15 ---------------
>>> 1 file changed, 15 deletions(-)
>>>
>>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>>> index 54cc0c2b27..43287d212e 100644
>>> --- a/gnu/packages/python-xyz.scm
>>> +++ b/gnu/packages/python-xyz.scm
>>> @@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
>>> `(("hdf4" ,hdf4)
>>> ("libjpeg" ,libjpeg)
>>> ("zlib" ,zlib)))
>>> - (arguments
>>> - `(#:phases
>>> - (modify-phases %standard-phases
>>> - (replace 'check
>>> - (lambda _
>>> - ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
>>> - ;; on to import numpy. Somehow this works on their CI system.
>>> - ;; Let's just manage PYTHONPATH here instead.
>>> - (substitute* "runexamples.sh"
>>> - (("export PYTHONPATH=.*") ""))
>>> - (setenv "PYTHONPATH"
>>> - (string-append (getcwd) ":"
>>> - (getenv "PYTHONPATH")))
>>> - (invoke "./runexamples.sh")
>>> - (invoke "nosetests" "-v"))))))
>>> (home-page "https://github.com/fhs/python-hdf4")
>>> (synopsis "Python interface to the NCSA HDF4 library")
>>> (description
>>
>> While this makes the build succeed, the 'check' phase is now moot. It
>> appears to simply build the library for a second time, and then prints
>> 'Ran 0 tests in N seconds...'.
>>
>> Can you look into what happened to the tests between version 0.9.0 and
>> 0.9.2?
>
> Any update on this?
No update in 3 years; closing.
Maxim
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-16 3:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-25 0:14 [bug#35890] [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2 Brett Gilio
2019-05-25 0:27 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Brett Gilio
2019-05-26 8:28 ` Marius Bakke
2019-07-02 15:22 ` Ludovic Courtès
2022-07-16 3:57 ` [bug#35890] [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2 Maxim Cournoyer
2019-05-26 10:53 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Ricardo Wurmus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).