From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUoWn-0005Dh-8q for guix-patches@gnu.org; Sun, 26 May 2019 04:29:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUoWc-0002rx-JY for guix-patches@gnu.org; Sun, 26 May 2019 04:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hUoWc-0002rl-En for guix-patches@gnu.org; Sun, 26 May 2019 04:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hUoWc-00031i-8d for guix-patches@gnu.org; Sun, 26 May 2019 04:29:02 -0400 Subject: [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87zhnbpee0.fsf@posteo.net> References: <8736l3qtjx.fsf@posteo.net> <87zhnbpee0.fsf@posteo.net> Date: Sun, 26 May 2019 10:28:04 +0200 Message-ID: <871s0ld3hn.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Brett Gilio , 35890@debbugs.gnu.org --=-=-= Content-Type: text/plain Brett Gilio writes: > From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001 > From: Brett Gilio > Date: Fri, 24 May 2019 19:11:00 -0500 > Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument. > > * gnu/packages/python-xyz.scm (python-hdf4): Update to . > --- > gnu/packages/python-xyz.scm | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index 54cc0c2b27..43287d212e 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.") > `(("hdf4" ,hdf4) > ("libjpeg" ,libjpeg) > ("zlib" ,zlib))) > - (arguments > - `(#:phases > - (modify-phases %standard-phases > - (replace 'check > - (lambda _ > - ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes > - ;; on to import numpy. Somehow this works on their CI system. > - ;; Let's just manage PYTHONPATH here instead. > - (substitute* "runexamples.sh" > - (("export PYTHONPATH=.*") "")) > - (setenv "PYTHONPATH" > - (string-append (getcwd) ":" > - (getenv "PYTHONPATH"))) > - (invoke "./runexamples.sh") > - (invoke "nosetests" "-v")))))) > (home-page "https://github.com/fhs/python-hdf4") > (synopsis "Python interface to the NCSA HDF4 library") > (description While this makes the build succeed, the 'check' phase is now moot. It appears to simply build the library for a second time, and then prints 'Ran 0 tests in N seconds...'. Can you look into what happened to the tests between version 0.9.0 and 0.9.2? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlzqThQACgkQoqBt8qM6 VPopVwgAr86067P1Mo3Qt8gXNjw+Ec53xLdnAdAaGBX7YWPdGqF9fJ4929Rt5T6U NBdj9rU0OOY1Ezmj+1H1vM703xcUcEdeERuHYuvmIhhhMDVy8JH7uMBunW7/G66z MOsY2N+WLzl5O/0vtVh8K5rO4gKrnUbGexCmIGxXydzjFFjU08QXXLvdMoRQG59A /dP+OQtcm8vapK1TI6mAU4e8ZMRssuIqJJrbCvBRusecsn06zzjEpImOli5m19f8 fQUVNEzJcBDnwBaYBKT+BKxMi2jmv0DDS+busX5haW7WYQ608MpWt61tftijMy/C MVBmBH3HvvKGCTytj/e7n5plw/pm6A== =UhM9 -----END PGP SIGNATURE----- --=-=-=--