From: "Ludovic Courtès" <ludo@gnu.org>
To: Brett Gilio <brettg@posteo.net>
Cc: 35890@debbugs.gnu.org
Subject: [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
Date: Tue, 02 Jul 2019 17:22:18 +0200 [thread overview]
Message-ID: <87a7dw7979.fsf@gnu.org> (raw)
In-Reply-To: <871s0ld3hn.fsf@devup.no> (Marius Bakke's message of "Sun, 26 May 2019 10:28:04 +0200")
Hello Brett,
Marius Bakke <mbakke@fastmail.com> skribis:
> Brett Gilio <brettg@posteo.net> writes:
>
>> From 74c956284d5ff7b20e12ed4315404697320dc809 Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <brettg@posteo.net>
>> Date: Fri, 24 May 2019 19:11:00 -0500
>> Subject: [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument.
>>
>> * gnu/packages/python-xyz.scm (python-hdf4): Update to .
>> ---
>> gnu/packages/python-xyz.scm | 15 ---------------
>> 1 file changed, 15 deletions(-)
>>
>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>> index 54cc0c2b27..43287d212e 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -385,21 +385,6 @@ and verifies that it matches the intended target hostname.")
>> `(("hdf4" ,hdf4)
>> ("libjpeg" ,libjpeg)
>> ("zlib" ,zlib)))
>> - (arguments
>> - `(#:phases
>> - (modify-phases %standard-phases
>> - (replace 'check
>> - (lambda _
>> - ;; The 'runexamples' script sets PYTHONPATH to CWD, then goes
>> - ;; on to import numpy. Somehow this works on their CI system.
>> - ;; Let's just manage PYTHONPATH here instead.
>> - (substitute* "runexamples.sh"
>> - (("export PYTHONPATH=.*") ""))
>> - (setenv "PYTHONPATH"
>> - (string-append (getcwd) ":"
>> - (getenv "PYTHONPATH")))
>> - (invoke "./runexamples.sh")
>> - (invoke "nosetests" "-v"))))))
>> (home-page "https://github.com/fhs/python-hdf4")
>> (synopsis "Python interface to the NCSA HDF4 library")
>> (description
>
> While this makes the build succeed, the 'check' phase is now moot. It
> appears to simply build the library for a second time, and then prints
> 'Ran 0 tests in N seconds...'.
>
> Can you look into what happened to the tests between version 0.9.0 and
> 0.9.2?
Any update on this?
Ludo’.
next prev parent reply other threads:[~2019-07-02 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 0:14 [bug#35890] [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2 Brett Gilio
2019-05-25 0:27 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Brett Gilio
2019-05-26 8:28 ` Marius Bakke
2019-07-02 15:22 ` Ludovic Courtès [this message]
2022-07-16 3:57 ` [bug#35890] [PATCH 3/4] gnu: python-hdf4: Update to 0.9.2 Maxim Cournoyer
2019-05-26 10:53 ` [bug#35890] [PATCH 4/4] gnu: python-hdf4: Remove check-phase argument Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7dw7979.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35890@debbugs.gnu.org \
--cc=brettg@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).