* [bug#61031] [PATCH] Add emacs-kodi-remote.
@ 2023-01-23 22:39 Matthieu Lemerre
2023-01-25 17:40 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: Matthieu Lemerre @ 2023-01-23 22:39 UTC (permalink / raw)
To: 61031
Hi Guix!
This emacs package allows to control Kodi remotely -- I use it every day and it is very handy!
The guix installation works well.
Best regards,
Matthieu
---
gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c2be7eac57..e2efaaf47d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26708,6 +26708,34 @@ (define-public emacs-mpdel
stored playlists.")
(license license:gpl3+)))
+
+(define-public emacs-kodi-remote
+ (package
+ (name "emacs-kodi-remote")
+ (version "20190622.1325")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/spiderbit/kodi-remote.el.git")
+ (commit "f5e932036c16e2b61a63020e006fc601e38d181e")))
+ (sha256
+ (base32
+ "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
+ (build-system emacs-build-system)
+ (propagated-inputs (list emacs-request emacs-let-alist emacs-json-mode emacs-f))
+ (home-page "http://github.com/spiderbit/kodi-remote.el")
+ (synopsis "Remote Control for Kodi")
+ (description
+ "This package provides a major to remote control kodi instances. First specify
+the hostname/ip of your kodi webserver: (setq kodi-host-name \"my-htpc:8080\")
+Then open the Remote with the command: kodi-remote Also open the current kodi
+Video Playlist with the command: kodi-remote-playlist Start play exercise mode:
+kodi-remote-exercise OPTIONAL: setup settings for deleting files (over tramp)
+(setq kodi-dangerous-options t) (setq kodi-access-host \"my-htpc\") if you don't
+use ssh to access your kodi server / nas: (setq kodi-access-method
+\"smb/ftp/adb...\")")
+ (license gpl3+)))
+
(define-public emacs-navigel
(package
(name "emacs-navigel")
base-commit: 77a34996000acf43b668ebf491afb6d02e85b0ec
--
2.38.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#61031] [PATCH] Add emacs-kodi-remote.
2023-01-23 22:39 [bug#61031] [PATCH] Add emacs-kodi-remote Matthieu Lemerre
@ 2023-01-25 17:40 ` Nicolas Goaziou
2023-01-27 12:43 ` racin
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2023-01-25 17:40 UTC (permalink / raw)
To: Matthieu Lemerre; +Cc: 61031
Hello,
Matthieu Lemerre <racin@free.fr> writes:
> This emacs package allows to control Kodi remotely -- I use it every day and it is very handy!
> The guix installation works well.
Thank you. Some comments follow.
> +(define-public emacs-kodi-remote
> + (package
> + (name "emacs-kodi-remote")
> + (version "20190622.1325")
According to "kodi-remote.el", version is "0", not this date-based one.
You should also use `git-version' since we're using an unreleased version.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/spiderbit/kodi-remote.el.git")
You should drop the ".git" suffix from URL.
> + (commit "f5e932036c16e2b61a63020e006fc601e38d181e")))
Usually, we let-bind the commit at the beginning of the package
definition and write
(commit commit)
> + (sha256
> + (base32
> + "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
> + (build-system emacs-build-system)
> + (propagated-inputs (list emacs-request emacs-let-alist emacs-json-mode emacs-f))
Please order inputs alphabetically.
> + (home-page "http://github.com/spiderbit/kodi-remote.el")
> + (synopsis "Remote Control for Kodi")
> + (description
> + "This package provides a major to remote control kodi instances. First specify
kodi -> Kodi
> +the hostname/ip of your kodi webserver: (setq kodi-host-name \"my-htpc:8080\")
> +Then open the Remote with the command: kodi-remote Also open the current kodi
> +Video Playlist with the command: kodi-remote-playlist Start play exercise mode:
> +kodi-remote-exercise OPTIONAL: setup settings for deleting files (over tramp)
> +(setq kodi-dangerous-options t) (setq kodi-access-host \"my-htpc\") if you don't
> +use ssh to access your kodi server / nas: (setq kodi-access-method
> +\"smb/ftp/adb...\")")
This is more a manual excerpt than a proper description. Could you
reword it a bit to describe what the package does, not how to do it?
Note that sentences should be separated with full stops and two spaces,
per Texinfo specification.
> + (license gpl3+)))
This cannot possibly build: the license above should be license:gpl3+.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#61031] [PATCH] Add emacs-kodi-remote.
2023-01-25 17:40 ` Nicolas Goaziou
@ 2023-01-27 12:43 ` racin
2023-01-27 22:04 ` bug#61031: " Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: racin @ 2023-01-27 12:43 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 61031
Thanks for all the comments! Here is an updated patch addressing everything.
You were right about the problem that it did not compile; I did not understand that I had to to make
before ./pre-inst-env guix build emacs-kodi-remote. I think I properly tested it now.
Matthieu
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c2be7eac57..0c832110a0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26708,6 +26708,30 @@ (define-public emacs-mpdel
stored playlists.")
(license license:gpl3+)))
+
+(define-public emacs-kodi-remote
+ (let ((commit "f5e932036c16e2b61a63020e006fc601e38d181e")
+ (revision "0"))
+ (package
+ (name "emacs-kodi-remote")
+ (version (git-version "0" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/spiderbit/kodi-remote.el.git")
+ (commit commit)))
+ (sha256
+ (base32
+ "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
+ (build-system emacs-build-system)
+ (propagated-inputs (list emacs-f emacs-json-mode emacs-let-alist emacs-request))
+ (home-page "http://github.com/spiderbit/kodi-remote.el")
+ (synopsis "Remote Control for Kodi")
+ (description
+ "This package provides a major mode to remote control Kodi
+instances (play/pause, volume control, media selection, etc.).")
+ (license license:gpl3+))))
+
(define-public emacs-navigel
(package
(name "emacs-navigel")
--
2.39.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#61031: [PATCH] Add emacs-kodi-remote.
2023-01-27 12:43 ` racin
@ 2023-01-27 22:04 ` Nicolas Goaziou
2023-01-27 22:10 ` [bug#61031] " racin
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Goaziou @ 2023-01-27 22:04 UTC (permalink / raw)
To: racin; +Cc: 61031-done
Hello,
racin@free.fr writes:
> You were right about the problem that it did not compile; I did not understand that I had to to make
> before ./pre-inst-env guix build emacs-kodi-remote. I think I properly
> tested it now.
Great. I added a commit message and applied your patch, with the changes below.
> + (package
> + (name "emacs-kodi-remote")
> + (version (git-version "0" revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/spiderbit/kodi-remote.el.git")
I removed ".git" suffix
> + (commit commit)))
I added
(file-name (git-file-name name version))
here
> + (sha256
> + (base32
> + "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
> + (build-system emacs-build-system)
> + (propagated-inputs (list emacs-f emacs-json-mode emacs-let-alist emacs-request))
I added a newline character after "propagated-inputs".
> + (home-page "http://github.com/spiderbit/kodi-remote.el")
> + (synopsis "Remote Control for Kodi")
Control -> control
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#61031] [PATCH] Add emacs-kodi-remote.
2023-01-27 22:04 ` bug#61031: " Nicolas Goaziou
@ 2023-01-27 22:10 ` racin
2023-01-27 22:16 ` Nicolas Goaziou
0 siblings, 1 reply; 6+ messages in thread
From: racin @ 2023-01-27 22:10 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 61031-done
> Great. I added a commit message and applied your patch, with the changes below.
Great! I'll try to be more careful next time!
> I removed ".git" suffix
You had mentionned it, sorry.
> I added (file-name (git-file-name name version))
This I didn't know.
> Control -> control
Oups.
Regards,
Matthieu
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-27 22:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 22:39 [bug#61031] [PATCH] Add emacs-kodi-remote Matthieu Lemerre
2023-01-25 17:40 ` Nicolas Goaziou
2023-01-27 12:43 ` racin
2023-01-27 22:04 ` bug#61031: " Nicolas Goaziou
2023-01-27 22:10 ` [bug#61031] " racin
2023-01-27 22:16 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).