unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: racin@free.fr
Cc: 61031-done@debbugs.gnu.org
Subject: bug#61031: [PATCH] Add emacs-kodi-remote.
Date: Fri, 27 Jan 2023 23:04:53 +0100	[thread overview]
Message-ID: <87zga3k516.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <1619463260.211138834.1674823418016.JavaMail.zimbra@free.fr> (racin@free.fr's message of "Fri, 27 Jan 2023 13:43:38 +0100 (CET)")

Hello,

racin@free.fr writes:

> You were right about the problem that it did not compile; I did not understand that I had to to make
> before ./pre-inst-env guix build emacs-kodi-remote. I think I properly
> tested it now.

Great. I added a commit message and applied your patch, with the changes below.

> +    (package
> +      (name "emacs-kodi-remote")
> +      (version (git-version "0" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/spiderbit/kodi-remote.el.git")

I removed ".git" suffix
> +                      (commit commit)))

I added

  (file-name (git-file-name name version))

here

> +                (sha256
> +                 (base32
> +                  "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs (list emacs-f emacs-json-mode emacs-let-alist emacs-request))

I added a newline character after "propagated-inputs".
> +      (home-page "http://github.com/spiderbit/kodi-remote.el")
> +      (synopsis "Remote Control for Kodi")

Control -> control

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2023-01-27 22:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 22:39 [bug#61031] [PATCH] Add emacs-kodi-remote Matthieu Lemerre
2023-01-25 17:40 ` Nicolas Goaziou
2023-01-27 12:43   ` racin
2023-01-27 22:04     ` Nicolas Goaziou [this message]
2023-01-27 22:10       ` racin
2023-01-27 22:16         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zga3k516.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=61031-done@debbugs.gnu.org \
    --cc=racin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).