From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qBa7F8Bp0WMHEAEAbAwnHQ (envelope-from ) for ; Wed, 25 Jan 2023 18:41:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eGnzFsBp0WMImgAAG6o9tA (envelope-from ) for ; Wed, 25 Jan 2023 18:41:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 280823EF3A for ; Wed, 25 Jan 2023 18:41:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKjlj-0001Ss-KN; Wed, 25 Jan 2023 12:41:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKjlh-0001Sh-AI for guix-patches@gnu.org; Wed, 25 Jan 2023 12:41:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKjle-0007Jo-DH for guix-patches@gnu.org; Wed, 25 Jan 2023 12:41:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKjle-0000Q9-1x for guix-patches@gnu.org; Wed, 25 Jan 2023 12:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61031] [PATCH] Add emacs-kodi-remote. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 Jan 2023 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61031 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Matthieu Lemerre Cc: 61031@debbugs.gnu.org Received: via spool by 61031-submit@debbugs.gnu.org id=B61031.16746684561598 (code B ref 61031); Wed, 25 Jan 2023 17:41:02 +0000 Received: (at 61031) by debbugs.gnu.org; 25 Jan 2023 17:40:56 +0000 Received: from localhost ([127.0.0.1]:59873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKjlY-0000Pi-10 for submit@debbugs.gnu.org; Wed, 25 Jan 2023 12:40:56 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:48075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKjlV-0000PP-OE for 61031@debbugs.gnu.org; Wed, 25 Jan 2023 12:40:54 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id EEB7F1C0006; Wed, 25 Jan 2023 17:40:46 +0000 (UTC) From: Nicolas Goaziou References: <877cxcg9jk.fsf@cea.fr> Date: Wed, 25 Jan 2023 18:40:34 +0100 In-Reply-To: <877cxcg9jk.fsf@cea.fr> (Matthieu Lemerre's message of "Mon, 23 Jan 2023 23:39:43 +0100") Message-ID: <87bkmmo6lp.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674668480; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=XRvo2xE3UAxWnJ/rblDwlbIiofpJuqghgDMd0ttOgUw=; b=loOIFmR8BRmwjGSObhdrEscRzFfkTL9S4t2KdJxwolhGqxaIT41y/f3Y29Lqrr+RM/J8XB hlg0lGkBMNin8pXPZtMyv7PVSYbGzoOdeFbYO7Wr89fBH+FluIlGc6ePK6OdWKoZSLzC2V EXM115JU4mvNvQy7Gt/4O5PcnM+TLmWb2YC5l8uxLN7WazRwnG2vqx6hfW5BG+oEFldjRK 2pVH3VXiYHK3YrhwLk7b3O5ieZexVvNE//dSVPevXrvDpKj5y7Nzzju55Y4Zeox/PUmAjV SrFD0t0nf4vwt7wvOTBIJflBxmYb70URwZEI4xLYdLTj8Dyl06vDwMUap0OOxw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674668480; a=rsa-sha256; cv=none; b=FC5PBES7S7Dng+ttUnMQddqgMBr53Phkatm05QxVA4++qiqyV4zfvbNrZz2NdByNDF0gOy Yo0jKiGhM7eSQ8ERWWYYq1c0wykurlj+lt5fhBCj45f9BQ2BHh33mcdE7RHsIk1rbs+lCI AvXUt2YMtlM3wOlsySIQzf+20r7gxyWEP8iEA6ru1Nacm3qaGtkCVtu0aUCm9+3UsZPc46 rgYT1LdWMtz9hWdmDGVTE+pOSLqVAn6f7P2TXFDaKVQf/3AER+uDzQkiV+Sa68STXH0wIC 8YsMc0oArBcHdKZPDVtp8x8zCZmrK4vcA92aHoTmheonC6h8Y6YqhkxxTh8aIQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -3.18 X-Spam-Score: -3.18 X-Migadu-Queue-Id: 280823EF3A X-TUID: gSAuwEqHNNNd Hello, Matthieu Lemerre writes: > This emacs package allows to control Kodi remotely -- I use it every day and it is very handy! > The guix installation works well. Thank you. Some comments follow. > +(define-public emacs-kodi-remote > + (package > + (name "emacs-kodi-remote") > + (version "20190622.1325") According to "kodi-remote.el", version is "0", not this date-based one. You should also use `git-version' since we're using an unreleased version. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/spiderbit/kodi-remote.el.git") You should drop the ".git" suffix from URL. > + (commit "f5e932036c16e2b61a63020e006fc601e38d181e"))) Usually, we let-bind the commit at the beginning of the package definition and write (commit commit) > + (sha256 > + (base32 > + "1gck7lvqxcr9ikrzlpvcf4408cq6i4s8ijgb0kdsbkfzv0w86934")))) > + (build-system emacs-build-system) > + (propagated-inputs (list emacs-request emacs-let-alist emacs-json-mode emacs-f)) Please order inputs alphabetically. > + (home-page "http://github.com/spiderbit/kodi-remote.el") > + (synopsis "Remote Control for Kodi") > + (description > + "This package provides a major to remote control kodi instances. First specify kodi -> Kodi > +the hostname/ip of your kodi webserver: (setq kodi-host-name \"my-htpc:8080\") > +Then open the Remote with the command: kodi-remote Also open the current kodi > +Video Playlist with the command: kodi-remote-playlist Start play exercise mode: > +kodi-remote-exercise OPTIONAL: setup settings for deleting files (over tramp) > +(setq kodi-dangerous-options t) (setq kodi-access-host \"my-htpc\") if you don't > +use ssh to access your kodi server / nas: (setq kodi-access-method > +\"smb/ftp/adb...\")") This is more a manual excerpt than a proper description. Could you reword it a bit to describe what the package does, not how to do it? Note that sentences should be separated with full stops and two spaces, per Texinfo specification. > + (license gpl3+))) This cannot possibly build: the license above should be license:gpl3+. Could you send an updated patch? Regards, -- Nicolas Goaziou