* [bug#61157] gnu: Add uwufetch.
@ 2023-01-29 21:59 J. Sims via Guix-patches via
2023-01-31 14:19 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: J. Sims via Guix-patches via @ 2023-01-29 21:59 UTC (permalink / raw)
To: 61157
[-- Attachment #1.1: Type: text/plain, Size: 104 bytes --]
Hello,
This is a fun little fetch utility and I thought it might enjoy inclusion in Guix.
Thanks,
Juli
[-- Attachment #1.2: Type: text/html, Size: 500 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-uwufetch.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-uwufetch.patch, Size: 3345 bytes --]
From 17bff0290e443766b6f5cd9ff211c0026ded0bae Mon Sep 17 00:00:00 2001
From: Juliana Sims <jtsims@protonmail.com>
Date: Sun, 29 Jan 2023 15:44:48 -0600
Subject: [PATCH] gnu: Add uwufetch.
* gnu/packages/admin.scm (uwufetch): Add uwufetch.
---
gnu/packages/admin.scm | 47 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 5cea17d562..8babf4227e 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -55,6 +55,7 @@
;;; Copyright © 2022 ( <paren@disroot.org>
;;; Copyright © 2022 Matthew James Kraai <kraai@ftbfs.org>
;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2023 Juliana Sims <jtsims@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -3944,6 +3945,52 @@ (define-public hyfetch
you are running, what theme or icon set you are using, etc.")
(license license:expat)))
+(define-public uwufetch
+ (package
+ (name "uwufetch")
+ (version "2.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/TheDarkBug/uwufetch")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0s4pzaqmlq6rn54kgmlpcrc0sy3q5zn6lxh4448k9iimshljsjfs"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list #:tests? #f ;no tests
+ #:make-flags #~(list (string-append "DESTDIR="
+ #$output)
+ (string-append "ETC_DIR="
+ #$output "/etc")
+ (string-append "CC="
+ #$(cc-for-target)))
+ #:phases (with-imported-modules '((guix build utils))
+ #~(modify-phases %standard-phases
+ (delete 'configure)
+ (add-before 'build 'path-source-paths
+ (lambda _
+ (substitute* "uwufetch.c"
+ (("(/usr(/local)?)(.*;)"
+ all _ _ rest)
+ (string-append #$output
+ rest)))))))))
+ (native-inputs (list git))
+ (inputs (list lshw
+ ;; viu XXX not yet packaged in Guix
+ xwininfo))
+ (home-page "https://github.com/TheDarkBug/uwufetch")
+ (synopsis "Cutesie *fetch utility")
+ (description
+ "UwUFetch is a system information tool in the lineage of @code{neofetch},
+@code{pfetch}, @{hyfetch}, and the like. It prints ASCII art of your system's
+logo as well as a summary of system information. UwUFetch's unique contribution
+is the uwu-ification of various words used in the description. For example, Guix
+become gUwUix.")
+ (license license:gpl3)))
+
(define-public screenfetch
(package
(name "screenfetch")
base-commit: 4eccb27b4c74a9112cbbad722d85558e9565f20b
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#61157] gnu: Add uwufetch.
2023-01-29 21:59 [bug#61157] gnu: Add uwufetch J. Sims via Guix-patches via
@ 2023-01-31 14:19 ` Nicolas Goaziou
2023-01-31 18:49 ` J. Sims via Guix-patches via
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2023-01-31 14:19 UTC (permalink / raw)
To: 61157; +Cc: jtsims
Hello,
"J. Sims via Guix-patches" via <guix-patches@gnu.org> writes:
> This is a fun little fetch utility and I thought it might enjoy
> inclusion in Guix.
Thank you. Some comments follow.
> + (build-system gnu-build-system)
> + (arguments
> + (list #:tests? #f ;no tests
Please add a newline character after "list".
> + #:make-flags #~(list (string-append "DESTDIR="
> + #$output)
> + (string-append "ETC_DIR="
> + #$output "/etc")
> + (string-append "CC="
> + #$(cc-for-target)))
Please also add a newline character after "flags". Every flag should fit
into a single line.
> + #:phases (with-imported-modules '((guix build utils))
I don'tthink you need to import modules.
> + #~(modify-phases %standard-phases
> + (delete 'configure)
> + (add-before 'build 'path-source-paths
> + (lambda _
> + (substitute* "uwufetch.c"
> + (("(/usr(/local)?)(.*;)"
> + all _ _ rest)
> + (string-append #$output
> + rest)))))))))
You can move this below "#:phases" to drastically improve indentation.
> + (native-inputs (list git))
Are you sure git is required as a native input? If it is, then this
should be `git-minimal' instead.
> + (synopsis "Cutesie *fetch utility")
I think we should provide better than this synopsis. Maybe, according
to upstream's About,
Meme system info tool based on Nyan/UwU trend
> + (description
> + "UwUFetch is a system information tool in the lineage of @code{neofetch},
> +@code{pfetch}, @{hyfetch}, and the like. It prints ASCII art of your system's
I suggest to use Neofetch instead of @code{neofetch}, Pfetch instead of
@code{pfetch} and HyFetch instead of (mind the typo!) @code{hyfetch}.
> +logo as well as a summary of system information. UwUFetch's unique contribution
> +is the uwu-ification of various words used in the description. For example, Guix
> +become gUwUix.")
Sentences should be separated with two spaces.
> + (license license:gpl3)))
License is actually GPL3+.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread* [bug#61157] gnu: Add uwufetch.
2023-01-31 14:19 ` Nicolas Goaziou
@ 2023-01-31 18:49 ` J. Sims via Guix-patches via
2023-02-01 21:21 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: J. Sims via Guix-patches via @ 2023-01-31 18:49 UTC (permalink / raw)
To: 61157, Nicolas Goaziou
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
Hello,
I believe this version of the patch should address all the concerns you raised.
On Tuesday, January 31st, 2023 at 08:19, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> > + (license license:gpl3)))
>
> License is actually GPL3+.
For future reference, where do I look to differentiate GPLv3 from GPLv3+? I do check that, but obviously I sometimes miss it.
Thanks,
Juli
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-uwufetch.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-uwufetch.patch, Size: 2717 bytes --]
From 57c7e81d9d44a9e905e8a89714f05a9059f15226 Mon Sep 17 00:00:00 2001
From: Juliana Sims <jtsims@protonmail.com>
Date: Sun, 29 Jan 2023 15:44:48 -0600
Subject: [PATCH] gnu: Add uwufetch.
* gnu/packages/admin.scm (uwufetch): Add uwufetch.
---
gnu/packages/admin.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 5cea17d562..46b38ef053 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -55,6 +55,7 @@
;;; Copyright © 2022 ( <paren@disroot.org>
;;; Copyright © 2022 Matthew James Kraai <kraai@ftbfs.org>
;;; Copyright © 2022 jgart <jgart@dismail.de>
+;;; Copyright © 2023 Juliana Sims <jtsims@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -3944,6 +3945,48 @@ (define-public hyfetch
you are running, what theme or icon set you are using, etc.")
(license license:expat)))
+(define-public uwufetch
+ (package
+ (name "uwufetch")
+ (version "2.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/TheDarkBug/uwufetch")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0s4pzaqmlq6rn54kgmlpcrc0sy3q5zn6lxh4448k9iimshljsjfs"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list
+ #:tests? #f ;no tests
+ #:make-flags
+ #~(list (string-append "DESTDIR=" #$output)
+ (string-append "ETC_DIR=" #$output "/etc")
+ (string-append "CC=" #$(cc-for-target)))
+ #:phases
+ #~(modify-phases %standard-phases
+ (delete 'configure)
+ (add-before 'build 'path-source-paths
+ (lambda _
+ (substitute* "uwufetch.c"
+ (("(/usr(/local)?)(.*;)" all _ _ rest)
+ (string-append #$output rest))))))))
+ (inputs (list lshw
+ ;; viu XXX not yet packaged in Guix
+ xwininfo))
+ (home-page "https://github.com/TheDarkBug/uwufetch")
+ (synopsis "Meme system info tool based on Nyan/UwU trend")
+ (description
+ "UwUFetch is a system information tool in the lineage of NeoFetch,
+PFetch, HyFetch, and the like. It prints ASCII art of your system's logo as
+well as a summary of system information. UwUFetch's unique contribution is the
+uwu-ification of various words used in the description. For example, Guix
+becomes gUwUix.")
+ (license license:gpl3+)))
+
(define-public screenfetch
(package
(name "screenfetch")
base-commit: 4eccb27b4c74a9112cbbad722d85558e9565f20b
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#61157] gnu: Add uwufetch.
2023-01-31 18:49 ` J. Sims via Guix-patches via
@ 2023-02-01 21:21 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2023-02-01 21:21 UTC (permalink / raw)
To: 61157; +Cc: 61157-done, J. Sims
Hello,
"J. Sims via Guix-patches" via <guix-patches@gnu.org> writes:
> I believe this version of the patch should address all the concerns
> you raised.
It does. Thank you.
> For future reference, where do I look to differentiate GPLv3 from GPLv3+? I do check that, but obviously I sometimes miss it.
If you look into any ".c" source file, you will read:
either version 3 of the License, or (at your option) any later version.
which basically means GPL3+.
> Subject: [PATCH] gnu: Add uwufetch.
>
> * gnu/packages/admin.scm (uwufetch): Add uwufetch.
Applied!
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-01 21:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-29 21:59 [bug#61157] gnu: Add uwufetch J. Sims via Guix-patches via
2023-01-31 14:19 ` Nicolas Goaziou
2023-01-31 18:49 ` J. Sims via Guix-patches via
2023-02-01 21:21 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).