From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 61157@debbugs.gnu.org
Cc: jtsims@protonmail.com
Subject: [bug#61157] gnu: Add uwufetch.
Date: Tue, 31 Jan 2023 15:19:45 +0100 [thread overview]
Message-ID: <87bkme23cu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <PCtpn4Z54R3M2psFCibuS_3kC0Mtx_SuQBM13k9MDPeo0C_c6PBze-ro4I74HrK-IVBtvYTlaPcvGlX9sIT_F8Py_j9eN-WTGSsAEjk0i4U=@protonmail.com> (J. Sims via Guix-patches's message of "Sun, 29 Jan 2023 21:59:23 +0000")
Hello,
"J. Sims via Guix-patches" via <guix-patches@gnu.org> writes:
> This is a fun little fetch utility and I thought it might enjoy
> inclusion in Guix.
Thank you. Some comments follow.
> + (build-system gnu-build-system)
> + (arguments
> + (list #:tests? #f ;no tests
Please add a newline character after "list".
> + #:make-flags #~(list (string-append "DESTDIR="
> + #$output)
> + (string-append "ETC_DIR="
> + #$output "/etc")
> + (string-append "CC="
> + #$(cc-for-target)))
Please also add a newline character after "flags". Every flag should fit
into a single line.
> + #:phases (with-imported-modules '((guix build utils))
I don'tthink you need to import modules.
> + #~(modify-phases %standard-phases
> + (delete 'configure)
> + (add-before 'build 'path-source-paths
> + (lambda _
> + (substitute* "uwufetch.c"
> + (("(/usr(/local)?)(.*;)"
> + all _ _ rest)
> + (string-append #$output
> + rest)))))))))
You can move this below "#:phases" to drastically improve indentation.
> + (native-inputs (list git))
Are you sure git is required as a native input? If it is, then this
should be `git-minimal' instead.
> + (synopsis "Cutesie *fetch utility")
I think we should provide better than this synopsis. Maybe, according
to upstream's About,
Meme system info tool based on Nyan/UwU trend
> + (description
> + "UwUFetch is a system information tool in the lineage of @code{neofetch},
> +@code{pfetch}, @{hyfetch}, and the like. It prints ASCII art of your system's
I suggest to use Neofetch instead of @code{neofetch}, Pfetch instead of
@code{pfetch} and HyFetch instead of (mind the typo!) @code{hyfetch}.
> +logo as well as a summary of system information. UwUFetch's unique contribution
> +is the uwu-ification of various words used in the description. For example, Guix
> +become gUwUix.")
Sentences should be separated with two spaces.
> + (license license:gpl3)))
License is actually GPL3+.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-01-31 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 21:59 [bug#61157] gnu: Add uwufetch J. Sims via Guix-patches via
2023-01-31 14:19 ` Nicolas Goaziou [this message]
2023-01-31 18:49 ` J. Sims via Guix-patches via
2023-02-01 21:21 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkme23cu.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=61157@debbugs.gnu.org \
--cc=jtsims@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).