From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UFZcDCso2WMpFQAAbAwnHQ (envelope-from ) for ; Tue, 31 Jan 2023 15:39:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SGlmCyso2WNeCAAAG6o9tA (envelope-from ) for ; Tue, 31 Jan 2023 15:39:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EFA30361DF for ; Tue, 31 Jan 2023 15:39:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMrVS-0001Ps-LJ; Tue, 31 Jan 2023 09:21:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMrVO-0001PC-Pk for guix-patches@gnu.org; Tue, 31 Jan 2023 09:21:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMrVO-0007Nk-AQ for guix-patches@gnu.org; Tue, 31 Jan 2023 09:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMrVN-0008UJ-UW for guix-patches@gnu.org; Tue, 31 Jan 2023 09:21:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61157] gnu: Add uwufetch. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Jan 2023 14:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61157 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 61157@debbugs.gnu.org Cc: jtsims@protonmail.com X-Debbugs-Original-To: "J. Sims via Guix-patches" via X-Debbugs-Original-Cc: "J. Sims" , 61157@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167517480832529 (code B ref -1); Tue, 31 Jan 2023 14:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jan 2023 14:20:08 +0000 Received: from localhost ([127.0.0.1]:51912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMrUW-0008Sb-7e for submit@debbugs.gnu.org; Tue, 31 Jan 2023 09:20:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:58020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMrUS-0008SS-P2 for submit@debbugs.gnu.org; Tue, 31 Jan 2023 09:20:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMrUR-0001An-Lm for guix-patches@gnu.org; Tue, 31 Jan 2023 09:20:04 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMrUO-0006xK-WF for guix-patches@gnu.org; Tue, 31 Jan 2023 09:20:03 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id B9E8660009; Tue, 31 Jan 2023 14:19:52 +0000 (UTC) From: Nicolas Goaziou References: Date: Tue, 31 Jan 2023 15:19:45 +0100 In-Reply-To: (J. Sims via Guix-patches's message of "Sun, 29 Jan 2023 21:59:23 +0000") Message-ID: <87bkme23cu.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.195; envelope-from=mail@nicolasgoaziou.fr; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675175979; a=rsa-sha256; cv=none; b=nq/2b2vyDI7/Mm0iq+ur8ZjCeey4dHyV2d/rXwaFZRUVZ5JcAWeaYQ1o6WKldcQ/m7sFiF L0ueUpLAbOjMpQh5H0bi2xq8wCKxbDvoENyfetQhsfk8xKtKlBPVQEqTtM97Xe8lyC3nxN DCSYYXTpHGnQBxrAfWyRZ3b1mj2ji5L8AFpTZM/0SCL7hyyTxL6eEr3JyxBMYtEoTt5E/H x5q2M4+jMP+66S8htYmLEG+G7RGLGg0jL8nGSK5rCESuyOjM8DWmSZ6oRr0F0tvyVRVPvF 5rZBnmYEgundOtCMYX1cGAJ9/tE3vEXecojAVIlNpuD5Fvzra2NpQZXhlbXOnw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675175979; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=mYgw7T2M91qCxAoR0g4wlzvYHWdJFHxoQ7WNSeFU68Y=; b=UJazPRH88VLN5fP1MYanOZ1UcGfNDN6+Nt3mu13YuYWllAhLwCNhWw1n8SFGqKY+XYgejL wjcmpxVTCB9kJ9RHjgI2jWQZQGCBqhBlF8skzw4jnPke7c9HKeRY5ptrT8aHbR9qMBjsa3 R1PXg4ymXhyaOmyEBktiK9dAKIm3dlsofppu4yr4A/N9WBimeJDiZAZ2HC4jBAbQDmI36Z jtCNCX9BMV1XtuqBzyEZNTM9xgmgKvJPA3kyLf2xhd0vEkFoftx/vdvK4QqgWYmW7qomoM dFxUBcvNU90+vDadKydAP4Dp4O5V2sVQ/T2SVY0S0hbCpXd08p52vKe3WRU4Tw== Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.88 X-Spam-Score: -1.88 X-Migadu-Queue-Id: EFA30361DF X-TUID: 8Yw0j3oTC2Xv Hello, "J. Sims via Guix-patches" via writes: > This is a fun little fetch utility and I thought it might enjoy > inclusion in Guix. Thank you. Some comments follow. > + (build-system gnu-build-system) > + (arguments > + (list #:tests? #f ;no tests Please add a newline character after "list". > + #:make-flags #~(list (string-append "DESTDIR=" > + #$output) > + (string-append "ETC_DIR=" > + #$output "/etc") > + (string-append "CC=" > + #$(cc-for-target))) Please also add a newline character after "flags". Every flag should fit into a single line. > + #:phases (with-imported-modules '((guix build utils)) I don'tthink you need to import modules. > + #~(modify-phases %standard-phases > + (delete 'configure) > + (add-before 'build 'path-source-paths > + (lambda _ > + (substitute* "uwufetch.c" > + (("(/usr(/local)?)(.*;)" > + all _ _ rest) > + (string-append #$output > + rest))))))))) You can move this below "#:phases" to drastically improve indentation. > + (native-inputs (list git)) Are you sure git is required as a native input? If it is, then this should be `git-minimal' instead. > + (synopsis "Cutesie *fetch utility") I think we should provide better than this synopsis. Maybe, according to upstream's About, Meme system info tool based on Nyan/UwU trend > + (description > + "UwUFetch is a system information tool in the lineage of @code{neofetch}, > +@code{pfetch}, @{hyfetch}, and the like. It prints ASCII art of your system's I suggest to use Neofetch instead of @code{neofetch}, Pfetch instead of @code{pfetch} and HyFetch instead of (mind the typo!) @code{hyfetch}. > +logo as well as a summary of system information. UwUFetch's unique contribution > +is the uwu-ification of various words used in the description. For example, Guix > +become gUwUix.") Sentences should be separated with two spaces. > + (license license:gpl3))) License is actually GPL3+. Could you send an updated patch? Regards, -- Nicolas Goaziou