[bug#38556] [PATCH] gnu: qps: Updated to 2.0.0

[bug#38556] [PATCH] gnu: qps: Updated to 2.0.0

[Reza Alizadeh Majd]

* gnu/packages/lxqt.scm (qps): Update to version 2.0.0
---
 gnu/packages/lxqt.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 6b9ab051b4..5a3708e30a 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -1143,14 +1143,14 @@ window manager OpenBox.")
 (define-public qps
   (package
     (name "qps")
-    (version "1.10.20")
+    (version "2.0.0")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://github.com/lxqt/" name "/releases/download/"
                            version "/" name "-" version ".tar.xz"))
        (sha256
-        (base32 "0dz7ricxg2rrmdyca6mc2d4lyy5bpksjk751hvn95wssr76y2w0m"))))
+        (base32 "0ysnh918n9wz2vgjvyix32kx2j0v4lskjacgcychrpb8sch2dbsi"))))
     (build-system cmake-build-system)
     (inputs
      `(("libxrender" ,libxrender)
-- 
2.23.0

[bug#38556] [PATCH] gnu: qps: Updated to 2.0.0

[Brett Gilio]

Reza Alizadeh Majd <r.majd@pantherx.org> writes:

> * gnu/packages/lxqt.scm (qps): Update to version 2.0.0
> ---
>  gnu/packages/lxqt.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
> index 6b9ab051b4..5a3708e30a 100644
> --- a/gnu/packages/lxqt.scm
> +++ b/gnu/packages/lxqt.scm
> @@ -1143,14 +1143,14 @@ window manager OpenBox.")
>  (define-public qps
>    (package
>      (name "qps")
> -    (version "1.10.20")
> +    (version "2.0.0")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (string-append "https://github.com/lxqt/" name "/releases/download/"
>                             version "/" name "-" version ".tar.xz"))
>         (sha256
> -        (base32 "0dz7ricxg2rrmdyca6mc2d4lyy5bpksjk751hvn95wssr76y2w0m"))))
> +        (base32 "0ysnh918n9wz2vgjvyix32kx2j0v4lskjacgcychrpb8sch2dbsi"))))
>      (build-system cmake-build-system)
>      (inputs
>       `(("libxrender" ,libxrender)

I havent had a chance to test it, but it looks fine.

There is an issue with your commit message. s/Updated/Update and both
the commit message and sub-header need punctuation.

Thank you for your contribution! :) I look forward to seeing it get
pushed if there are no other objections.

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

[bug#38556] [PATCH] gnu: qps: Updated to 2.0.0

[Ricardo Wurmus]

Brett Gilio <brettg@posteo.net> writes:

> There is an issue with your commit message. s/Updated/Update and both
> the commit message and sub-header need punctuation.

If you’re using Emacs with yasnippet and magit you can type “update” and
hit TAB (or whatever expansion key you have set up) to insert the
appropriate update message.  There’s “add” as well, which inserts the
expected commit message for new packages.  I use these all the time to
speed up big package upgrades.

--
Ricardo

[bug#38556] [PATCH] gnu: qps: Updated to 2.0.0

[Reza Alizadeh Majd]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]


On Tue, Dec 10, 2019, at 11:06 AM, Brett Gilio wrote:
> There is an issue with your commit message. s/Updated/Update and both
> the commit message and sub-header need punctuation.

sorry for the issue with commit message, here is an updated patch with amended commit message.


-- 
Regards
Reza Alizadeh Majd
PantherX Team

[-- Attachment #2: 0001-gnu-qps-Update-to-2.0.0.patch --]
[-- Type: application/octet-stream, Size: 1112 bytes --]

From a0985f62a1b6c3ce8400a60cd13855823c6d1ec4 Mon Sep 17 00:00:00 2001
From: Reza Alizadeh Majd <r.majd@pantherx.org>
Date: Tue, 10 Dec 2019 10:17:18 +0330
Subject: [PATCH] gnu: qps: Update to 2.0.0

* gnu/packages/lxqt.scm (qps): Update to version 2.0.0
---
 gnu/packages/lxqt.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index 6b9ab051b4..5a3708e30a 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -1143,14 +1143,14 @@ window manager OpenBox.")
 (define-public qps
   (package
     (name "qps")
-    (version "1.10.20")
+    (version "2.0.0")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://github.com/lxqt/" name "/releases/download/"
                            version "/" name "-" version ".tar.xz"))
        (sha256
-        (base32 "0dz7ricxg2rrmdyca6mc2d4lyy5bpksjk751hvn95wssr76y2w0m"))))
+        (base32 "0ysnh918n9wz2vgjvyix32kx2j0v4lskjacgcychrpb8sch2dbsi"))))
     (build-system cmake-build-system)
     (inputs
      `(("libxrender" ,libxrender)
-- 
2.23.0

bug#38556: [PATCH] gnu: qps: Updated to 2.0.0

[Brett Gilio]

"Reza Alizadeh Majd" <r.majd@pantherx.org> writes:

> On Tue, Dec 10, 2019, at 11:06 AM, Brett Gilio wrote:
>> There is an issue with your commit message. s/Updated/Update and both
>> the commit message and sub-header need punctuation.
>
> sorry for the issue with commit message, here is an updated patch with
> amended commit message.

Hey Reza,

As Ricardo noted, if you use GNU Emacs or anything with the ability to
parse yasnippet syntax you can use those snippets provided in
guix/etc/snippets to generate these commit messages. Your revised commit
messages still has some small problems.

I have revised them as such, (from my Magit buffer):

--8<---------------cut here---------------start------------->8---
gnu: qps: Update to 2.0.0.

* gnu/packages/lxqt.scm (qps): Update to 2.0.0.

Signed-off-by: Brett Gilio <brettg@posteo.net>

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# Author:    Reza Alizadeh Majd <r.majd@pantherx.org>
# Date:      Tue Dec 10 12:57:33 2019 +0330
#
# On branch master
# Your branch is ahead of 'origin/master' by 1 commit.
#   (use "git push" to publish your local commits)
#
# Changes to be committed:
#	modified:   gnu/packages/lxqt.scm
#
--8<---------------cut here---------------end--------------->8---

Additionally, I have built and tested the changes on my machine. It
looks fine.

I have pushed the changes to master with
fc8131638499d907153473119279cbcd7f029bc7.

Closing! Thanks.


-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/