From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47283) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iekkr-0007v8-94 for guix-patches@gnu.org; Tue, 10 Dec 2019 14:01:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iekkp-0002WQ-LF for guix-patches@gnu.org; Tue, 10 Dec 2019 14:01:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50621) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iekko-0002W7-GD for guix-patches@gnu.org; Tue, 10 Dec 2019 14:01:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iekko-0004Oa-Eq for guix-patches@gnu.org; Tue, 10 Dec 2019 14:01:02 -0500 Subject: bug#38556: [PATCH] gnu: qps: Updated to 2.0.0 Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Brett Gilio References: <20191210073108.1888-1-r.majd@pantherx.org> <87eexczl6r.fsf@posteo.net> <26f168c7-e367-4a2f-a2cb-8a97e263713a@www.fastmail.com> Date: Tue, 10 Dec 2019 12:59:37 -0600 In-Reply-To: <26f168c7-e367-4a2f-a2cb-8a97e263713a@www.fastmail.com> (Reza Alizadeh Majd's message of "Tue, 10 Dec 2019 12:57:33 +0330") Message-ID: <87a780ypk6.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Reza Alizadeh Majd Cc: 38556-done@debbugs.gnu.org "Reza Alizadeh Majd" writes: > On Tue, Dec 10, 2019, at 11:06 AM, Brett Gilio wrote: >> There is an issue with your commit message. s/Updated/Update and both >> the commit message and sub-header need punctuation. > > sorry for the issue with commit message, here is an updated patch with > amended commit message. Hey Reza, As Ricardo noted, if you use GNU Emacs or anything with the ability to parse yasnippet syntax you can use those snippets provided in guix/etc/snippets to generate these commit messages. Your revised commit messages still has some small problems. I have revised them as such, (from my Magit buffer): --8<---------------cut here---------------start------------->8--- gnu: qps: Update to 2.0.0. * gnu/packages/lxqt.scm (qps): Update to 2.0.0. Signed-off-by: Brett Gilio # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Author: Reza Alizadeh Majd # Date: Tue Dec 10 12:57:33 2019 +0330 # # On branch master # Your branch is ahead of 'origin/master' by 1 commit. # (use "git push" to publish your local commits) # # Changes to be committed: # modified: gnu/packages/lxqt.scm # --8<---------------cut here---------------end--------------->8--- Additionally, I have built and tested the changes on my machine. It looks fine. I have pushed the changes to master with fc8131638499d907153473119279cbcd7f029bc7. Closing! Thanks. -- Brett M. Gilio Homepage -- https://scm.pw/ GNU Guix -- https://guix.gnu.org/