unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brett Gilio <brettg@posteo.net>
To: Reza Alizadeh Majd <r.majd@pantherx.org>
Cc: 38556-done@debbugs.gnu.org
Subject: bug#38556: [PATCH] gnu: qps: Updated to 2.0.0
Date: Tue, 10 Dec 2019 12:59:37 -0600	[thread overview]
Message-ID: <87a780ypk6.fsf@posteo.net> (raw)
In-Reply-To: <26f168c7-e367-4a2f-a2cb-8a97e263713a@www.fastmail.com> (Reza Alizadeh Majd's message of "Tue, 10 Dec 2019 12:57:33 +0330")

"Reza Alizadeh Majd" <r.majd@pantherx.org> writes:

> On Tue, Dec 10, 2019, at 11:06 AM, Brett Gilio wrote:
>> There is an issue with your commit message. s/Updated/Update and both
>> the commit message and sub-header need punctuation.
>
> sorry for the issue with commit message, here is an updated patch with
> amended commit message.

Hey Reza,

As Ricardo noted, if you use GNU Emacs or anything with the ability to
parse yasnippet syntax you can use those snippets provided in
guix/etc/snippets to generate these commit messages. Your revised commit
messages still has some small problems.

I have revised them as such, (from my Magit buffer):

--8<---------------cut here---------------start------------->8---
gnu: qps: Update to 2.0.0.

* gnu/packages/lxqt.scm (qps): Update to 2.0.0.

Signed-off-by: Brett Gilio <brettg@posteo.net>

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# Author:    Reza Alizadeh Majd <r.majd@pantherx.org>
# Date:      Tue Dec 10 12:57:33 2019 +0330
#
# On branch master
# Your branch is ahead of 'origin/master' by 1 commit.
#   (use "git push" to publish your local commits)
#
# Changes to be committed:
#	modified:   gnu/packages/lxqt.scm
#
--8<---------------cut here---------------end--------------->8---

Additionally, I have built and tested the changes on my machine. It
looks fine.

I have pushed the changes to master with
fc8131638499d907153473119279cbcd7f029bc7.

Closing! Thanks.


-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

      reply	other threads:[~2019-12-10 19:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10  7:31 [bug#38556] [PATCH] gnu: qps: Updated to 2.0.0 Reza Alizadeh Majd
2019-12-10  7:36 ` Brett Gilio
2019-12-10  8:44   ` Ricardo Wurmus
2019-12-10  9:27   ` Reza Alizadeh Majd
2019-12-10 18:59     ` Brett Gilio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a780ypk6.fsf@posteo.net \
    --to=brettg@posteo.net \
    --cc=38556-done@debbugs.gnu.org \
    --cc=r.majd@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).