unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 35234@debbugs.gnu.org
Subject: [bug#35234] [PATCH] gnu: Add the-dark-mod.
Date: Fri, 12 Apr 2019 11:39:33 +0200	[thread overview]
Message-ID: <878swflfze.fsf@ambrevar.xyz> (raw)
In-Reply-To: <87d0lsib4l.fsf@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Ricardo Wurmus <rekado@elephly.net> writes:

> Hi Pierre,
>
>> * gnu/packages/games.scm (the-dark-mod): New variable.
> […]
>> +      (synopsis "Game based on the Thief series by Looking Glass Studios")
>> +      (description (format #f "The Dark Mod (TDM) is stealth/infiltration game
>> +based on the Thief series by Looking Glass Studios.  Formerly a Doom III mod,
>> +it is now released as a standalone.
>> +
>> +The game data must be fetched manually by running @command{tdm_update}.
>> +The ~a environment variable specifies the location where the game data is
>> +saved (defaults to ~a)."
>> +                           the-dark-mod-env-var-name the-dark-mod-env-var-value))
>
> Is this actually free software?  Does it depend on the proprietary Thief
> game data to be playable?  What is the purpose of tdm_update?

It is: I added a comment in the license section: all the data fetched by
the "tdm_update" executable is under CC.  tdm_update is the in-house
package manager.  It's sad the game data is not versioned, but I don't
see a way around it at  the moment.

We have quite a few game engines in our repository that
depend on proprietary game data to be playable.  But The Dark Mod is not one
of them.

> The value of the description field must be a plain string.  It should
> not be a format expression to allow for translations.

Hmm... I really liked that I could make the environment variable
customizable, but I guess I'll have to hard-code it in the description then.

Thanks for the review!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2019-04-12  9:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 18:16 [bug#35234] [PATCH] gnu: Add the-dark-mod Pierre Neidhardt
2019-04-11 19:40 ` Ricardo Wurmus
2019-04-12  9:39   ` Pierre Neidhardt [this message]
2019-04-12 11:22     ` Ricardo Wurmus
2019-04-12 12:02       ` Pierre Neidhardt
2019-04-21 14:13         ` Ricardo Wurmus
2019-04-21 16:18           ` Ludovic Courtès
2019-04-22  9:02             ` Pierre Neidhardt
2019-04-22  9:19               ` Ricardo Wurmus
2019-04-22  9:42                 ` Pierre Neidhardt
2019-04-22 16:50                 ` Ludovic Courtès
2019-04-22 17:42                   ` Pierre Neidhardt
2019-04-22 10:01             ` Adonay Felipe Nogueira
2019-04-22  9:40           ` Adonay Felipe Nogueira
2019-04-22 11:56             ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878swflfze.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=35234@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).