From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:60411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEsfD-0002Zi-Lo for guix-patches@gnu.org; Fri, 12 Apr 2019 05:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEsfC-0003V4-Fl for guix-patches@gnu.org; Fri, 12 Apr 2019 05:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41934) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEsfC-0003Um-8P for guix-patches@gnu.org; Fri, 12 Apr 2019 05:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEsfC-0002PO-0x for guix-patches@gnu.org; Fri, 12 Apr 2019 05:40:02 -0400 Subject: [bug#35234] [PATCH] gnu: Add the-dark-mod. Resent-Message-ID: From: Pierre Neidhardt In-Reply-To: <87d0lsib4l.fsf@elephly.net> References: <20190411181644.21661-1-mail@ambrevar.xyz> <87d0lsib4l.fsf@elephly.net> Date: Fri, 12 Apr 2019 11:39:33 +0200 Message-ID: <878swflfze.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 35234@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Wurmus writes: > Hi Pierre, > >> * gnu/packages/games.scm (the-dark-mod): New variable. > [=E2=80=A6] >> + (synopsis "Game based on the Thief series by Looking Glass Studio= s") >> + (description (format #f "The Dark Mod (TDM) is stealth/infiltrati= on game >> +based on the Thief series by Looking Glass Studios. Formerly a Doom II= I mod, >> +it is now released as a standalone. >> + >> +The game data must be fetched manually by running @command{tdm_update}. >> +The ~a environment variable specifies the location where the game data = is >> +saved (defaults to ~a)." >> + the-dark-mod-env-var-name the-dark-mod-env-v= ar-value)) > > Is this actually free software? Does it depend on the proprietary Thief > game data to be playable? What is the purpose of tdm_update? It is: I added a comment in the license section: all the data fetched by the "tdm_update" executable is under CC. tdm_update is the in-house package manager. It's sad the game data is not versioned, but I don't see a way around it at the moment. We have quite a few game engines in our repository that depend on proprietary game data to be playable. But The Dark Mod is not one of them. > The value of the description field must be a plain string. It should > not be a format expression to allow for translations. Hmm... I really liked that I could make the environment variable customizable, but I guess I'll have to hard-code it in the description then. Thanks for the review! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlywXNUACgkQm9z0l6S7 zH9AWQf/eT6FKx1yKU8g99fZE/J6AvZw7aB8eZTqH+lEJvMH/BlD1Bne6Qjup3Zo zrpmPAqmWMy24LkOvzp7KB1VBVpZZ+rp9rAGfuYa6NiseJ3ia+r7yioQm4eSAwts QxB38FbNnW8uheQMGacLzHPvK3OXfFDsmPvNX/0eib0BWHL5BOckxf+7MdGbRzMW 3F6YyanEZEz0ShGSAnoa54BKHqi8Pyn0ssKTOLg5QUMY0R6hQqcz0nZ2TbkrAOVB sQ0sR2h9lDHFQRhjsQ6R43vJzBQL7puhY/VS/uZrQb9i6y2kUig5UYb7mkpc7uZt b+gQsyQnxj6/LNw6ASM2HrdxNtDL3g== =udyO -----END PGP SIGNATURE----- --=-=-=--