From: Marius Bakke <marius@gnu.org>
To: Alexandros Theodotou <alex@zrythm.org>, 42281@debbugs.gnu.org
Subject: [bug#42281] [PATCH] gnu: Add python-buku.
Date: Tue, 21 Jul 2020 00:29:19 +0200 [thread overview]
Message-ID: <878sfdhlc0.fsf@gnu.org> (raw)
In-Reply-To: <640185039a38a8f421546d3b8b987f6d4cb4ec59.camel@zrythm.org>
[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]
Alexandros Theodotou <alex@zrythm.org> writes:
> * gnu/packages/python-xyz.scm (python-buku): New variable.
As this seems like a general-purpose tool and not a Python library, it
would be good to place this elsewhere. I'm not sure where though, maybe
(gnu packages web)?
Also I think the 'python-' prefix can be removed.
[...]
> +(define-public python-buku
> + (package
> + (name "python-buku")
> + (version "4.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "buku" version))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1g1xhdskfn72xaraqzz2v8dl2iza7bzfpn17z2wdrzkq3ih7yvgg"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:tests? #f)) ; needs python-mypy-extensions which fails to build
Actually python-mypy-extensions seems to not be in Guix at all. Can you
adjust the comment with a TODO?
> + (propagated-inputs
> + `(("python-html5lib" ,python-html5lib)
> + ("python-urllib3" ,python-urllib3)
> + ("python-beautifulsoup4" ,python-beautifulsoup4)
> + ("python-pytest" ,python-pytest)
> + ("python-pytest-cov" ,python-pytest-cov)
> + ("python-pylint" ,python-pylint)
> + ("python-vcrpy" ,python-vcrpy)))
These can probably be regular inputs, as python-build-system will
automatically 'wrap' the executables with these on PYTHONPATH.
> + (home-page "https://github.com/jarun/buku")
> + (synopsis
> + "Bookmark manager")
> + (description
> + "buku is a powerful bookmark manager written in Python3 and SQLite3.")
It's a chore, but it would be great if you could expand on the
description. Something along the lines of "@command{buku} can
auto-import bookmarks from your browser and present them in an
interactive command-line interface that lets you compose and update
bookmarks directly. It can also present them in a web interface with
@command{bukuserver}."
Can you send an updated patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-07-20 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 21:38 [bug#42281] [PATCH] gnu: Add python-buku Alexandros Theodotou
2020-07-08 21:41 ` Alexandros Theodotou
2020-07-20 22:29 ` Marius Bakke [this message]
2020-09-10 15:57 ` Alexandros Theodotou
2020-12-18 14:02 ` bug#42281: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sfdhlc0.fsf@gnu.org \
--to=marius@gnu.org \
--cc=42281@debbugs.gnu.org \
--cc=alex@zrythm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).