From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AM7cIvIaFl/TMgAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 22:30:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id Vtm3HvIaFl8eGwAA1q6Kng (envelope-from ) for ; Mon, 20 Jul 2020 22:30:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C73F0940220 for ; Mon, 20 Jul 2020 22:30:09 +0000 (UTC) Received: from localhost ([::1]:57998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxeIR-0003ig-Eo for larch@yhetil.org; Mon, 20 Jul 2020 18:30:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxeIN-0003hN-AE for guix-patches@gnu.org; Mon, 20 Jul 2020 18:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53305) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxeIM-0003Pp-Vx for guix-patches@gnu.org; Mon, 20 Jul 2020 18:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxeIM-0000Ay-QC for guix-patches@gnu.org; Mon, 20 Jul 2020 18:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42281] [PATCH] gnu: Add python-buku. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Jul 2020 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42281 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandros Theodotou , 42281@debbugs.gnu.org Received: via spool by 42281-submit@debbugs.gnu.org id=B42281.1595284178624 (code B ref 42281); Mon, 20 Jul 2020 22:30:02 +0000 Received: (at 42281) by debbugs.gnu.org; 20 Jul 2020 22:29:38 +0000 Received: from localhost ([127.0.0.1]:36618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxeHy-00009z-3J for submit@debbugs.gnu.org; Mon, 20 Jul 2020 18:29:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxeHw-00009n-00 for 42281@debbugs.gnu.org; Mon, 20 Jul 2020 18:29:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42552) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxeHp-0003KS-Ki; Mon, 20 Jul 2020 18:29:29 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:59476 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jxeHo-0001v4-Fa; Mon, 20 Jul 2020 18:29:29 -0400 From: Marius Bakke In-Reply-To: <640185039a38a8f421546d3b8b987f6d4cb4ec59.camel@zrythm.org> References: <2253d09b2894e2630055161c99db21b334a861b6.camel@zrythm.org> <640185039a38a8f421546d3b8b987f6d4cb4ec59.camel@zrythm.org> Date: Tue, 21 Jul 2020 00:29:19 +0200 Message-ID: <878sfdhlc0.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: mTMKITVfzwPU --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alexandros Theodotou writes: > * gnu/packages/python-xyz.scm (python-buku): New variable. As this seems like a general-purpose tool and not a Python library, it would be good to place this elsewhere. I'm not sure where though, maybe (gnu packages web)? Also I think the 'python-' prefix can be removed. [...] =20=20 > +(define-public python-buku > + (package > + (name "python-buku") > + (version "4.4") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "buku" version)) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1g1xhdskfn72xaraqzz2v8dl2iza7bzfpn17z2wdrzkq3ih7yvgg")))) > + (build-system python-build-system) > + (arguments > + `(#:tests? #f)) ; needs python-mypy-extensions which fails to build Actually python-mypy-extensions seems to not be in Guix at all. Can you adjust the comment with a TODO? > + (propagated-inputs > + `(("python-html5lib" ,python-html5lib) > + ("python-urllib3" ,python-urllib3) > + ("python-beautifulsoup4" ,python-beautifulsoup4) > + ("python-pytest" ,python-pytest) > + ("python-pytest-cov" ,python-pytest-cov) > + ("python-pylint" ,python-pylint) > + ("python-vcrpy" ,python-vcrpy))) These can probably be regular inputs, as python-build-system will automatically 'wrap' the executables with these on PYTHONPATH. > + (home-page "https://github.com/jarun/buku") > + (synopsis > + "Bookmark manager") > + (description > + "buku is a powerful bookmark manager written in Python3 and SQLite= 3.") It's a chore, but it would be great if you could expand on the description. Something along the lines of "@command{buku} can auto-import bookmarks from your browser and present them in an interactive command-line interface that lets you compose and update bookmarks directly. It can also present them in a web interface with @command{bukuserver}." Can you send an updated patch? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8WGr8ACgkQoqBt8qM6 VPpbwAf/VymtuxdYPGINbYFMBxwCN2tQGU9+zp3Ii/EDf2W9UdiaCFZ7PAjlq48T 8CyTJXweula4KCwl9gKkhFuyKexg6MyU1dnbhNWc7bjgETZmfbSXypLE1j8CSEom IdyUJ5KcqC/c7Mg24uQdSL0FU2uTC1rb0PC0tPZvcoerQmigSC12lbR54wx0JOz0 +BirqaC04AufzwByJtXfkkXWNhv8BCcxV6bO5yG84wqm9NLcYHMlPksZTxobcfaq EnCeDbg8rXmq4RnimvUWd7R8tmiYPUUclowSVu1YKSqyA/yp3BIGLOaOdY470mPG t9+kWKNXj04yhHTmKZ+pLTD35kuvzA== =Rn4w -----END PGP SIGNATURE----- --=-=-=--