Alexandros Theodotou <alex@zrythm.org> writes:

> * gnu/packages/python-xyz.scm (python-buku): New variable.

As this seems like a general-purpose tool and not a Python library, it
would be good to place this elsewhere.  I'm not sure where though, maybe
(gnu packages web)?

Also I think the 'python-' prefix can be removed.

[...]
  
> +(define-public python-buku
> +  (package
> +    (name "python-buku")
> +    (version "4.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "buku" version))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1g1xhdskfn72xaraqzz2v8dl2iza7bzfpn17z2wdrzkq3ih7yvgg"))))
> +    (build-system python-build-system)
> +    (arguments
> +      `(#:tests? #f)) ; needs python-mypy-extensions which fails to build

Actually python-mypy-extensions seems to not be in Guix at all.  Can you
adjust the comment with a TODO?

> +    (propagated-inputs
> +      `(("python-html5lib" ,python-html5lib)
> +        ("python-urllib3" ,python-urllib3)
> +        ("python-beautifulsoup4" ,python-beautifulsoup4)
> +        ("python-pytest" ,python-pytest)
> +        ("python-pytest-cov" ,python-pytest-cov)
> +        ("python-pylint" ,python-pylint)
> +        ("python-vcrpy" ,python-vcrpy)))

These can probably be regular inputs, as python-build-system will
automatically 'wrap' the executables with these on PYTHONPATH.

> +    (home-page "https://github.com/jarun/buku")
> +    (synopsis
> +      "Bookmark manager")
> +    (description
> +      "buku is a powerful bookmark manager written in Python3 and SQLite3.")

It's a chore, but it would be great if you could expand on the
description.  Something along the lines of "@command{buku} can
auto-import bookmarks from your browser and present them in an
interactive command-line interface that lets you compose and update
bookmarks directly.  It can also present them in a web interface with
@command{bukuserver}."

Can you send an updated patch?