From: Alexandros Theodotou <alex@zrythm.org>
To: Marius Bakke <marius@gnu.org>, 42281@debbugs.gnu.org
Subject: [bug#42281] [PATCH] gnu: Add python-buku.
Date: Thu, 10 Sep 2020 16:57:53 +0100 [thread overview]
Message-ID: <bd6a71b8e9a68016b6eedbed96a39fa06bf6ed07.camel@zrythm.org> (raw)
In-Reply-To: <878sfdhlc0.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 1808 bytes --]
Hi Marius,
On Tue, 2020-07-21 at 00:29 +0200, Marius Bakke wrote:
> As this seems like a general-purpose tool and not a Python library,
> it
> would be good to place this elsewhere. I'm not sure where though,
> maybe
> (gnu packages web)?
>
> Also I think the 'python-' prefix can be removed.
Done.
> > + (arguments
> > + `(#:tests? #f)) ; needs python-mypy-extensions which fails
> > to build
>
> Actually python-mypy-extensions seems to not be in Guix at all. Can
> you
> adjust the comment with a TODO?
Done.
>
> > + (propagated-inputs
> > + `(("python-html5lib" ,python-html5lib)
> > + ("python-urllib3" ,python-urllib3)
> > + ("python-beautifulsoup4" ,python-beautifulsoup4)
> > + ("python-pytest" ,python-pytest)
> > + ("python-pytest-cov" ,python-pytest-cov)
> > + ("python-pylint" ,python-pylint)
> > + ("python-vcrpy" ,python-vcrpy)))
>
> These can probably be regular inputs, as python-build-system will
> automatically 'wrap' the executables with these on PYTHONPATH.
Done.
>
> > + (home-page "https://github.com/jarun/buku")
> > + (synopsis
> > + "Bookmark manager")
> > + (description
> > + "buku is a powerful bookmark manager written in Python3 and
> > SQLite3.")
>
> It's a chore, but it would be great if you could expand on the
> description. Something along the lines of "@command{buku} can
> auto-import bookmarks from your browser and present them in an
> interactive command-line interface that lets you compose and update
> bookmarks directly. It can also present them in a web interface with
> @command{bukuserver}."
Added your proposed text.
> Can you send an updated patch?
Please find the new patch attached.
Thanks,
Alex
[-- Attachment #1.2: 0001-gnu-Add-buku.patch --]
[-- Type: text/x-patch, Size: 1977 bytes --]
From 217d5661c4d76f79176d947b2376dfa89e5dcc01 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Thu, 10 Sep 2020 16:54:52 +0100
Subject: [PATCH] gnu: Add buku.
* gnu/packages/web.scm (buku): New variable.
---
gnu/packages/web.scm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 2c3a007779..cf4f1ef0b1 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -7424,6 +7424,40 @@ update an existing mirrored site, and resume interrupted downloads.
HTTrack is fully configurable, and has an integrated help system.")
(license license:gpl3+)))
+(define-public buku
+ (package
+ (name "buku")
+ (version "4.4")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "buku" version))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1g1xhdskfn72xaraqzz2v8dl2iza7bzfpn17z2wdrzkq3ih7yvgg"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:tests? #f)) ; TODO needs python-mypy-extensions
+ (inputs
+ `(("python-html5lib" ,python-html5lib)
+ ("python-urllib3" ,python-urllib3)
+ ("python-beautifulsoup4" ,python-beautifulsoup4)
+ ("python-pytest" ,python-pytest)
+ ("python-pytest-cov" ,python-pytest-cov)
+ ("python-pylint" ,python-pylint)
+ ("python-vcrpy" ,python-vcrpy)))
+ (home-page "https://github.com/jarun/buku")
+ (synopsis
+ "Bookmark manager")
+ (description
+ "buku is a powerful bookmark manager written in Python3 and SQLite3.
+@command{buku} can auto-import bookmarks from your browser and present them
+in an interactive command-line interface that lets you compose and update
+bookmarks directly. It can also present them in a web interface with
+@command{bukuserver}.")
+ (license license:gpl3+)))
+
(define-public anonip
(package
(name "anonip")
--
2.27.0
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-10 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 21:38 [bug#42281] [PATCH] gnu: Add python-buku Alexandros Theodotou
2020-07-08 21:41 ` Alexandros Theodotou
2020-07-20 22:29 ` Marius Bakke
2020-09-10 15:57 ` Alexandros Theodotou [this message]
2020-12-18 14:02 ` bug#42281: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd6a71b8e9a68016b6eedbed96a39fa06bf6ed07.camel@zrythm.org \
--to=alex@zrythm.org \
--cc=42281@debbugs.gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).