unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services.
@ 2020-03-18 15:45 John Soo
  2020-03-21 22:42 ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: John Soo @ 2020-03-18 15:45 UTC (permalink / raw)
  To: 40120

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

Hi guix,

I struggled with the console-font-service-type for a long time (mostly
becase setfont does not state you can specify a path). Documenting it
in the info pages would have helped.

Thanks!

John

[-- Attachment #2: 0001-doc-guix.texi-Add-console-font-service-type-to-Base-.patch --]
[-- Type: text/x-patch, Size: 1473 bytes --]

From 6a7204a6396781c1bbc1db1defee362c0a8142f9 Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1@asu.edu>
Date: Wed, 18 Mar 2020 08:33:59 -0700
Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
 Services.

* doc/guix.texi (console-font-service-type): Add it.
---
 doc/guix.texi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 28808b0cd5..0626beffac 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -12287,6 +12287,23 @@ symlink:
 Return a service that sets the host name to @var{name}.
 @end deffn
 
+@deffn {Scheme Procedure} console-font-service-type @var{tty-font-pairs}
+Install the given fonts on the specified ttys (fonts are per
+virtual console on the kernel Linux).  The value of this service is a list of
+tty/font pairs.  The font can be the name of a font provided by the @code{kbd}
+package or any valid argument to @command{setfont}, as in this example:
+
+@lisp
+'((\"tty1\" . \"LatGrkCyr-8x16\")
+  (\"tty2\" . (file-append
+                font-tamzen
+                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\"))
+  (\"tty3\" . (file-append
+                font-terminus
+                \"/share/consolefonts/ter-132n\"))) ; for HDPI
+@end lisp
+@end deffn
+
 @deffn {Scheme Procedure} login-service @var{config}
 Return a service to run login according to @var{config}, a
 @code{<login-configuration>} object, which specifies the message of the day,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services.
  2020-03-18 15:45 [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services John Soo
@ 2020-03-21 22:42 ` Ludovic Courtès
  2020-03-21 23:16   ` John Soo
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2020-03-21 22:42 UTC (permalink / raw)
  To: John Soo; +Cc: 40120

Hi John,

Thanks for improving the manual!  Some comments:

John Soo <jsoo1@asu.edu> skribis:

> From 6a7204a6396781c1bbc1db1defee362c0a8142f9 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1@asu.edu>
> Date: Wed, 18 Mar 2020 08:33:59 -0700
> Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
>  Services.
>
> * doc/guix.texi (console-font-service-type): Add it.
                  ^
This should be the name of the section this is added in.

> +@deffn {Scheme Procedure} console-font-service-type @var{tty-font-pairs}

This should be @defvr because it’s a variable, not a procedure (and thus
has no arguments).

Could you change that accordingly?  You can take inspiration from other
service types.

TIA!

Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services.
  2020-03-21 22:42 ` Ludovic Courtès
@ 2020-03-21 23:16   ` John Soo
  2020-03-22  2:40     ` John Soo
  0 siblings, 1 reply; 6+ messages in thread
From: John Soo @ 2020-03-21 23:16 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 40120

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hi Ludo,

>> * doc/guix.texi (console-font-service-type): Add it.
>                   ^
> This should be the name of the section this is added in.

>> +@deffn {Scheme Procedure} console-font-service-type @var{tty-font-pairs}
>
> This should be @defvr because it’s a variable, not a procedure (and thus
> has no arguments).

Done and done, thanks again!

John


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fixed commit message and used defvr --]
[-- Type: text/x-patch, Size: 1484 bytes --]

From 74e8c62c584ac33909036992dde7d4cf3a1c7588 Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1@asu.edu>
Date: Wed, 18 Mar 2020 08:33:59 -0700
Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
 Services.

* doc/guix.texi (Base Services): Add console-font-service-type.
---
 doc/guix.texi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index c2eff582f8..8c694a9e73 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -12287,6 +12287,23 @@ symlink:
 Return a service that sets the host name to @var{name}.
 @end deffn
 
+@defvr {Scheme Procedure} console-font-service-type @var{tty-font-pairs}
+Install the given fonts on the specified ttys (fonts are per
+virtual console on the kernel Linux).  The value of this service is a list of
+tty/font pairs.  The font can be the name of a font provided by the @code{kbd}
+package or any valid argument to @command{setfont}, as in this example:
+
+@lisp
+'((\"tty1\" . \"LatGrkCyr-8x16\")
+  (\"tty2\" . (file-append
+                font-tamzen
+                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\"))
+  (\"tty3\" . (file-append
+                font-terminus
+                \"/share/consolefonts/ter-132n\"))) ; for HDPI
+@end lisp
+@end deffn
+
 @deffn {Scheme Procedure} login-service @var{config}
 Return a service to run login according to @var{config}, a
 @code{<login-configuration>} object, which specifies the message of the day,
-- 
2.25.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services.
  2020-03-21 23:16   ` John Soo
@ 2020-03-22  2:40     ` John Soo
  2020-03-22  3:12       ` John Soo
  0 siblings, 1 reply; 6+ messages in thread
From: John Soo @ 2020-03-22  2:40 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 40120

[-- Attachment #1: Type: text/plain, Size: 111 bytes --]

Hi again,

I just realized I should also change "Scheme Procudure" to "Scheme
Variable".

Thanks again,

John


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fixed Scheme Procedure -> Scheme Variable --]
[-- Type: text/x-patch, Size: 1483 bytes --]

From 8d9bab98fb448e72431bf0e6b24747379082a774 Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1@asu.edu>
Date: Wed, 18 Mar 2020 08:33:59 -0700
Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
 Services.

* doc/guix.texi (Base Services): Add console-font-service-type.
---
 doc/guix.texi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index c2eff582f8..fab41cfe00 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -12287,6 +12287,23 @@ symlink:
 Return a service that sets the host name to @var{name}.
 @end deffn
 
+@defvr {Scheme Variable} console-font-service-type @var{tty-font-pairs}
+Install the given fonts on the specified ttys (fonts are per
+virtual console on the kernel Linux).  The value of this service is a list of
+tty/font pairs.  The font can be the name of a font provided by the @code{kbd}
+package or any valid argument to @command{setfont}, as in this example:
+
+@lisp
+'((\"tty1\" . \"LatGrkCyr-8x16\")
+  (\"tty2\" . (file-append
+                font-tamzen
+                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\"))
+  (\"tty3\" . (file-append
+                font-terminus
+                \"/share/consolefonts/ter-132n\"))) ; for HDPI
+@end lisp
+@end deffn
+
 @deffn {Scheme Procedure} login-service @var{config}
 Return a service to run login according to @var{config}, a
 @code{<login-configuration>} object, which specifies the message of the day,
-- 
2.25.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services.
  2020-03-22  2:40     ` John Soo
@ 2020-03-22  3:12       ` John Soo
  2020-03-22 20:59         ` bug#40120: " Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: John Soo @ 2020-03-22  3:12 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 40120

[-- Attachment #1: Type: text/plain, Size: 87 bytes --]

Hi again,

Dang it I forgot to change the @end to @end defvr.

This fixes it.

- John


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix @end --]
[-- Type: text/x-patch, Size: 1483 bytes --]

From cb4cf2b72766d4416fe5d2dc69a03914ec3c06c4 Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1@asu.edu>
Date: Wed, 18 Mar 2020 08:33:59 -0700
Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
 Services.

* doc/guix.texi (Base Services): Add console-font-service-type.
---
 doc/guix.texi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 92125abccc..2c54dc3493 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -12282,6 +12282,23 @@ symlink:
 Return a service that sets the host name to @var{name}.
 @end deffn
 
+@defvr {Scheme Variable} console-font-service-type @var{tty-font-pairs}
+Install the given fonts on the specified ttys (fonts are per
+virtual console on the kernel Linux).  The value of this service is a list of
+tty/font pairs.  The font can be the name of a font provided by the @code{kbd}
+package or any valid argument to @command{setfont}, as in this example:
+
+@lisp
+'((\"tty1\" . \"LatGrkCyr-8x16\")
+  (\"tty2\" . (file-append
+                font-tamzen
+                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\"))
+  (\"tty3\" . (file-append
+                font-terminus
+                \"/share/consolefonts/ter-132n\"))) ; for HDPI
+@end lisp
+@end defvr
+
 @deffn {Scheme Procedure} login-service @var{config}
 Return a service to run login according to @var{config}, a
 @code{<login-configuration>} object, which specifies the message of the day,
-- 
2.25.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#40120: [PATCH] doc: guix.texi: Add console-font-service-type to Base Services.
  2020-03-22  3:12       ` John Soo
@ 2020-03-22 20:59         ` Ludovic Courtès
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2020-03-22 20:59 UTC (permalink / raw)
  To: John Soo; +Cc: 40120-done

Hi,

John Soo <jsoo1@asu.edu> skribis:

> From cb4cf2b72766d4416fe5d2dc69a03914ec3c06c4 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1@asu.edu>
> Date: Wed, 18 Mar 2020 08:33:59 -0700
> Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
>  Services.
>
> * doc/guix.texi (Base Services): Add console-font-service-type.

Applied with this changes:

> +@defvr {Scheme Variable} console-font-service-type @var{tty-font-pairs}

Remove @var{tty-font-pairs}.

> +@lisp
> +'((\"tty1\" . \"LatGrkCyr-8x16\")
> +  (\"tty2\" . (file-append
> +                font-tamzen
> +                \"/share/kbd/consolefonts/TamzenForPowerline10x20.psf\"))

Changed to quasiquote/unquote as needed (same in gnu/services/base.scm,
which had the same typo), and \" → ".

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-03-22 21:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 15:45 [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services John Soo
2020-03-21 22:42 ` Ludovic Courtès
2020-03-21 23:16   ` John Soo
2020-03-22  2:40     ` John Soo
2020-03-22  3:12       ` John Soo
2020-03-22 20:59         ` bug#40120: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).