unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: 40120@debbugs.gnu.org
Subject: [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services.
Date: Sat, 21 Mar 2020 23:42:54 +0100	[thread overview]
Message-ID: <87blopwcr5.fsf@gnu.org> (raw)
In-Reply-To: <CAKf5CqX7vff8nRYi-KnmTLBBAZU2pMo-zi94m=mBU1aNrRXjrw@mail.gmail.com> (John Soo's message of "Wed, 18 Mar 2020 15:45:01 +0000")

Hi John,

Thanks for improving the manual!  Some comments:

John Soo <jsoo1@asu.edu> skribis:

> From 6a7204a6396781c1bbc1db1defee362c0a8142f9 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1@asu.edu>
> Date: Wed, 18 Mar 2020 08:33:59 -0700
> Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
>  Services.
>
> * doc/guix.texi (console-font-service-type): Add it.
                  ^
This should be the name of the section this is added in.

> +@deffn {Scheme Procedure} console-font-service-type @var{tty-font-pairs}

This should be @defvr because it’s a variable, not a procedure (and thus
has no arguments).

Could you change that accordingly?  You can take inspiration from other
service types.

TIA!

Ludo’.

  reply	other threads:[~2020-03-21 22:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 15:45 [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to Base Services John Soo
2020-03-21 22:42 ` Ludovic Courtès [this message]
2020-03-21 23:16   ` John Soo
2020-03-22  2:40     ` John Soo
2020-03-22  3:12       ` John Soo
2020-03-22 20:59         ` bug#40120: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blopwcr5.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=40120@debbugs.gnu.org \
    --cc=jsoo1@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).