From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:33028)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFmqZ-0000en-3G
 for guix-patches@gnu.org; Sat, 21 Mar 2020 18:44:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFmqY-00016q-5K
 for guix-patches@gnu.org; Sat, 21 Mar 2020 18:44:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42414)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFmqY-00016m-2U
 for guix-patches@gnu.org; Sat, 21 Mar 2020 18:44:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFmqY-0004zq-1C
 for guix-patches@gnu.org; Sat, 21 Mar 2020 18:44:02 -0400
Subject: [bug#40120] [PATCH] doc: guix.texi: Add console-font-service-type to
 Base Services.
Resent-Message-ID: <handler.40120.B40120.158483058519113@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <CAKf5CqX7vff8nRYi-KnmTLBBAZU2pMo-zi94m=mBU1aNrRXjrw@mail.gmail.com>
Date: Sat, 21 Mar 2020 23:42:54 +0100
In-Reply-To: <CAKf5CqX7vff8nRYi-KnmTLBBAZU2pMo-zi94m=mBU1aNrRXjrw@mail.gmail.com>
 (John Soo's message of "Wed, 18 Mar 2020 15:45:01 +0000")
Message-ID: <87blopwcr5.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: John Soo <jsoo1@asu.edu>
Cc: 40120@debbugs.gnu.org

Hi John,

Thanks for improving the manual!  Some comments:

John Soo <jsoo1@asu.edu> skribis:

> From 6a7204a6396781c1bbc1db1defee362c0a8142f9 Mon Sep 17 00:00:00 2001
> From: John Soo <jsoo1@asu.edu>
> Date: Wed, 18 Mar 2020 08:33:59 -0700
> Subject: [PATCH] doc: guix.texi: Add console-font-service-type to Base
>  Services.
>
> * doc/guix.texi (console-font-service-type): Add it.
                  ^
This should be the name of the section this is added in.

> +@deffn {Scheme Procedure} console-font-service-type @var{tty-font-pairs}

This should be @defvr because it=E2=80=99s a variable, not a procedure (and=
 thus
has no arguments).

Could you change that accordingly?  You can take inspiration from other
service types.

TIA!

Ludo=E2=80=99.