From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6lO9LH+/tmQ5ZQAASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 18:36:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EGrSK3+/tmRoGAAA9RJhRA (envelope-from ) for ; Tue, 18 Jul 2023 18:36:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7AC3B4DEDB for ; Tue, 18 Jul 2023 18:36:15 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=oTyL4HXN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689698175; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sLykz4vYeqD9htLi17bR+/hh4sWk4e1LRwjb1mtRm/4=; b=bsPbreKh3zMph4CKHiOpBXbnSPgR2GHJ/YJtB6rPHCE+S3oO4sbAp1YQG29Zs2bMVSaceP xYO5WbJSXxiIeZ8sHEC1+uwLuftPz58W3fG808ycmjOIWmQqox8VnVgOeGmV+hZ3Z4mfU7 PhQvccWAbm3n4LsL23AUCiqhAGNTwU80wwmn+CpWjLyzNXsGFn9MOlw1ZYjP2ry88iDkA3 v3OxYTFmDsho+jyJEuyobUxIDitIcq2Xdd4tyvbOAHwamauVmn08kMFXe2V7tvz39CliO5 INfo+UuAee4VgxK5CfZyRjjXshcbNNm1OVV203wsF4PL/BVxP1YuseEVTJXuHQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689698175; a=rsa-sha256; cv=none; b=e2eDk+pRt/wQP1fxkPVQ1QcSGsr9tasluHzeCn5MSbhfgsISmRdYO6+jYRZGmdUQcuWZeR 29e6B2ocKLhiy05nO9RJmVAIuQlnfssJFbHfaRyWvO1T2W8aefkNEx56fSNyF9zRUNTA/w 3IzjHAf1+1BEiRTCUO3JrtREretNwkwiRn4pJ/gJ/md0AocVaw7gQ6hIknjw00+CUs3kMs cWujkm32B6/1Yniqpp3h5YPd3HL2fvKAbGnQ7zrO9qVMzynlPco9z9k03QJ5cHPONMNc2v qc4O9/M0jcYMeiDmFQ/Fk0Y09aelFaOZqipAzH8pMVBGqegw56av4ACW6aXkcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=oTyL4HXN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLngD-0008Nl-E6; Tue, 18 Jul 2023 12:36:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLngA-0008NS-3S for guix-patches@gnu.org; Tue, 18 Jul 2023 12:36:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLng9-0003wO-Qb for guix-patches@gnu.org; Tue, 18 Jul 2023 12:36:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLng9-0001Oh-Lw for guix-patches@gnu.org; Tue, 18 Jul 2023 12:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59552 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Liliana Marie Prikler Cc: Hilton Chain , 59552@debbugs.gnu.org, Nicolas Goaziou , Andrew Tropin Received: via spool by 59552-submit@debbugs.gnu.org id=B59552.16896981585362 (code B ref 59552); Tue, 18 Jul 2023 16:36:01 +0000 Received: (at 59552) by debbugs.gnu.org; 18 Jul 2023 16:35:58 +0000 Received: from localhost ([127.0.0.1]:54101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLng6-0001OQ-F4 for submit@debbugs.gnu.org; Tue, 18 Jul 2023 12:35:58 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:59570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLng3-0001OF-5s for 59552@debbugs.gnu.org; Tue, 18 Jul 2023 12:35:57 -0400 Date: Wed, 19 Jul 2023 00:35:25 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1689697902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sLykz4vYeqD9htLi17bR+/hh4sWk4e1LRwjb1mtRm/4=; b=oTyL4HXNP0gy10hwM0jrIL8s3J6S4cDe+EpGCb7HPMsj56gKA+LeyktKB7Avp6POVpkfsF xdLXA0MAJ00m55Drh2phK0p+WPiELa7iAl3Scu7L6LivWAG9KW6t8naJ31+1olemDgVWhu 09jazVwlzR/cOM8WQRqRpOcZx2G2R8rLvVfUvU8eIEiun4RvOOQVP6/XvyFkiWeHzRhQSZ X+LxuCTk5rkeQSyjCFh6efCOvaC4prJEhu3UnvonFl9AdBzUOLw2VctTkryt6W2TYB0vaX OEQOSpXF2fBOhO+7Z+6o4qUxUoMKiIqaxgdrPUf7HEYspnfhAvPvn/waYLho/Q== Message-ID: <875y6hyy7m.wl-hako@ultrarare.space> In-Reply-To: <797011fcc7b4dc7f7b291e2a28e28b4e2f902017.camel@gmail.com> References: <20221125011530.12585-1-hako@ultrarare.space> <797011fcc7b4dc7f7b291e2a28e28b4e2f902017.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ++ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.65 X-Spam-Score: -3.65 X-Migadu-Queue-Id: 7AC3B4DEDB X-Migadu-Scanner: mx1.migadu.com X-TUID: hzl0mYT1NlRw On Sun, 16 Jul 2023 15:17:01 +0800, Liliana Marie Prikler wrote: > I think this should be=C2=A0 > (or (executable-find program)=C2=A0 > (cdr-safe (assoc program )) > where some hardcoded table contains stubs to fill in via=C2=A0 > (search-input-file =E2=80=A6) Thank you for the suggestion! Sorry for the incomplete information, the PROGRAM argument is actually nonsense because `wakatime-find-binary' is not a user-facing function and is called with a fixed value of "wakatime-cli", so it's not appropriate to use an alist. =20 Other (hardcoded) values are actually handled as conditions within the function.=20 I tried replacing the conditions with yours, except for the `cdr-safe' line, which is replaced by a `locate-file', and it seems to work fine. The new function does not contain a "/bin/[...]" so 'patch-el-files won't handle it. This may not be expected but I think it's enough to improve the function itself. I'll send a patch to upstream and send v3 later. Thanks