[bug#41954] [PATCH] gnu: Add gmic.

[Marius Bakke <marius@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1771 bytes --]

Vinicius Monego <monego@posteo.net> writes:

> * gnu/packages/image-processing.scm (gmic): New variable.

[...]
  
> +(define-public gmic
> +  (package
> +    (name "gmic")
> +    (version "2.9.1")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append
> +            "https://gmic.eu/files/source/gmic_"
> +            version ".tar.gz"))
> +      (sha256
> +       (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f))

Can you add a comment about why tests are disabled?

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("curl" ,curl)
> +       ("fftw" ,fftw)
> +       ("graphicsmagick" ,graphicsmagick)
> +       ("libjpeg-turbo" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("libtiff" ,libtiff)
> +       ("libx11" ,libx11)
> +       ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI

:-(

> +       ("openexr" ,openexr)
> +       ("zlib" ,zlib)))
> +    (home-page "https://gmic.eu/")
> +    (synopsis "Full-featured framework for digital image processing")
> +    (description "G'MIC is a full-featured framework for digital image
> +processing.  It provides several user interfaces to convert / manipulate
> +/ filter / visualize generic image datasets, ranging from 1D scalar
> +signals to 3D+t sequences of multi-spectral volumetric images, hence
> +including 2D color images.")
> +    (license (list license:cecill ;; G'MIC is dual-licensed.
> +                   license:cecill-c))))

Can you expand on the license comment a bit?  Can the user choose which
license, or do both apply somehow?

Otherwise LGTM, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]