From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2GcUHyQf8V6sTgAA0tVLHw (envelope-from ) for ; Mon, 22 Jun 2020 21:14:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kHzsGiQf8V6RXAAAbx9fmQ (envelope-from ) for ; Mon, 22 Jun 2020 21:14:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0FF9F9401CF for ; Mon, 22 Jun 2020 21:14:12 +0000 (UTC) Received: from localhost ([::1]:39412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnTlb-0002GH-1K for larch@yhetil.org; Mon, 22 Jun 2020 17:14:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnTlS-0002GA-06 for guix-patches@gnu.org; Mon, 22 Jun 2020 17:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnTlR-0005ew-N4 for guix-patches@gnu.org; Mon, 22 Jun 2020 17:14:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnTlR-0002ZR-J5 for guix-patches@gnu.org; Mon, 22 Jun 2020 17:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41954] [PATCH] gnu: Add gmic. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Jun 2020 21:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41954 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego , 41954@debbugs.gnu.org Cc: Vinicius Monego Received: via spool by 41954-submit@debbugs.gnu.org id=B41954.15928604249851 (code B ref 41954); Mon, 22 Jun 2020 21:14:01 +0000 Received: (at 41954) by debbugs.gnu.org; 22 Jun 2020 21:13:44 +0000 Received: from localhost ([127.0.0.1]:34729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnTlA-0002Yo-FV for submit@debbugs.gnu.org; Mon, 22 Jun 2020 17:13:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnTl8-0002Ya-SK for 41954@debbugs.gnu.org; Mon, 22 Jun 2020 17:13:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49300) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnTl2-0005T6-Qk; Mon, 22 Jun 2020 17:13:36 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:59158 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jnTl1-0002s8-D8; Mon, 22 Jun 2020 17:13:36 -0400 From: Marius Bakke In-Reply-To: <20200619202625.35415-1-monego@posteo.net> References: <20200619202625.35415-1-monego@posteo.net> Date: Mon, 22 Jun 2020 23:13:31 +0200 Message-ID: <87366mby84.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.6 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: 1SQVSChlEHS3 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vinicius Monego writes: > * gnu/packages/image-processing.scm (gmic): New variable. [...] =20=20 > +(define-public gmic > + (package > + (name "gmic") > + (version "2.9.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://gmic.eu/files/source/gmic_" > + version ".tar.gz")) > + (sha256 > + (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah")))) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f)) Can you add a comment about why tests are disabled? > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("curl" ,curl) > + ("fftw" ,fftw) > + ("graphicsmagick" ,graphicsmagick) > + ("libjpeg-turbo" ,libjpeg-turbo) > + ("libpng" ,libpng) > + ("libtiff" ,libtiff) > + ("libx11" ,libx11) > + ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI :-( > + ("openexr" ,openexr) > + ("zlib" ,zlib))) > + (home-page "https://gmic.eu/") > + (synopsis "Full-featured framework for digital image processing") > + (description "G'MIC is a full-featured framework for digital image > +processing. It provides several user interfaces to convert / manipulate > +/ filter / visualize generic image datasets, ranging from 1D scalar > +signals to 3D+t sequences of multi-spectral volumetric images, hence > +including 2D color images.") > + (license (list license:cecill ;; G'MIC is dual-licensed. > + license:cecill-c)))) Can you expand on the license comment a bit? Can the user choose which license, or do both apply somehow? Otherwise LGTM, thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7xHvsACgkQoqBt8qM6 VPoN9Qf/SBHJoKX0VBftez4iUrrr7u0FYsDXwHxJrNRn/bkACxFdSE7U32KCty5/ c1vYWWjQ6SKMLYQOi1e+U/gZjrj0ha4YZPsLweHUK/IjtyTZA3zh/8fJ+H3pc1aO adZDmf+auxngDaefazRGJw3Yfqva/hG4ofr9hcba52WhZwgkgW6pzXjBx52mJbYt ZPZe15MymO7JBY/DEyE5Kw757EexK6sb3howEaGTPqxN6wmtiCwLLyqv77kTeRFR 6v/Q+Kknrmz8Fv5WYhqIMFMh4igdKX4fXGZbid//VD+jN3qpbMCWRtyCupmHNbuC Sy8Mm3gJO55WbnE3EvUbMHX6oifggg== =S0x8 -----END PGP SIGNATURE----- --=-=-=--