From: Vinicius Monego <monego@posteo.net>
To: Marius Bakke <marius@gnu.org>, 41954@debbugs.gnu.org
Subject: [bug#41954] [PATCH] gnu: Add gmic.
Date: Mon, 22 Jun 2020 19:01:38 -0300 [thread overview]
Message-ID: <56c2220a8ca0246e3d13857b11376becbb79cd8a.camel@posteo.net> (raw)
In-Reply-To: <87366mby84.fsf@gnu.org>
Em seg, 2020-06-22 às 23:13 +0200, Marius Bakke escreveu:
> Vinicius Monego <monego@posteo.net> writes:
>
> > * gnu/packages/image-processing.scm (gmic): New variable.
>
> [...]
>
> > +(define-public gmic
> > + (package
> > + (name "gmic")
> > + (version "2.9.1")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (string-append
> > + "https://gmic.eu/files/source/gmic_"
> > + version ".tar.gz"))
> > + (sha256
> > + (base32
> > "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))
> > + (build-system cmake-build-system)
> > + (arguments
> > + `(#:tests? #f))
>
> Can you add a comment about why tests are disabled?
Yes, there are no tests.
> > + (native-inputs
> > + `(("pkg-config" ,pkg-config)))
> > + (inputs
> > + `(("curl" ,curl)
> > + ("fftw" ,fftw)
> > + ("graphicsmagick" ,graphicsmagick)
> > + ("libjpeg-turbo" ,libjpeg-turbo)
> > + ("libpng" ,libpng)
> > + ("libtiff" ,libtiff)
> > + ("libx11" ,libx11)
> > + ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI
>
> :-(
>
> > + ("openexr" ,openexr)
> > + ("zlib" ,zlib)))
> > + (home-page "https://gmic.eu/")
> > + (synopsis "Full-featured framework for digital image
> > processing")
> > + (description "G'MIC is a full-featured framework for digital
> > image
> > +processing. It provides several user interfaces to convert /
> > manipulate
> > +/ filter / visualize generic image datasets, ranging from 1D
> > scalar
> > +signals to 3D+t sequences of multi-spectral volumetric images,
> > hence
> > +including 2D color images.")
> > + (license (list license:cecill ;; G'MIC is dual-licensed.
> > + license:cecill-c))))
>
> Can you expand on the license comment a bit? Can the user choose
> which
> license, or do both apply somehow?
This is an excerpt from the copyright header in one of the files:
# This software is governed either by the CeCILL or the CeCILL-C
license
# under French law and abiding by the rules of distribution of free
software.
From my limited understanding, the user can choose either.
I will send a v2 with the proposed changes.
> Otherwise LGTM, thanks!
next prev parent reply other threads:[~2020-06-22 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 20:26 [bug#41954] [PATCH] gnu: Add gmic Vinicius Monego
2020-06-22 21:13 ` Marius Bakke
2020-06-22 22:01 ` Vinicius Monego [this message]
2020-06-22 22:36 ` [bug#42011] [PATCH v2] " Vinicius Monego
2020-06-24 19:15 ` bug#42011: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56c2220a8ca0246e3d13857b11376becbb79cd8a.camel@posteo.net \
--to=monego@posteo.net \
--cc=41954@debbugs.gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).