unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Vinicius Monego <monego@posteo.net>, 42011-done@debbugs.gnu.org
Cc: Vinicius Monego <monego@posteo.net>
Subject: bug#42011: [PATCH v2] gnu: Add gmic.
Date: Wed, 24 Jun 2020 21:15:29 +0200	[thread overview]
Message-ID: <87wo3w6zse.fsf@gnu.org> (raw)
In-Reply-To: <20200622223605.63850-1-monego@posteo.net>


[-- Attachment #1.1: Type: text/plain, Size: 167 bytes --]

Vinicius Monego <monego@posteo.net> writes:

> * gnu/packages/image-processing.scm (gmic): New variable.

Applied with the following cosmetic/idiomatic improvements:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: diff --]
[-- Type: text/x-patch, Size: 2012 bytes --]

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index 64b6395501..a11b1b89d3 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -494,15 +494,14 @@ due to its architecture which automatically parallelises the image workflows.")
     (version "2.9.1")
     (source
      (origin
-      (method url-fetch)
-      (uri (string-append
-            "https://gmic.eu/files/source/gmic_"
-            version ".tar.gz"))
-      (sha256
-       (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))
+       (method url-fetch)
+       (uri (string-append "https://gmic.eu/files/source/gmic_"
+                           version ".tar.gz"))
+       (sha256
+        (base32 "13axx7nwchn6ysgpvlw3fib474q4nrwv3qn20g3q03ldid0xvjah"))))
     (build-system cmake-build-system)
     (arguments
-     `(#:tests? #f)) ;; There are no tests.
+     `(#:tests? #f))                    ;there are no tests
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (inputs
@@ -513,7 +512,7 @@ due to its architecture which automatically parallelises the image workflows.")
        ("libpng" ,libpng)
        ("libtiff" ,libtiff)
        ("libx11" ,libx11)
-       ;;("opencv" ,opencv) ; OpenCV is currently broken in the CI
+       ;;("opencv" ,opencv) ;OpenCV is currently broken in the CI
        ("openexr" ,openexr)
        ("zlib" ,zlib)))
     (home-page "https://gmic.eu/")
@@ -523,8 +522,8 @@ processing.  It provides several user interfaces to convert / manipulate
 / filter / visualize generic image datasets, ranging from 1D scalar
 signals to 3D+t sequences of multi-spectral volumetric images, hence
 including 2D color images.")
-    (license (list license:cecill ;; Dual-licensed, either license applies.
-                   license:cecill-c))))
+    ;; Dual-licensed, either license applies.
+    (license (list license:cecill license:cecill-c))))
 
 (define-public nip2
   (package

[-- Attachment #1.3: Type: text/plain, Size: 9 bytes --]


Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2020-06-24 19:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 20:26 [bug#41954] [PATCH] gnu: Add gmic Vinicius Monego
2020-06-22 21:13 ` Marius Bakke
2020-06-22 22:01   ` Vinicius Monego
2020-06-22 22:36   ` [bug#42011] [PATCH v2] " Vinicius Monego
2020-06-24 19:15     ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo3w6zse.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=42011-done@debbugs.gnu.org \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).