From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GCtOCsA6F1+bSAAA0tVLHw (envelope-from ) for ; Tue, 21 Jul 2020 18:58:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GCkTBsA6F18KOAAAbx9fmQ (envelope-from ) for ; Tue, 21 Jul 2020 18:58:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0C8B94053C for ; Tue, 21 Jul 2020 18:58:07 +0000 (UTC) Received: from localhost ([::1]:40004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxxSo-00074c-KK for larch@yhetil.org; Tue, 21 Jul 2020 14:58:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxxSj-00074D-WF for guix-patches@gnu.org; Tue, 21 Jul 2020 14:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57120) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxxSj-0003Cn-Mv for guix-patches@gnu.org; Tue, 21 Jul 2020 14:58:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxxSj-0006SH-Mn for guix-patches@gnu.org; Tue, 21 Jul 2020 14:58:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42087] [PATCH 6/6] gnu: Add python-pre-commit. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jul 2020 18:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42087 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 42087@debbugs.gnu.org Received: via spool by 42087-submit@debbugs.gnu.org id=B42087.159535784824747 (code B ref 42087); Tue, 21 Jul 2020 18:58:01 +0000 Received: (at 42087) by debbugs.gnu.org; 21 Jul 2020 18:57:28 +0000 Received: from localhost ([127.0.0.1]:40427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxxSC-0006R5-ET for submit@debbugs.gnu.org; Tue, 21 Jul 2020 14:57:28 -0400 Received: from mout02.posteo.de ([185.67.36.66]:59357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxxSA-0006Qp-MT for 42087@debbugs.gnu.org; Tue, 21 Jul 2020 14:57:27 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 737F62400FE for <42087@debbugs.gnu.org>; Tue, 21 Jul 2020 20:57:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1595357840; bh=tmq+y7gHmwg1867/46FnYBdvCP0HfgV0pbnSKFJ5AIA=; h=Subject:From:To:Date:From; b=N42x2r+J6M8pJTEZREwrbyEpDGVHgNaJJo2T493iZbK+Yj/VCLePutKNVZS1jnz2E CaA6ZOtmKcekvywCLd24dtV7P9yz5O2iNHFRD66Ls2p06OGRTOYnoDYbgy1/3ZR7ma xzaAZF8xBVxbScJHlTO5WlVL7MH1VAbKD5dWYHjM+PULQH0Mlwyl5fmakFP2Ii5NRI +CPpibGc82rVav/0+DRLq5LvXfHO5RE6raFUdwERyQkIJuThY0g4SIMNuFUAKJvii+ nVBhuLMC1+xpMOJ114edJODCOcv1+/TmP8HVNm2YLLs3ldA7XCwa1Nkg6zT/nwT3WH 2xTkBwTVgPxyw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BB7BQ70rDz6tmG; Tue, 21 Jul 2020 20:57:18 +0200 (CEST) Message-ID: <52c2671a6aeffc4aa22bba631a871965317b7217.camel@posteo.net> From: Vinicius Monego Date: Tue, 21 Jul 2020 15:57:14 -0300 In-Reply-To: <87o8o9hnrq.fsf@gnu.org> References: <20200627154645.64264-1-monego@posteo.net> <20200627154645.64264-6-monego@posteo.net> <87o8o9hnrq.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.net header.s=2017 header.b=N42x2r+J; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: gywK+y11gtZV Em seg, 2020-07-20 às 23:36 +0200, Marius Bakke escreveu: > Do they really require Tox directly? Tox is fairly redundant in > Guix, > as all it does is create an isolated environment for running tests, > which Guix already does. So the usual approach is to copy the > command > for running tests out of tox.ini and run it directly in the check > phase. Is that an option here? I read CONTRIBUTING.md and those were the instructions. I was running into weird error messages and assumed the cause was tox not being used. But, nevermind. It was simply that, like in the previous packages, the PyPI tarball does not include tests. I downloaded a git checkout and now the tests are running, though with many deselections. > Does this program produce a regular executable? I.e. it's not > intended > for use as a library? In that case you can simply add these as > regular > inputs, and the executable will be "wrapped" with the correct > PYTHONPATH. That's correct. It provides a regular executable. > Also, maybe we can omit the python- prefix here too, and perhaps > place > it in version-control.scm? That makes sense to me. > Can you send a v2 series? I will bump some versions, enable tests here and send a v2 by the weekend.