unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Rovanion Luckey <rovanion.luckey@gmail.com>
Cc: 45638@debbugs.gnu.org
Subject: [bug#45638] gnu: Add nomacs photo lounge.
Date: Mon, 04 Jan 2021 10:43:06 +0100	[thread overview]
Message-ID: <39ecb70bd65390d146d3d1274660db5fa956ce62.camel@student.tugraz.at> (raw)
In-Reply-To: <CAAaf0CBU5O2ZyU-ReZjV5w49ETXhoHwD5ijVO5u5CpTo5X5t+A@mail.gmail.com>

Hi Rovanion,

Am Sonntag, den 03.01.2021, 22:38 +0100 schrieb Rovanion Luckey:
> It is built with plugins but not with HEIF or PSD support. I tried 
> +    (synopsis "Image viewer for all common formats including RAW and
> PSD.")
Ehm, that's kinda false advertisement then 😉

> +    (inputs `(("plugins"    ,(origin (method git-fetch)
> +                                     (uri (git-reference
> +                                           (url "
> https://github.com/nomacs/nomacs-plugins")
> +                                           (commit "3.16")))
> +                                     (sha256 (base32
> "1cpdwhfvaxm970nwdc1hc13848a85pqqi176m9xpa3krla9qskml"))))
> +              ("exiv2"      ,exiv2)
> +              ("libraw"     ,libraw)
> +              ("libtiff"    ,libtiff)
> +              ("opencv"     ,opencv)
> +              ("python"     ,python-wrapper)
> +              ("quazip"     ,quazip)
> +              ("qtbase"     ,qtbase)
> +              ("qtsvg"      ,qtsvg)
> +              ("qtlinguist" ,qttools)))
Please use a new line after (inputs and don't try to line up the
columns.
You may want to use ,(version-major+minor version) for the plugins
commit, if it's known that the two will always be bumped together.  But
using "3.16" as you did is also fine.

> +    (description "Nomacs is a free, open source image viewer, which
> supports multiple platforms. You can use it for viewing all common
> image formats including RAW and psd images.
> +
> +Nomacs features semi-transparent widgets that display additional
> information such as thumbnails, metadata or histogram. It is able to
> browse images in zip or MS Office files which can be extracted to a
> directory. Metadata stored with the image can be displayed and you
> can add notes to images. A thumbnail preview of the current folder is
> included as well as a file explorer panel which allows switching
> between folders. Within a directory you can apply a file filter, so
> that only images are displayed whose filenames have a certain string
> or match a regular expression. Activating the cache allows for
> instantly switching between images.
> +
> +Nomacs includes image manipulation methods for adjusting brightness,
> contrast, saturation, hue, gamma, exposure. It has a pseudo color
> function which allows creating false color images. A unique feature
> of Nomacs is the synchronization of multiple instances. With this
> feature you can easily compare images by zooming and/or panning at
> the exactly same position or even by overlaying them with different
> opacity.
> +Nomacs is licensed under the GNU General Public License v3 and
> available for Windows, Linux, FreeBSD, Mac, and OS/2.")
fill-column is 78, also the description is still too long.  Try to
compact it a bit.

Otherwise LGTM.

Regards,
Leo





  reply	other threads:[~2021-01-04  9:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03 21:38 [bug#45638] gnu: Add nomacs photo lounge Rovanion Luckey
2021-01-04  9:43 ` Leo Prikler [this message]
2021-01-04 11:47   ` Rovanion Luckey
2021-01-04 12:33     ` Leo Prikler
2021-01-04 12:55       ` Rovanion Luckey
2021-01-04 14:10         ` bug#45638: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39ecb70bd65390d146d3d1274660db5fa956ce62.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=45638@debbugs.gnu.org \
    --cc=rovanion.luckey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).