From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aFd1IGrj8l8hIAAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 09:44:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id mLkoHGrj8l9BIQAAbx9fmQ (envelope-from ) for ; Mon, 04 Jan 2021 09:44:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DEA4A94060F for ; Mon, 4 Jan 2021 09:44:09 +0000 (UTC) Received: from localhost ([::1]:33030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwMPI-0004WB-RC for larch@yhetil.org; Mon, 04 Jan 2021 04:44:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwMPC-0004W1-4K for guix-patches@gnu.org; Mon, 04 Jan 2021 04:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42750) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwMPB-0005w0-Tf for guix-patches@gnu.org; Mon, 04 Jan 2021 04:44:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwMPB-0002E8-Np for guix-patches@gnu.org; Mon, 04 Jan 2021 04:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45638] gnu: Add nomacs photo lounge. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 04 Jan 2021 09:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45638 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Rovanion Luckey Received: via spool by 45638-submit@debbugs.gnu.org id=B45638.16097534098433 (code B ref 45638); Mon, 04 Jan 2021 09:44:01 +0000 Received: (at 45638) by debbugs.gnu.org; 4 Jan 2021 09:43:29 +0000 Received: from localhost ([127.0.0.1]:54251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMOY-0002BQ-Lb for submit@debbugs.gnu.org; Mon, 04 Jan 2021 04:43:29 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:54658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwMON-0002Ac-7K for 45638@debbugs.gnu.org; Mon, 04 Jan 2021 04:43:21 -0500 Received: from nijino.local (217-149-174-13.nat.highway.telekom.at [217.149.174.13]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4D8Vzv5ltpz1LBTq; Mon, 4 Jan 2021 10:43:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4D8Vzv5ltpz1LBTq DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1609753388; bh=zb7VLpdQQQXLhmkOyTuz9/tulbNNmNHLgSmZbbwdJIE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=KWDi4X3waBF/eM4wfi+TnwLr0pgskQ7mg0viriefCFYcMPQK+MJlVNtGc+HoaklYe oXuYzRE0YbFFgPKDRdf3FXCFXUQDRFQZd15crTBH62kHVMb87TclF7qQDoUAuotpeE GrbXdYwJLJZvfy0jkgMU2lLZ71vMlPGJPBvbGY4M= Message-ID: <39ecb70bd65390d146d3d1274660db5fa956ce62.camel@student.tugraz.at> From: Leo Prikler Date: Mon, 04 Jan 2021 10:43:06 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45638@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.23 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tugraz.at header.s=mailrelay header.b=KWDi4X3w; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DEA4A94060F X-Spam-Score: -1.23 X-Migadu-Scanner: scn0.migadu.com X-TUID: pyljyTGJqsj7 Hi Rovanion, Am Sonntag, den 03.01.2021, 22:38 +0100 schrieb Rovanion Luckey: > It is built with plugins but not with HEIF or PSD support. I tried > + (synopsis "Image viewer for all common formats including RAW and > PSD.") Ehm, that's kinda false advertisement then 😉 > + (inputs `(("plugins" ,(origin (method git-fetch) > + (uri (git-reference > + (url " > https://github.com/nomacs/nomacs-plugins") > + (commit "3.16"))) > + (sha256 (base32 > "1cpdwhfvaxm970nwdc1hc13848a85pqqi176m9xpa3krla9qskml")))) > + ("exiv2" ,exiv2) > + ("libraw" ,libraw) > + ("libtiff" ,libtiff) > + ("opencv" ,opencv) > + ("python" ,python-wrapper) > + ("quazip" ,quazip) > + ("qtbase" ,qtbase) > + ("qtsvg" ,qtsvg) > + ("qtlinguist" ,qttools))) Please use a new line after (inputs and don't try to line up the columns. You may want to use ,(version-major+minor version) for the plugins commit, if it's known that the two will always be bumped together. But using "3.16" as you did is also fine. > + (description "Nomacs is a free, open source image viewer, which > supports multiple platforms. You can use it for viewing all common > image formats including RAW and psd images. > + > +Nomacs features semi-transparent widgets that display additional > information such as thumbnails, metadata or histogram. It is able to > browse images in zip or MS Office files which can be extracted to a > directory. Metadata stored with the image can be displayed and you > can add notes to images. A thumbnail preview of the current folder is > included as well as a file explorer panel which allows switching > between folders. Within a directory you can apply a file filter, so > that only images are displayed whose filenames have a certain string > or match a regular expression. Activating the cache allows for > instantly switching between images. > + > +Nomacs includes image manipulation methods for adjusting brightness, > contrast, saturation, hue, gamma, exposure. It has a pseudo color > function which allows creating false color images. A unique feature > of Nomacs is the synchronization of multiple instances. With this > feature you can easily compare images by zooming and/or panning at > the exactly same position or even by overlaying them with different > opacity. > +Nomacs is licensed under the GNU General Public License v3 and > available for Windows, Linux, FreeBSD, Mac, and OS/2.") fill-column is 78, also the description is still too long. Try to compact it a bit. Otherwise LGTM. Regards, Leo