unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Rovanion Luckey <rovanion.luckey@gmail.com>
Cc: 45638@debbugs.gnu.org
Subject: [bug#45638] gnu: Add nomacs photo lounge.
Date: Mon, 04 Jan 2021 13:33:57 +0100	[thread overview]
Message-ID: <3c43489bb017eccb3f60ab17479604013f93cfee.camel@student.tugraz.at> (raw)
In-Reply-To: <CAAaf0CD_ZU1_oHfBGS2iOUi605ji9Udguc3HGaEbL4sGwRqj=g@mail.gmail.com>

Hi Rovanion,
Am Montag, den 04.01.2021, 12:47 +0100 schrieb Rovanion Luckey:
> Den mån 4 jan. 2021 kl 10:43 skrev Leo Prikler <
> leo.prikler@student.tugraz.at>:
> > Ehm, that's kinda false advertisement then 😉
> 
>  Advertisement modified in the attached patch.
Thanks.  I've done a little rewording on top.

> > Please use a new line after (inputs and don't try to line up the
> > columns.
> 
> Ahw, but I like my aligned columns. Oh well, modified.
Sure, but aligning leads to much noise when adding inputs.
 
> > You may want to use ,(version-major+minor version) for the plugins
> > commit, if it's known that the two will always be bumped together. 
> > But
> > using "3.16" as you did is also fine.
> 
> The plugins get tagged very irregurarily.
Nvm then.

> > fill-column is 78, also the description is still too long.  Try to
> > compact it a bit.
> 
> Compacted.
Thanks.
I'm about to push that commit with some slight cosmetic changes, but
I've come to see, that #:tests? are #f.  Is there a reason for this?

Regards,
Leo





  reply	other threads:[~2021-01-04 12:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03 21:38 [bug#45638] gnu: Add nomacs photo lounge Rovanion Luckey
2021-01-04  9:43 ` Leo Prikler
2021-01-04 11:47   ` Rovanion Luckey
2021-01-04 12:33     ` Leo Prikler [this message]
2021-01-04 12:55       ` Rovanion Luckey
2021-01-04 14:10         ` bug#45638: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c43489bb017eccb3f60ab17479604013f93cfee.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=45638@debbugs.gnu.org \
    --cc=rovanion.luckey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).