unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Rovanion Luckey <rovanion.luckey@gmail.com>
Cc: 45638-done@debbugs.gnu.org
Subject: bug#45638: gnu: Add nomacs photo lounge.
Date: Mon, 04 Jan 2021 15:10:32 +0100	[thread overview]
Message-ID: <b3d1048afda202cb8054ecd03d84cac2abc11ffb.camel@student.tugraz.at> (raw)
In-Reply-To: <CAAaf0CCbPghfo5Xzr-xWPbDZzKeakuNU6+gdV75OM2pk4vfu3w@mail.gmail.com>

Hi Rovanion,
Am Montag, den 04.01.2021, 13:55 +0100 schrieb Rovanion Luckey:
> > I'm about to push that commit with some slight cosmetic changes,
> > but
> > I've come to see, that #:tests? are #f.  Is there a reason for
> > this?
> 
> Mistake left from when I redid the build a large number of times and
> didn't want to sit through half an hour of tests each time. It should
> be set to true before pushing (or the line removed). 
It turns out, that there is no test target, so apparently you did the
right thing.
I've applied my cosmetic changes, fixed up the commit message and
pushed it as 08f35b9b6ca635f439bc2b01965aeb73e7ec282d.  Thanks!






      reply	other threads:[~2021-01-04 14:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-03 21:38 [bug#45638] gnu: Add nomacs photo lounge Rovanion Luckey
2021-01-04  9:43 ` Leo Prikler
2021-01-04 11:47   ` Rovanion Luckey
2021-01-04 12:33     ` Leo Prikler
2021-01-04 12:55       ` Rovanion Luckey
2021-01-04 14:10         ` Leo Prikler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3d1048afda202cb8054ecd03d84cac2abc11ffb.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=45638-done@debbugs.gnu.org \
    --cc=rovanion.luckey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).