* [bug#40195] Add Docusign python API module as a package @ 2020-03-23 14:26 Josh Marshall 2020-03-23 19:39 ` Leo Famulari 0 siblings, 1 reply; 6+ messages in thread From: Josh Marshall @ 2020-03-23 14:26 UTC (permalink / raw) To: 40195 [-- Attachment #1: Type: text/plain, Size: 285 bytes --] Add Docusign python API module as a package --- The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible. [-- Attachment #2: 0001-Adding-Docusign-python-API-module-as-a-package.patch --] [-- Type: application/octet-stream, Size: 2039 bytes --] From 5eb5f5e710994d1fa1c6115ba020201182d81605 Mon Sep 17 00:00:00 2001 From: Josh Marshall <josh.marshall@jax.org> Date: Mon, 23 Mar 2020 10:19:43 -0400 Subject: [PATCH] Adding Docusign python API module as a package. To: guix-patches@gnu.org --- gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 8271e1ff7e..de8a2b82aa 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -70,6 +70,7 @@ ;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net> ;;; Copyright © 2020 sirgazil <sirgazil@zoho.com> ;;; Copyright © 2020 Sebastian Schott <sschott@mailbox.org> +;;; Copyright © 2020 Josh Marshall <joshua.r.marshall.1991@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -18235,3 +18236,30 @@ sequences.") (define-public python2-fuzzywuzzy (package-with-python2 python-fuzzywuzzy)) + + +(define-public python-docusign + (package + (name "python-docusign") + (version "3.0.0") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/docusign/docusign-python-client/archive/v" version ".tar.gz")) + (sha256 + (base32 + "0nq9g7dbl4r2xfh76612sa226psmi3isnam7hvmar09wspy1m8a4")))) + (build-system python-build-system) + (arguments `(#:tests? #f)) + (propagated-inputs + `(("python-certifi", python-certifi) + ("python-six", python-six) + ("python-dateutil", python-dateutil) + ("python-urllib3", python-urllib3) + ("python-pyjwt", python-pyjwt) + ("python-cryptography", python-cryptography) + ("python-nose", python-nose))) + (synopsis "The Official DocuSign Python Client") + (description "The Official DocuSign Python Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.") + (home-page "https://www.docusign.com/devcenter") + (license license:expat))) + -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#40195] Add Docusign python API module as a package 2020-03-23 14:26 [bug#40195] Add Docusign python API module as a package Josh Marshall @ 2020-03-23 19:39 ` Leo Famulari 2020-03-24 17:46 ` [bug#40195] [EXTERNAL]Re: " Josh Marshall 0 siblings, 1 reply; 6+ messages in thread From: Leo Famulari @ 2020-03-23 19:39 UTC (permalink / raw) To: Josh Marshall; +Cc: 40195 On Mon, Mar 23, 2020 at 02:26:10PM +0000, Josh Marshall wrote: > Add Docusign python API module as a package Thanks! I have a few changes... The tarballs that GitHub automatically generates per-tag (named like 'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we should package this either from the Git tag or from PyPI: https://pypi.org/project/docusign-esign/ I think we should take the PyPi name as canonical, so as a Python library, this Guix package should be called 'python-docusign-esign'. Why are the tests skipped? Can you add a code comment? Even just "No test suite" if that is the case. Make sure to lint the package. You may need to do it in a Guix development environment; something like this should work: `guix environment guix -- ./pre-inst-env guix lint python-docusign`. Can you send a revised patch? Also, does this integrate with any Guix packages? ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#40195] [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a package 2020-03-23 19:39 ` Leo Famulari @ 2020-03-24 17:46 ` Josh Marshall 2020-03-24 19:39 ` Leo Famulari 0 siblings, 1 reply; 6+ messages in thread From: Josh Marshall @ 2020-03-24 17:46 UTC (permalink / raw) To: Leo Famulari; +Cc: 40195@debbugs.gnu.org [-- Attachment #1: Type: text/plain, Size: 1001 bytes --] The tarballs that GitHub automatically generates per-tag (named like 'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we should package this either from the Git tag or from PyPI: > Done I think we should take the PyPi name as canonical, so as a Python library, this Guix package should be called 'python-docusign-esign'. > Done Why are the tests skipped? Can you add a code comment? Even just "No test suite" if that is the case. > Done Make sure to lint the package. You may need to do it in a Guix development environment; something like this should work: > I couldn't figure the command -- thanks. Also done Can you send a revised patch? > See attached Also, does this integrate with any Guix packages? > No? --- The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible. [-- Attachment #2: 0001-Adding-Docusign-python-API-module-as-a-package.patch --] [-- Type: application/octet-stream, Size: 2018 bytes --] From 5eb5f5e710994d1fa1c6115ba020201182d81605 Mon Sep 17 00:00:00 2001 From: Josh Marshall <josh.marshall@jax.org> Date: Mon, 23 Mar 2020 10:19:43 -0400 Subject: [PATCH 1/2] Adding Docusign python API module as a package. --- gnu/packages/python-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 8271e1ff7e..de8a2b82aa 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -70,6 +70,7 @@ ;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net> ;;; Copyright © 2020 sirgazil <sirgazil@zoho.com> ;;; Copyright © 2020 Sebastian Schott <sschott@mailbox.org> +;;; Copyright © 2020 Josh Marshall <joshua.r.marshall.1991@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -18235,3 +18236,30 @@ sequences.") (define-public python2-fuzzywuzzy (package-with-python2 python-fuzzywuzzy)) + + +(define-public python-docusign + (package + (name "python-docusign") + (version "3.0.0") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/docusign/docusign-python-client/archive/v" version ".tar.gz")) + (sha256 + (base32 + "0nq9g7dbl4r2xfh76612sa226psmi3isnam7hvmar09wspy1m8a4")))) + (build-system python-build-system) + (arguments `(#:tests? #f)) + (propagated-inputs + `(("python-certifi", python-certifi) + ("python-six", python-six) + ("python-dateutil", python-dateutil) + ("python-urllib3", python-urllib3) + ("python-pyjwt", python-pyjwt) + ("python-cryptography", python-cryptography) + ("python-nose", python-nose))) + (synopsis "The Official DocuSign Python Client") + (description "The Official DocuSign Python Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.") + (home-page "https://www.docusign.com/devcenter") + (license license:expat))) + -- 2.25.1 [-- Attachment #3: 0002-Making-reccomended-changes.patch --] [-- Type: application/octet-stream, Size: 2116 bytes --] From fc33554b4013d3d8b4497f55146dce476598fb19 Mon Sep 17 00:00:00 2001 From: Josh Marshall <josh.marshall@jax.org> Date: Tue, 24 Mar 2020 13:01:03 -0400 Subject: [PATCH 2/2] Making reccomended changes. --- gnu/packages/python-xyz.scm | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index de8a2b82aa..979e4b5445 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -18240,15 +18240,18 @@ sequences.") (define-public python-docusign (package - (name "python-docusign") - (version "3.0.0") + (name "python-docusign-esign") + (version "3.1.0") (source (origin - (method url-fetch) - (uri (string-append "https://github.com/docusign/docusign-python-client/archive/v" version ".tar.gz")) + (method git-fetch) + (uri (git-reference + (url "https://github.com/docusign/docusign-python-client") + (commit "496cad818e1fc962babdcb3fe07ba9ff7d08d03c"))) (sha256 - (base32 - "0nq9g7dbl4r2xfh76612sa226psmi3isnam7hvmar09wspy1m8a4")))) + (base32 + "0nq9g7dbl4r2xfh76612sa226psmi3isnam7hvmar09wspy1m8a4")))) (build-system python-build-system) + ; Testing requires undocumented setup changes, and so testing is disabled here. (arguments `(#:tests? #f)) (propagated-inputs `(("python-certifi", python-certifi) @@ -18259,7 +18262,8 @@ sequences.") ("python-cryptography", python-cryptography) ("python-nose", python-nose))) (synopsis "The Official DocuSign Python Client") - (description "The Official DocuSign Python Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.") + (description "The Official DocuSign Python Client Library used to interact + with the eSign REST API. Send, sign, and approve documents using this client.") (home-page "https://www.docusign.com/devcenter") (license license:expat))) -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#40195] [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a package 2020-03-24 17:46 ` [bug#40195] [EXTERNAL]Re: " Josh Marshall @ 2020-03-24 19:39 ` Leo Famulari 2020-03-24 21:06 ` Josh Marshall 0 siblings, 1 reply; 6+ messages in thread From: Leo Famulari @ 2020-03-24 19:39 UTC (permalink / raw) To: Josh Marshall; +Cc: 40195-done@debbugs.gnu.org Thanks for the revisions! I pushed as b14c234c0d32216f8c2f6e6d1935c469a6b947c9 with a few more changes: I made it fetch from PyPi instead of Git since they didn't actually tag a 3.1.0 release. We'd rather take the thing that upstream definitely says is "the release" in cases like that. I made the variable name and package name consistent. And I simplified the synopsis to hopefully improve searchability. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#40195] [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a package 2020-03-24 19:39 ` Leo Famulari @ 2020-03-24 21:06 ` Josh Marshall 2020-03-24 21:20 ` Leo Famulari 0 siblings, 1 reply; 6+ messages in thread From: Josh Marshall @ 2020-03-24 21:06 UTC (permalink / raw) To: Leo Famulari; +Cc: 40195-done@debbugs.gnu.org Thanks! I'll try to do better on the next one I submit. ________________________________________ From: Leo Famulari <leo@famulari.name> Sent: Tuesday, March 24, 2020 3:39 PM To: Josh Marshall Cc: 40195-done@debbugs.gnu.org Subject: Re: [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a package Thanks for the revisions! I pushed as b14c234c0d32216f8c2f6e6d1935c469a6b947c9 with a few more changes: I made it fetch from PyPi instead of Git since they didn't actually tag a 3.1.0 release. We'd rather take the thing that upstream definitely says is "the release" in cases like that. I made the variable name and package name consistent. And I simplified the synopsis to hopefully improve searchability. --- The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#40195] [EXTERNAL]Re: [bug#40195] Add Docusign python API module as a package 2020-03-24 21:06 ` Josh Marshall @ 2020-03-24 21:20 ` Leo Famulari 0 siblings, 0 replies; 6+ messages in thread From: Leo Famulari @ 2020-03-24 21:20 UTC (permalink / raw) To: Josh Marshall; +Cc: 40195-done@debbugs.gnu.org On Tue, Mar 24, 2020 at 09:06:58PM +0000, Josh Marshall wrote: > Thanks! I'll try to do better on the next one I submit. Okay! The important thing is to get the patch in the queue :) ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-24 21:22 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-03-23 14:26 [bug#40195] Add Docusign python API module as a package Josh Marshall 2020-03-23 19:39 ` Leo Famulari 2020-03-24 17:46 ` [bug#40195] [EXTERNAL]Re: " Josh Marshall 2020-03-24 19:39 ` Leo Famulari 2020-03-24 21:06 ` Josh Marshall 2020-03-24 21:20 ` Leo Famulari
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).