From: Leo Famulari <leo@famulari.name>
To: Josh Marshall <Josh.Marshall@jax.org>
Cc: 40195@debbugs.gnu.org
Subject: [bug#40195] Add Docusign python API module as a package
Date: Mon, 23 Mar 2020 15:39:06 -0400 [thread overview]
Message-ID: <20200323193906.GA30452@jasmine.lan> (raw)
In-Reply-To: <BL0PR06MB467337164FD5310F6BC47585E9F00@BL0PR06MB4673.namprd06.prod.outlook.com>
On Mon, Mar 23, 2020 at 02:26:10PM +0000, Josh Marshall wrote:
> Add Docusign python API module as a package
Thanks! I have a few changes...
The tarballs that GitHub automatically generates per-tag (named like
'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we
should package this either from the Git tag or from PyPI:
https://pypi.org/project/docusign-esign/
I think we should take the PyPi name as canonical, so as a Python
library, this Guix package should be called 'python-docusign-esign'.
Why are the tests skipped? Can you add a code comment? Even just "No
test suite" if that is the case.
Make sure to lint the package. You may need to do it in a Guix
development environment; something like this should work:
`guix environment guix -- ./pre-inst-env guix lint python-docusign`.
Can you send a revised patch? Also, does this integrate with any Guix
packages?
next prev parent reply other threads:[~2020-03-23 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 14:26 [bug#40195] Add Docusign python API module as a package Josh Marshall
2020-03-23 19:39 ` Leo Famulari [this message]
2020-03-24 17:46 ` [bug#40195] [EXTERNAL]Re: " Josh Marshall
2020-03-24 19:39 ` Leo Famulari
2020-03-24 21:06 ` Josh Marshall
2020-03-24 21:20 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323193906.GA30452@jasmine.lan \
--to=leo@famulari.name \
--cc=40195@debbugs.gnu.org \
--cc=Josh.Marshall@jax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).