From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:47488)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jGSvc-0005Eo-0C
 for guix-patches@gnu.org; Mon, 23 Mar 2020 15:40:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jGSva-0001BZ-TW
 for guix-patches@gnu.org; Mon, 23 Mar 2020 15:40:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:47585)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jGSva-0001BS-O3
 for guix-patches@gnu.org; Mon, 23 Mar 2020 15:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jGSva-00052a-KF
 for guix-patches@gnu.org; Mon, 23 Mar 2020 15:40:02 -0400
Subject: [bug#40195] Add Docusign python API module as a package
Resent-Message-ID: <handler.40195.B40195.158499235819312@debbugs.gnu.org>
Date: Mon, 23 Mar 2020 15:39:06 -0400
From: Leo Famulari <leo@famulari.name>
Message-ID: <20200323193906.GA30452@jasmine.lan>
References: <BL0PR06MB467337164FD5310F6BC47585E9F00@BL0PR06MB4673.namprd06.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BL0PR06MB467337164FD5310F6BC47585E9F00@BL0PR06MB4673.namprd06.prod.outlook.com>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Josh Marshall <Josh.Marshall@jax.org>
Cc: 40195@debbugs.gnu.org

On Mon, Mar 23, 2020 at 02:26:10PM +0000, Josh Marshall wrote:
> Add Docusign python API module as a package

Thanks! I have a few changes...

The tarballs that GitHub automatically generates per-tag (named like
'v3.0.0.tar.gz') do sometimes change, which breaks our packaging. So we
should package this either from the Git tag or from PyPI:

https://pypi.org/project/docusign-esign/

I think we should take the PyPi name as canonical, so as a Python
library, this Guix package should be called 'python-docusign-esign'.

Why are the tests skipped? Can you add a code comment? Even just "No
test suite" if that is the case.

Make sure to lint the package. You may need to do it in a Guix
development environment; something like this should work:

`guix environment guix -- ./pre-inst-env guix lint python-docusign`.

Can you send a revised patch? Also, does this integrate with any Guix
packages?